Skip to content

Commit 7e234b8

Browse files
Merge pull request #416 from KipK/fix#411
Fix#411
2 parents fb11345 + 9ec7d4b commit 7e234b8

File tree

3 files changed

+2
-18
lines changed

3 files changed

+2
-18
lines changed

src/input.cpp

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ class InputTask : public MicroTasks::Task
6969
event["colour"] = evse.getStateColour();
7070
event["pilot"] = evse.getPilotState();
7171
event["manual_override"] = manual.isActive() ? 1 : 0; //TODO: remove this
72-
event["override"] = getOverride();
7372
event["session_energy"] = evse.getSessionEnergy();
7473
event_send(event);
7574
}
@@ -133,27 +132,12 @@ void create_rapi_json(JsonDocument &doc)
133132
doc["flags"] = evse.getFlags();
134133
doc["vehicle"] = evse.isVehicleConnected() ? 1 : 0;
135134
doc["colour"] = evse.getStateColour();
136-
doc["manual_override"] = manual.isActive() ? 1 : 0; //TODO: remove this
137-
//replace "manual_override", should be either 0 or json override claim.
138-
doc["override"] = getOverride();
135+
doc["manual_override"] = manual.isActive() ? 1 : 0;
139136
doc["freeram"] = ESPAL.getFreeHeap();
140137
doc["divertmode"] = divertmode;
141138
doc["srssi"] = WiFi.RSSI();
142139
}
143140

144-
String getOverride() {
145-
String override = "";
146-
const size_t capacity = JSON_OBJECT_SIZE(10) + 1024;
147-
DynamicJsonDocument doc(capacity);
148-
if(manual.isActive()) {
149-
evse.serializeClaim(doc, EvseClient_OpenEVSE_Manual);
150-
} else {
151-
doc["state"] = "null";
152-
}
153-
serializeJson(doc, override);
154-
return override;
155-
}
156-
157141
void
158142
handleRapiRead()
159143
{

src/input.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ extern String url;
1515
extern String data;
1616
extern String ohm_hour;
1717

18-
extern String getOverride();
1918
extern void handleRapiRead();
2019
extern void create_rapi_json(JsonDocument &data);
2120

src/web_server.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -816,6 +816,7 @@ void handleOverridePost(MongooseHttpServerRequest *request, MongooseHttpServerRe
816816
if(manual.claim(props)) {
817817
response->setCode(201);
818818
response->print("{\"msg\":\"Created\"}");
819+
mqtt_publish_override(); // update override state to mqtt
819820
} else {
820821
response->setCode(500);
821822
response->print("{\"msg\":\"Failed to claim manual overide\"}");

0 commit comments

Comments
 (0)