The SERIAL_RX_PULLUP_PIN fix/hack is no longer needed

We no longer need to explicitly pull up the serial read pin on boards that are based on the Huzzah ESP32 breakout board as the core now sets things up correctly.

Also override the upload command for the OpenEVSE WiFi board to use curl to upload via the HTTP upload, this is a lot more reliable for that board

Author: jeremypoulter

platformio.ini

@@ -177,7 +177,6 @@ build_flags =
   -D WIFI_BUTTON_PRESSED_STATE=LOW
   -D RAPI_PORT=Serial
   -D DEBUG_PORT=Serial2
-  -D SERIAL_RX_PULLUP_PIN=3
 
 [env:openevse_huzzah32]
 board = featheresp32
@@ -191,7 +190,6 @@ build_flags =
   -D WIFI_BUTTON_PRESSED_STATE=LOW
   -D RAPI_PORT=Serial
   -D DEBUG_PORT=Serial2
-  -D SERIAL_RX_PULLUP_PIN=3
 
 [env:openevse_featheresp32]
 board = featheresp32
@@ -223,12 +221,12 @@ build_flags =
   -D WIFI_BUTTON_PRESSED_STATE=LOW
   -D RAPI_PORT=Serial
   -D DEBUG_PORT=Serial1
-  -D SERIAL_RX_PULLUP_PIN=3
   -D I2C_SDA=21
   -D I2C_SCL=22
   -D ENABLE_MCP9808
   -D ENABLE_PN532
   -D TX1=16
+upload_command = curl -F firmware=@$SOURCE http://$UPLOAD_PORT/update --progress-bar | cat
 
 [env:openevse_esp32-gateway]
 #For hardware older than RevE

src/main.cpp

@@ -265,12 +265,6 @@ void event_send(JsonDocument &event)
 void hardware_setup()
 {
   debug_setup();
-
-#ifdef SERIAL_RX_PULLUP_PIN
-  // https://forums.adafruit.com/viewtopic.php?f=57&t=153553&p=759890&hilit=esp32+serial+pullup#p769168
-  pinMode(SERIAL_RX_PULLUP_PIN, INPUT_PULLUP);
-#endif
-
   enableLoopWDT();
 }