Merge pull request #58 from Ndacyayisenga-droid/patch-6

Added test to verify NullPointerException for null transactions

Author: hendrikebbers

hedera-base/src/main/java/com/openelements/hedera/base/protocol/ProtocolLayerClient.java

@@ -58,8 +58,22 @@ public interface ProtocolLayerClient {
     @NonNull
     FileCreateResult executeFileCreateTransaction(@NonNull FileCreateRequest request) throws HederaException;
 
+    /**
+     * Execute a file update transaction.
+     *
+     * @param  request  the request containing the details of the file update
+     * @return          the result of the file update transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     FileUpdateResult executeFileUpdateRequestTransaction(FileUpdateRequest request) throws HederaException;
 
+    /**
+     * Execute a file info query.
+     *
+     * @param  request  the request containing the details of the file info query
+     * @return          the response containing the information about the file
+     * @throws HederaException if the query could not be executed
+     */
     @NonNull
     FileInfoResponse executeFileInfoQuery(@NonNull FileInfoRequest request) throws HederaException;
 
@@ -84,34 +98,128 @@ ContractCreateResult executeContractCreateTransaction(@NonNull ContractCreateReq
     @NonNull
     ContractCallResult executeContractCallTransaction(@NonNull ContractCallRequest request) throws HederaException;
 
+    /**
+     * Executes a contract delete transaction.
+     *
+     * @param  request  the request containing the details of the contract delete transaction
+     * @return          the result of the contract delete transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     ContractDeleteResult executeContractDeleteTransaction(@NonNull final ContractDeleteRequest request)
             throws HederaException;
 
+    /**
+     * Executes an account create transaction.
+     *
+     * @param  request  the request containing the details of the account create transaction
+     * @return          the result of the account create transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     AccountCreateResult executeAccountCreateTransaction(@NonNull final AccountCreateRequest request)
             throws HederaException;
 
+    /**
+     * Executes an account delete transaction.
+     *
+     * @param  request  the request containing the details of the account delete transaction
+     * @return          the result of the account delete transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     AccountDeleteResult executeAccountDeleteTransaction(@NonNull AccountDeleteRequest request) throws HederaException;
 
+    /**
+     * Executes a token create transaction.
+     *
+     * @param  request  the request containing the details of the token create transaction
+     * @return          the result of the token create transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     TokenCreateResult executeTokenCreateTransaction(@NonNull final TokenCreateRequest request) throws HederaException;
 
+    /**
+     * Executes a token associate transaction.
+     *
+     * @param  request  the request containing the details of the token associate transaction
+     * @return          the result of the token associate transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     TokenAssociateResult executeTokenAssociateTransaction(@NonNull final TokenAssociateRequest request)
             throws HederaException;
 
+    /**
+     * Executes a token mint transaction.
+     *
+     * @param  request  the request containing the details of the token mint transaction
+     * @return          the result of the token mint transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     TokenMintResult executeMintTokenTransaction(@NonNull final TokenMintRequest request) throws HederaException;
 
+    /**
+     * Executes a token burn transaction.
+     *
+     * @param  request  the request containing the details of the token burn transaction
+     * @return          the result of the token burn transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     TokenBurnResult executeBurnTokenTransaction(@NonNull final TokenBurnRequest request) throws HederaException;
 
+    /**
+     * Executes a transfer transaction for an NFT.
+     *
+     * @param  request  the request containing the details of the token transfer transaction
+     * @return          the result of the token transfer transaction
+     * @throws HederaException if the transaction could not be executed
+     */
     @NonNull
     TokenTransferResult executeTransferTransactionForNft(@NonNull final TokenTransferRequest request)
             throws HederaException;
 
+    /**
+     * Executes a topic create transaction.
+     *
+     * @param  request  the request containing the details of the topic create transaction
+     * @return          the result of the topic create transaction
+     * @throws HederaException if the transaction could not be executed
+     */
+    @NonNull
+    TopicCreateResult executeTopicCreateTransaction(@NonNull TopicCreateRequest request) throws HederaException;
+
+    /**
+     * Executes a topic delete transaction.
+     *
+     * @param  request  the request containing the details of the topic delete transaction
+     * @return          the result of the topic delete transaction
+     * @throws HederaException if the transaction could not be executed
+     */
+    @NonNull
+    TopicDeleteResult executeTopicDeleteTransaction(@NonNull TopicDeleteRequest request) throws HederaException;
+
+    /**
+     * Executes a topic message submit transaction.
+     *
+     * @param  request  the request containing the details of the topic message submit transaction
+     * @return          the result of the topic message submit transaction
+     * @throws HederaException if the transaction could not be executed
+     */
+    @NonNull
+    TopicSubmitMessageResult executeTopicMessageSubmitTransaction(@NonNull TopicSubmitMessageRequest request)
+            throws HederaException;
+
+    /**
+     * Adds a transaction listener to the protocol layer client. The listener will be notified when a transaction
+     * is executed.
+     *
+     * @param  listener  the transaction listener to be added
+     * @return          a Runnable object that can be used to remove the listener
+     */
     @NonNull
     Runnable addTransactionListener(@NonNull TransactionListener listener);
 }

hedera-base/src/test/java/com/openelements/hedera/base/test/ProtocolLayerClientTests.java

@@ -1,21 +1,24 @@
 package com.openelements.hedera.base.test;
 
+import com.openelements.hedera.base.protocol.ProtocolLayerClient;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
 import com.hedera.hashgraph.sdk.AccountId;
 import com.hedera.hashgraph.sdk.Client;
 import com.hedera.hashgraph.sdk.PrivateKey;
 import com.openelements.hedera.base.Account;
 import com.openelements.hedera.base.implementation.ProtocolLayerClientImpl;
-import com.openelements.hedera.base.protocol.ProtocolLayerClient;
-import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
 
 public class ProtocolLayerClientTests {
 
     @Test
     void testNullConstructorParam() {
-        //then
+        //given
         final Client client = Client.forTestnet();
         final Account account = new Account(AccountId.fromString("0.0.12345"), PrivateKey.generateED25519().getPublicKey(), PrivateKey.generateED25519());
+
+        //then
         Assertions.assertThrows(NullPointerException.class, () -> new ProtocolLayerClientImpl(client, null));
         Assertions.assertThrows(NullPointerException.class, () -> new ProtocolLayerClientImpl(null, account));
         Assertions.assertThrows(NullPointerException.class, () -> new ProtocolLayerClientImpl(null, null));
@@ -38,5 +41,16 @@ void testNullParams() {
         Assertions.assertThrows(NullPointerException.class, () -> client.executeContractCallTransaction(null));
         Assertions.assertThrows(NullPointerException.class, () -> client.executeFileInfoQuery(null));
         Assertions.assertThrows(NullPointerException.class, () -> client.executeAccountDeleteTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeContractDeleteTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeAccountCreateTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeTokenCreateTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeTokenAssociateTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeTopicCreateTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeTopicDeleteTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeTopicMessageSubmitTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeTokenCreateTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeBurnTokenTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeMintTokenTransaction(null));
+        Assertions.assertThrows(NullPointerException.class, () -> client.executeTransferTransactionForNft(null));
     }
 }

hedera-base/src/test/java/com/openelements/hedera/base/test/ProtocolLayerDataCreationTests.java

@@ -11,7 +11,6 @@
 import com.hedera.hashgraph.sdk.ContractFunctionResult;
 import com.hedera.hashgraph.sdk.TokenId;
 import com.hedera.hashgraph.sdk.TokenType;
-import com.hedera.hashgraph.sdk.TopicId;
 import com.hedera.hashgraph.sdk.proto.ContractFunctionResultOrBuilder;
 import com.openelements.hedera.base.Account;
 import com.openelements.hedera.base.ContractParam;