Merge branch 'main' into add-constructor-tests-TopicDeleteRequest

Author: hendrikebbers

hedera-base/pom.xml

@@ -22,6 +22,12 @@
     <dependency>
       <groupId>com.hedera.hashgraph</groupId>
       <artifactId>sdk</artifactId>
+    </dependency>
+	    <dependency>
+        <groupId>io.github.cdimascio</groupId>
+        <artifactId>dotenv-java</artifactId>
+        <version>2.3.2</version>
+        <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
@@ -47,11 +53,6 @@
       <artifactId>grpc-inprocess</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>io.github.cdimascio</groupId>
-      <artifactId>dotenv-java</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>

hedera-base/src/main/java/com/openelements/hedera/base/implementation/ProtocolLayerClientImpl.java

@@ -310,6 +310,8 @@ public AccountDeleteResult executeAccountDeleteTransaction(@NonNull final Accoun
     public TopicCreateResult executeTopicCreateTransaction(@NonNull final TopicCreateRequest request)
             throws HederaException {
         Objects.requireNonNull(request, "request must not be null");
+        Objects.requireNonNull(request.maxTransactionFee(), "maxTransactionFee must not be null");
+		Objects.requireNonNull(request.transactionValidDuration(), "transactionValidDuration must not be null");
         try {
             final TopicCreateTransaction transaction = new TopicCreateTransaction()
                     .setMaxTransactionFee(request.maxTransactionFee())

hedera-base/src/main/java/com/openelements/hedera/base/protocol/TopicCreateRequest.java

@@ -9,7 +9,12 @@ public record TopicCreateRequest(@NonNull Hbar maxTransactionFee,
                                  @NonNull Duration transactionValidDuration) implements TransactionRequest {
 
     public TopicCreateRequest {
-
+			if (maxTransactionFee == null) {
+				throw new NullPointerException("maxTransactionFee cannot be null");
+			}
+			if (transactionValidDuration == null) {
+				throw new NullPointerException("transactionValidDuration cannot be null");
+			}
     }
 
     public static TopicCreateRequest of() {

hedera-base/src/test/java/com/openelements/hedera/base/test/ProtocolLayerDataCreationTests.java

@@ -12,6 +12,7 @@
 import com.hedera.hashgraph.sdk.proto.ContractFunctionResultOrBuilder;
 import com.hedera.hashgraph.sdk.TokenId;
 import com.hedera.hashgraph.sdk.TokenType;
+import com.hedera.hashgraph.sdk.TopicId;
 import com.openelements.hedera.base.Account;
 import com.openelements.hedera.base.ContractParam;
 import com.openelements.hedera.base.protocol.AccountBalanceRequest;
@@ -28,6 +29,7 @@
 import com.openelements.hedera.base.protocol.ContractDeleteResult;
 import com.openelements.hedera.base.protocol.FileAppendRequest;
 import com.openelements.hedera.base.protocol.TokenTransferResult;
+import com.openelements.hedera.base.protocol.TopicCreateResult;
 import com.openelements.hedera.base.protocol.TokenMintResult;
 import com.openelements.hedera.base.protocol.TokenCreateResult;
 import com.openelements.hedera.base.protocol.TokenBurnResult;
@@ -50,6 +52,7 @@
 import com.openelements.hedera.base.protocol.FileCreateRequest;
 import com.openelements.hedera.base.protocol.TopicSubmitMessageResult;
 import com.openelements.hedera.base.protocol.TopicDeleteRequest;
+import com.openelements.hedera.base.protocol.TopicCreateRequest;
 
 import java.lang.reflect.Constructor;
 import java.nio.charset.StandardCharsets;
@@ -177,6 +180,17 @@ void testAccountDeleteResultCreation() {
         Assertions.assertThrows(NullPointerException.class, () -> new AccountDeleteResult(transactionId, status, null, consensusTimestamp, transactionFee));
     }
 
+	@Test
+	void testTopicCreateRequestCreation() {
+		//given
+		final Hbar validMaxTransactionFee = Hbar.fromTinybars(1000);
+		final Duration validTransactionDuration = Duration.ofSeconds(120);
+
+		Assertions.assertDoesNotThrow(() -> new TopicCreateRequest(validMaxTransactionFee, validTransactionDuration));
+		Assertions.assertThrows(NullPointerException.class, () -> new TopicCreateRequest(null, validTransactionDuration));
+		Assertions.assertThrows(NullPointerException.class, () -> new TopicCreateRequest(validMaxTransactionFee, null));
+	}
+
     @Test
     void testContractCallRequestCreation() {
         //given
@@ -750,4 +764,18 @@ void testTopicDeleteRequestCreation() {
         Assertions.assertThrows(NullPointerException.class, () -> new TopicDeleteRequest(maxTransactionFee, null, null));
         Assertions.assertThrows(NullPointerException.class, () -> new TopicDeleteRequest(null, null, null));
     }
+  
+  @Test
+  void testTopicCreateResultCreation() {
+    	//given
+    	final TransactionId validTransactionId = TransactionId.fromString("[email protected]");
+    	final Status validStatus =Status.SUCCESS;
+    	final TopicId validTopicId = TopicId.fromString("0.0.12345");
+    	
+    	//then
+    	Assertions.assertDoesNotThrow(() -> new TopicCreateResult(validTransactionId,validStatus,validTopicId));
+    	Assertions.assertThrows(NullPointerException.class, () -> new TopicCreateResult(null, validStatus, validTopicId));
+    	Assertions.assertThrows(NullPointerException.class, () -> new TopicCreateResult(validTransactionId, null, validTopicId));
+    	Assertions.assertThrows(NullPointerException.class, () -> new TopicCreateResult(validTransactionId, validStatus, null));
+    }
 }