Skip to content

enhance route checks for moment items #1563

@huss

Description

@huss

Is your feature request related to a problem? Please describe.

PR #1528 added checks for time and duration in a route. See src/server/routes/compareReadings.js with if (!isValidIsoDateTime(currStartRaw) || !isValidIsoDateTime(currEndRaw) || !isValidIsoDuration(shiftRaw)) {. This seems valuable and it should be considered for all other routes. If any other tests seem valuable then they can also be proposed.

Describe the solution you'd like

Roll in these new tests as desirable.

Describe alternatives you've considered

The routes will not have this checking.

Additional context

@omarraf did the original test and may also continue with this work. Anyone else interested in working on this should first check if @omarraf is working on this. Obsolete given comment below so this is available for anyone.

Metadata

Metadata

Assignees

No one assigned

    Labels

    i-good-first-issueThis issue is probably a good starting point for people new to coding or the OED project.p-medium-priorityt-enhancementThis issues tracks a potential improvement to the software

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions