fix(tLN): Make supervision removal only remove Val textContent (closes #129)

Author: danyill

tDataSet/removeDataSet.spec.ts

@@ -18,15 +18,15 @@ describe("Utility function to remove DataSet element", () => {
       'ExtRef[srcCBName="someGse"], ExtRef[srcCBName="someGse2"], ExtRef[srcCBName="someGse3"]',
     ),
   );
-  const doi = extRefs[0].ownerDocument.querySelector(
-    'LN[lnClass="LGOS"][inst="1"] > DOI',
+  const val = extRefs[0].ownerDocument.querySelector(
+    'LN[lnClass="LGOS"][inst="1"] > DOI[name="GoCBRef"] > DAI[name="setSrcRef"] > Val',
   )!;
-  const ln = extRefs[0].ownerDocument.querySelector(
-    'LN[lnClass="LGOS"][inst="2"]',
+  const val2 = extRefs[0].ownerDocument.querySelector(
+    'LN[lnClass="LGOS"][inst="2"] > DOI[name="GoCBRef"] > DAI[name="setSrcRef"] > Val',
   );
 
   it("returns empty string when remove.node is not DataSet", () =>
-    expect(removeDataSet({ node: doi })).to.be.empty);
+    expect(removeDataSet({ node: val })).to.be.empty);
 
   it("removes DataSet also removes/updates dependant data", () =>
     expect(edits.length).to.equal(10));
@@ -42,8 +42,8 @@ describe("Utility function to remove DataSet element", () => {
   });
 
   it("including the subscriber supervision", () => {
-    expect((edits[5] as Remove).node).to.equal(doi);
-    expect((edits[6] as Remove).node).to.equal(ln);
+    expect((edits[5] as Remove).node).to.equal(val!.firstChild);
+    expect((edits[6] as Remove).node).to.equal(val2!.firstChild);
   });
 
   it("including control Block updates", () => {

tExtRef/unsubscribe.spec.ts

@@ -92,13 +92,12 @@ describe("Function allowing to unsubscribe multiple external references", () =>
       'ExtRef[srcCBName="someGse"], ExtRef[srcCBName="someGse2"]',
     );
     const edits = unsubscribe(extRefs);
-    const doi = extRefs[0].ownerDocument.querySelector(
-      'LN[lnClass="LGOS"][inst="1"] > DOI',
+    const val = extRefs[0].ownerDocument.querySelector(
+      'LN[lnClass="LGOS"][inst="1"] > DOI[name="GoCBRef"] > DAI[name="setSrcRef"] > Val',
     );
-    const ln = extRefs[0].ownerDocument.querySelector(
-      'LN[lnClass="LGOS"][inst="2"]',
+    const val2 = extRefs[0].ownerDocument.querySelector(
+      'LN[lnClass="LGOS"][inst="2"] > DOI[name="GoCBRef"] > DAI[name="setSrcRef"] > Val',
     );
-
     expect(edits.length).to.equal(5);
     expect(edits[0]).to.satisfies(isRemove);
     expect((edits[0] as Remove).node).to.equal(extRefs[0]);
@@ -107,9 +106,9 @@ describe("Function allowing to unsubscribe multiple external references", () =>
     expect(edits[2]).to.satisfies(isUpdate);
     expect((edits[2] as Update).element).to.equal(extRefs[2]);
     expect(edits[3]).to.satisfies(isRemove);
-    expect((edits[3] as Remove).node).to.equal(doi);
+    expect((edits[3] as Remove).node).to.equal(val!.firstChild);
     expect(edits[4]).to.satisfies(isRemove);
-    expect((edits[4] as Remove).node).to.equal(ln);
+    expect((edits[4] as Remove).node).to.equal(val2!.firstChild);
   });
 
   it("with ignoreSupervision do not remove subscription LGOS supervision", () => {
@@ -157,8 +156,8 @@ describe("Function allowing to unsubscribe multiple external references", () =>
       withSubscriptionSupervision,
       'ExtRef[srcCBName="someSmv"]',
     );
-    const doi = extRefs[0].ownerDocument.querySelector(
-      'LN[lnClass="LSVS"][inst="1"] > DOI',
+    const val = extRefs[0].ownerDocument.querySelector(
+      'LN[lnClass="LSVS"][inst="1"] > DOI[name="SvCBRef"] > DAI[name="setSrcRef"] > Val',
     );
     const edits = unsubscribe(extRefs);
 
@@ -170,7 +169,7 @@ describe("Function allowing to unsubscribe multiple external references", () =>
     expect(edits[2]).to.satisfies(isRemove);
     expect((edits[2] as Remove).node).to.equal(extRefs[1].parentElement);
     expect(edits[3]).to.satisfies(isRemove);
-    expect((edits[3] as Remove).node).to.equal(doi);
+    expect((edits[3] as Remove).node).to.equal(val?.firstChild);
   });
 
   it("with ignoreSupervision do not remove subscription LGOS supervision", () => {

tLN/removeSubscriptionSupervision.ts

@@ -10,7 +10,7 @@ type GroupedExtRefs = {
   subscriberIed: Element;
 };
 
-/** @returns Element to remove the subscription supervision */
+/** @returns Element to remove the subscription supervision control block reference */
 function removableSupervisionElement(
   ctrlBlock: Element,
   subscriberIed: Element,
@@ -24,15 +24,11 @@ function removableSupervisionElement(
   ).find((val) => val.textContent === controlBlockObjRef(ctrlBlock));
   if (!valElement) return null;
 
-  const ln = valElement.closest("LN")!;
-  const doi = valElement.closest("DOI")!;
+  const textContentNode = Array.from(valElement.childNodes).find(
+    (child) => child.nodeType === Node.TEXT_NODE,
+  ) as Element;
 
-  // do not remove logical nodes `LGOS`, `LSVS` unless privately tagged
-  const canRemoveLn = ln.querySelector(
-    ':scope > Private[type="OpenSCD.create"]',
-  );
-
-  return canRemoveLn ? ln : doi;
+  return textContentNode ?? null;
 }
 
 /** @returns Whether `DA` with name `setSrcRef` can edited by SCL editor */
@@ -44,7 +40,9 @@ function isSupervisionEditable(
     ctrlBlock,
     subscriberIed,
   );
-  const supervisionLn = supervisionElement?.closest("LN") ?? null;
+  if (!supervisionElement) return false;
+
+  const supervisionLn = supervisionElement.parentElement?.closest("LN") ?? null;
   if (!supervisionLn) return false;
 
   return isSrcRefEditable(supervisionLn);