Skip to content

Commit 9cbc3fc

Browse files
feat(tDataTypeTemplate): allwo set desc on LNodeType insert
1 parent c589ac1 commit 9cbc3fc

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

tDataTypeTemplates/insertSelecetdLNodeType.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,16 @@ const incompleteAtcc = findElement(incompleteAtccTypes) as XMLDocument;
2525
const missingDataTypes = findElement(emptySSD) as XMLDocument;
2626

2727
describe("insertLNodeTypeSelection", () => {
28-
it('is insensitive for invalid EnumTypes',()=> {
28+
it('is insensitive for invalid EnumTypes', () => {
2929
const data = nsdToJson("LLN0") as LNodeDescription;
30-
insertSelectedLNodeType(incompleteMmxu, invalidSelection, {class:"LLN0", data});
30+
insertSelectedLNodeType(incompleteMmxu, invalidSelection, { class: "LLN0", data });
3131
})
3232

3333
it("insert MMXU LNodeType including missing sub data", () => {
3434
const edits = insertSelectedLNodeType(
3535
incompleteMmxu,
3636
mmxuSelection,
37-
{class:"MMXU"},
37+
{ class: "MMXU" },
3838
);
3939

4040
expect(edits.length).to.equal(6);
@@ -82,7 +82,7 @@ describe("insertLNodeTypeSelection", () => {
8282
const edits = insertSelectedLNodeType(
8383
imcompleteLtrk,
8484
ltrkSelection,
85-
{class:"LTRK", data},
85+
{ class: "LTRK", data },
8686
);
8787

8888
expect(edits.length).to.equal(7);
@@ -138,7 +138,7 @@ describe("insertLNodeTypeSelection", () => {
138138
const edits = insertSelectedLNodeType(
139139
incompleteAtcc,
140140
atccSelection,
141-
{class: "ATCC", data},
141+
{ class: "ATCC", data },
142142
);
143143

144144
expect(edits.length).to.equal(5);
@@ -181,7 +181,7 @@ describe("insertLNodeTypeSelection", () => {
181181
const edits = insertSelectedLNodeType(
182182
missingDataTypes,
183183
atccSelection,
184-
{class:"ATCC", data},
184+
{ class: "ATCC", desc: 'SomeDesc', data },
185185
);
186186

187187
expect(edits.length).to.equal(19);

tDataTypeTemplates/insertSelectedLNodeType.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ function data(lnData: any, path: string[]): any {
169169
export function insertSelectedLNodeType(
170170
doc: XMLDocument,
171171
selection: TreeSelection,
172-
logicalnode: {class: string, data?: LNodeDescription},
172+
logicalnode: { class: string, desc?: string, data?: LNodeDescription },
173173
): Insert[] {
174174
const types = new Set<string>();
175175
const elements: Templates = {
@@ -181,6 +181,7 @@ export function insertSelectedLNodeType(
181181

182182
const lnData = logicalnode.data ?? nsdToJson(logicalnode.class);
183183
const lnClass = logicalnode.class;
184+
const desc = logicalnode.desc ?? null
184185

185186
function isUnknownId(id: string): boolean {
186187
const alreadyCreate = types.has(id);
@@ -206,17 +207,17 @@ export function insertSelectedLNodeType(
206207
return id;
207208
}
208209

209-
const lnType = createElement(doc, "LNodeType", { lnClass });
210+
const lnType = createElement(doc, "LNodeType", { lnClass, desc });
210211

211212
function createEnumType(path: string[], sel: TreeSelection): string {
212213
const enumData = data(lnData, path).children;
213214

214215
const vals: Element[] = [];
215216

216217
for (const content of Object.keys(sel)) {
217-
const enumVal = enumData[content];
218-
if(!enumVal) continue; // check for invalid selection
219-
218+
const enumVal = enumData[content];
219+
if (!enumVal) continue; // check for invalid selection
220+
220221
const ord = enumVal.literalVal;
221222
const val = createElement(doc, "EnumVal", { ord });
222223
val.textContent = content;

0 commit comments

Comments
 (0)