Skip to content

tExtRef: isSubscribed looks inside Private elements #90

@danyill

Description

@danyill

I was idly looking at this:

return Array.from(scope.querySelectorAll("ExtRef")).some((extRef) => {
if (extRef.hasAttribute("serviceType"))
return (
matchDataAttributes(extRef, fcda) && someControlMatch(extRef, controls)
);
return matchDataAttributes(extRef, fcda);
});

I think we should as part the of the some statement call isPublic to avoid potential Private element matches.

When time allows I shall remediate and add a regression test.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions