Merge pull request #2856 from OpenFAST/rc-4.0.5

Release 4.0.5

Author: andrew-platt

.github/workflows/automated-dev-tests.yml

@@ -0,0 +1,116 @@
+**Feature or improvement description**
+Pull request to merge `rc-4.0.5` into `main` and create a tagged release for v4.0.5
+
+See the milestone and project pages for additional information
+
+    https://github.com/OpenFAST/openfast/milestone/22
+
+Test results, if applicable
+See GitHub Actions
+
+### Release checklist:
+- [ ] Update the documentation version in docs/conf.py
+- [ ] Update the versions in docs/source/user/api\_change.rst
+- [ ] Update version info in openfast\_io/pyproject.toml
+- [ ] Verify readthedocs builds correctly
+- [ ] Create an annotated tag in OpenFAST during merge (mark as most recent if necessary)
+- [ ] Create a merge commit in r-test and add a corresponding annotated tag
+- [ ] Upload Docker image
+- [ ] Compile executables for Windows builds
+    - [ ] `AeroDisk_Driver_x64.exe`
+    - [ ] `AeroDyn_Driver_x64.exe`
+    - [ ] `AeroDyn_Driver_x64_OpenMP.exe`
+    - [ ] `AeroDyn_Inflow_c_binding_x64.dll`
+    - [ ] `AeroDyn_Inflow_c_binding_x64_OpenMP.dll`
+    - [ ] `BeamDyn_Driver_x64.exe`
+    - [ ] `DISCON.dll (x64)`
+    - [ ] `DISCON_ITIBarge.dll (x64)`
+    - [ ] `DISCON_OC3Hywind.dll (x64)`
+    - [ ] `DISCON_SC.dll (x64)`
+    - [ ] `FAST.Farm_x64.exe`
+    - [ ] `FAST.Farm_x64_OMP.exe`
+    - [ ] `FAST_SFunc.mexw64`
+    - [ ] `HydroDynDriver_x64.exe`
+    - [ ] `HydroDyn_C_Binding_x64.dll`
+    - [ ] `IinflowWind_c_binding_x64.dll`
+    - [ ] `InflowWind_Driver_x64.exe`
+    - [ ] `InflowWind_Driver_x64_OpenMP.exe`
+    - [ ] `MoorDyn_Driver_x64.exe`
+    - [ ] `MoorDyn_c_binding_x64.dll`
+    - [ ] `OpenFAST-Simulink_x64.dll`
+    - [ ] `openfast_x64.exe`
+    - [ ] `SeaStateDriver_x64.exe`
+    - [ ] `SimpleElastoDyn_x64.exe`
+    - [ ] `SubDyn_x64.exe`
+    - [ ] `Turbsim_x64.exe`
+    - [ ] `UnsteadyAero_x64.exe`
+
+# Changelog
+
+## Overview
+
+This release includes several bug fixes and improvements for _OpenFAST_, GitHub actions, and _openfast\_io_.
+
+## General
+
+### CMake build system
+
+### GitHub actions
+
+#2825 Simplify GitHub Action for regression tests (backport from dev-tc) (@deslaughter)
+
+
+### openfast_io
+
+#2828 updated outlist reading in openfast\_io (@mayankchetan)
+
+#2818 OpenFAST IO updates: MoorDyn and StC (@dzalkind)
+
+
+
+## Solvers
+
+### OpenFAST
+
+#2831 [BugFix] WrVTK with VTK\_fps fails (@andrew-platt)
+
+
+## Interfaces
+
+### cpp interface
+
+#2792 Fix openfastcpp restart parsing of file name (@marchdf)
+
+#2804 Add a checkError in openfast cpp (@marchdf)
+
+#2815 Fix restart parsing of file name (backport of #2792 and #2793) (@marchdf)
+
+
+## Module changes
+
+### AeroDyn
+
+#2853 Backport #2848 (@bjonkman)
+
+
+### BeamDyn
+
+#2811 BD: new output - aero only loads mapped to the root (@andrew-platt)
+
+
+### IceFlow
+
+#2855 Fix Typo in "interpolation" in Ice Crushing Modules (@leopardracer)
+
+
+### SubDyn
+
+#2821 bugfix: SD maximum number of output channels was incorrectly set (@andrew-platt)
+
+
+## Input file changes
+
+No input file changes since v4.0.0
+
+#2829 FF: typo in SeaState names in `MD_Shared` .fst files - this is not an API change (@andrew-platt)
+

docs/OtherSupporting/OutListParameters.xlsx

@@ -138,7 +138,7 @@ def runDoxygen(sourcfile, doxyfileIn, doxyfileOut):
 # The short X.Y version.
 version = u'4.0'
 # The full version, including alpha/beta/rc tags.
-release = u'v4.0.4'
+release = u'v4.0.5'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

docs/changelogs/v4.0.5.md

@@ -10,6 +10,12 @@ The line number corresponds to the resulting line number after all changes are i
 Thus, be sure to implement each in order so that subsequent line numbers are correct.
 
 
+OpenFAST v4.0.4 to OpenFAST v4.0.5
+----------------------------------
+
+No input file changes were made.
+
+
 OpenFAST v4.0.3 to OpenFAST v4.0.4
 ----------------------------------
 

docs/conf.py

@@ -94,8 +94,15 @@ void fast::OpenFAST::findRestartFile(int iTurbLoc) {
     check_nc_error(ierr, "nc_get_vara_double - getting latest time");
     tStart = latest_time;
 
-    char tmpOutFileRoot[INTERFACE_STRING_LENGTH];
+    char *tmpOutFileRoot;
+    size_t len;
+    ierr = nc_inq_attlen(ncid, NC_GLOBAL, "out_file_root", &len);
+    check_nc_error(ierr, "nc_inq_attlen - getting out_file_root length");
+
+    tmpOutFileRoot = (char*) malloc(len + 1);
     ierr = nc_get_att_text(ncid, NC_GLOBAL, "out_file_root", tmpOutFileRoot);
+    check_nc_error(ierr, "nc_get_att_text - getting out_file_root");
+    tmpOutFileRoot[len] = '\0';
     turbineData[iTurbLoc].outFileRoot.assign(tmpOutFileRoot);
 
     ierr = nc_get_att_double(ncid, NC_GLOBAL, "dt_fast", &dtFAST);
@@ -119,7 +126,7 @@ void fast::OpenFAST::findRestartFile(int iTurbLoc) {
     std::cout << "Restarting from time " << latest_time << " at time step " << tstep << " from file name " << turbineData[iTurbLoc].FASTRestartFileName << std::endl ;
 
     nc_close(ncid);
-
+    free(tmpOutFileRoot);
 }
 
 void fast::OpenFAST::prepareRestartFile(int iTurbLoc) {
@@ -668,6 +675,7 @@ void fast::OpenFAST::init() {
                         &sc->op_to_FAST[iTurb],
                         &ErrStat,
                         ErrMsg);
+                    checkError(ErrStat, ErrMsg);
                     turbineData[iTurb].inflowType = 0;
                 }
 

docs/source/user/api_change.rst

@@ -1601,7 +1601,7 @@ subroutine UA_Init_Wrapper(AFInfo, InitInp, interval, p, x, xd, OtherState, m, E
          do i = 1,InitInp%numBladeNodes
             InitInp%UA_Init%c(i,1)      = p%W(iW)%chord_LL(i) ! NOTE: InitInp chord move-allocd to p
          end do
-         InitInp%UA_Init%OutRootName     = trim(InitInp%RootName)//'W'//num2lstr(iW)//'.UA'
+         InitInp%UA_Init%OutRootName     = trim(InitInp%RootName)//'W'//trim(num2lstr(iW))//'.UA'
 
          InitInp%UA_Init%ShedEffect      = .False. ! Important, when coupling UA wih vortex code, shed vorticity is inherently accounted for
          InitInp%UA_Init%UAOff_innerNode(1) = InitInp%W(iW)%UAOff_innerNode

glue-codes/openfast-cpp/src/OpenFAST.cpp

@@ -1746,6 +1746,27 @@ subroutine Init_MiscVars( p, u, y, m, ErrStat, ErrMsg )
    CALL BD_CopyInput(u, m%u2, MESH_NEWCOPY, ErrStat2, ErrMsg2)
       CALL SetErrStat( ErrStat2, ErrMsg2, ErrStat, ErrMsg, RoutineName )
 
+   ! compute mapping of applied distributed loads to the root location
+   ! NOTE: PtLoads are not handled at present. See comments in BeamDyn_IO.f90 for changes required.
+   if (p%CompAppliedLdAtRoot .and. p%BldMotionNodeLoc == BD_MESH_QP) then
+      ! create point mesh at root (cousin of rootmotion) 
+      CALL MeshCopy( SrcMesh   = u%RootMotion     &
+                    , DestMesh = m%LoadsAtRoot    &
+                    , CtrlCode = MESH_COUSIN      &
+                    , IOS      = COMPONENT_OUTPUT &
+                    , Force    = .TRUE.           &
+                    , Moment   = .TRUE.           &
+                    , ErrStat  = ErrStat2         &
+                    , ErrMess  = ErrMsg2          )
+         CALL SetErrStat( ErrStat2, ErrMsg2, ErrStat, ErrMsg, RoutineName )
+         if (ErrStat>=AbortErrLev) RETURN
+
+      ! mapping of distributed loads to LoadsAtRoot
+      CALL MeshMapCreate( u%DistrLoad, m%LoadsAtRoot, m%Map_u_DistrLoad_to_R, ErrStat2, ErrMsg2 )
+         CALL SetErrStat( ErrStat2, ErrMsg2, ErrStat, ErrMsg, RoutineName )
+      m%LoadsAtRoot%remapFlag = .false.
+
+   endif
 
 end subroutine Init_MiscVars
 !-----------------------------------------------------------------------------------------------------------------------------------