Skip to content

Commit 5467524

Browse files
authored
Merge pull request #28 from SimY4/master
Fix compatibility with 10.7.0
2 parents eb77215 + 878e0bf commit 5467524

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<parent>
2121
<groupId>io.github.openfeign</groupId>
2222
<artifactId>parent</artifactId>
23-
<version>10.2.0</version>
23+
<version>10.7.0</version>
2424
</parent>
2525

2626
<artifactId>feign-annotation-error-decoder</artifactId>

src/main/java/feign/error/ExceptionGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ class ExceptionGenerator {
4141
.status(500)
4242
.body((Response.Body) null)
4343
.headers(testHeaders)
44-
.request(Request.create(Request.HttpMethod.GET, "http://test", testHeaders, null))
44+
.request(Request.create(Request.HttpMethod.GET, "http://test", testHeaders,
45+
Request.Body.empty(), null))
4546
.build();
4647
}
4748

src/test/java/feign/error/AbstractAnnotationErrorDecoderTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import feign.Request;
1717
import feign.Response;
18-
import java.nio.charset.Charset;
18+
import java.nio.charset.StandardCharsets;
1919
import java.util.Collection;
2020
import java.util.HashMap;
2121
import java.util.Map;
@@ -42,9 +42,10 @@ Response testResponse(int status, String body) {
4242
Response testResponse(int status, String body, Map<String, Collection<String>> headers) {
4343
return Response.builder()
4444
.status(status)
45-
.body(body, Charset.forName("UTF-8"))
45+
.body(body, StandardCharsets.UTF_8)
4646
.headers(headers)
47-
.request(Request.create(Request.HttpMethod.GET, "http://test", headers, null))
47+
.request(Request.create(Request.HttpMethod.GET, "http://test", headers,
48+
Request.Body.empty(), null))
4849
.build();
4950
}
5051
}

src/test/java/feign/error/AnnotationErrorDecoderExceptionConstructorsTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,14 @@
1313
*/
1414
package feign.error;
1515

16+
import feign.Request;
1617
import feign.codec.Decoder;
1718
import feign.optionals.OptionalDecoder;
1819
import org.junit.Test;
19-
import org.junit.runner.Request;
2020
import org.junit.runner.RunWith;
2121
import org.junit.runners.Parameterized;
2222
import org.junit.runners.Parameterized.Parameters;
2323
import org.junit.runners.Parameterized.Parameter;
24-
import javax.swing.text.html.Option;
2524
import java.util.*;
2625
import static org.assertj.core.api.Assertions.assertThat;
2726
import static feign.error.AnnotationErrorDecoderExceptionConstructorsTest.TestClientInterfaceWithDifferentExceptionConstructors;
@@ -36,7 +35,7 @@ public class AnnotationErrorDecoderExceptionConstructorsTest extends
3635
private static final Object NULL_BODY = null;
3736
private static final String NON_NULL_BODY = "A GIVEN BODY";
3837
private static final feign.Request REQUEST = feign.Request.create(feign.Request.HttpMethod.GET,
39-
"http://test", Collections.emptyMap(), null);
38+
"http://test", Collections.emptyMap(), Request.Body.empty(), null);
4039
private static final feign.Request NO_REQUEST = null;
4140
private static final Map<String, Collection<String>> NON_NULL_HEADERS =
4241
new HashMap<String, Collection<String>>();

0 commit comments

Comments
 (0)