Skip to content

Commit ab644ee

Browse files
velovelo
authored
refactor: extract all hardcoded versions to parent POM properties (#3088)
* refactor: extract all hardcoded versions to properties Signed-off-by: Marvin Froeder <[email protected]> * refactor: extract all dependency and plugin versions to parent POM properties Signed-off-by: Marvin Froeder <[email protected]> --------- Signed-off-by: Marvin Froeder <[email protected]>
1 parent d291ead commit ab644ee

File tree

24 files changed

+122
-73
lines changed

24 files changed

+122
-73
lines changed

‎apt-test-generator/pom.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<dependency>
4040
<groupId>com.github.jknack</groupId>
4141
<artifactId>handlebars</artifactId>
42-
<version>4.5.0</version>
42+
<version>${handlebars.version}</version>
4343
</dependency>
4444

4545
<dependency>
@@ -51,7 +51,7 @@
5151
<dependency>
5252
<groupId>com.google.testing.compile</groupId>
5353
<artifactId>compile-testing</artifactId>
54-
<version>0.23.0</version>
54+
<version>${compile-testing.version}</version>
5555
<scope>test</scope>
5656
<exclusions>
5757
<exclusion>
@@ -75,7 +75,7 @@
7575
<dependency>
7676
<groupId>com.google.auto.service</groupId>
7777
<artifactId>auto-service-annotations</artifactId>
78-
<version>1.1.1</version>
78+
<version>${auto-service-annotations.version}</version>
7979
<scope>provided</scope>
8080
</dependency>
8181
</dependencies>
@@ -104,7 +104,7 @@
104104
<plugin>
105105
<groupId>org.apache.maven.plugins</groupId>
106106
<artifactId>maven-shade-plugin</artifactId>
107-
<version>3.6.1</version>
107+
<version>${maven-shade-plugin.version}</version>
108108
<executions>
109109
<execution>
110110
<goals>
@@ -125,7 +125,7 @@
125125
<plugin>
126126
<groupId>org.skife.maven</groupId>
127127
<artifactId>really-executable-jar-maven-plugin</artifactId>
128-
<version>2.1.1</version>
128+
<version>${really-executable-jar-maven-plugin.version}</version>
129129
<configuration>
130130
<programFile>github</programFile>
131131
</configuration>

‎benchmark/pom.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@
137137
<plugin>
138138
<groupId>org.apache.maven.plugins</groupId>
139139
<artifactId>maven-shade-plugin</artifactId>
140-
<version>3.6.1</version>
140+
<version>${maven-shade-plugin.version}</version>
141141
<executions>
142142
<execution>
143143
<goals>
@@ -158,7 +158,7 @@
158158
<plugin>
159159
<groupId>org.skife.maven</groupId>
160160
<artifactId>really-executable-jar-maven-plugin</artifactId>
161-
<version>2.1.1</version>
161+
<version>${really-executable-jar-maven-plugin.version}</version>
162162
<configuration>
163163
<programFile>benchmark</programFile>
164164
</configuration>

‎core/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
<dependency>
5151
<groupId>org.springframework</groupId>
5252
<artifactId>spring-context</artifactId>
53-
<version>6.2.12</version>
53+
<version>${spring-context.version}</version>
5454
<scope>test</scope>
5555
</dependency>
5656

‎dropwizard-metrics4/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<dependency>
4141
<groupId>io.dropwizard.metrics</groupId>
4242
<artifactId>metrics-core</artifactId>
43-
<version>4.2.37</version>
43+
<version>${metrics-core-4.version}</version>
4444
</dependency>
4545
<dependency>
4646
<groupId>${project.groupId}</groupId>

‎dropwizard-metrics5/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<dependency>
4545
<groupId>io.dropwizard.metrics5</groupId>
4646
<artifactId>metrics-core</artifactId>
47-
<version>5.0.5</version>
47+
<version>${metrics-core-5.version}</version>
4848
</dependency>
4949
<dependency>
5050
<groupId>${project.groupId}</groupId>

‎example-github-with-coroutine/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<dependency>
4646
<groupId>org.apache.commons</groupId>
4747
<artifactId>commons-exec</artifactId>
48-
<version>1.5.0</version>
48+
<version>${commons-exec.version}</version>
4949
<scope>test</scope>
5050
</dependency>
5151
</dependencies>
@@ -56,7 +56,7 @@
5656
<plugin>
5757
<groupId>org.apache.maven.plugins</groupId>
5858
<artifactId>maven-shade-plugin</artifactId>
59-
<version>3.6.1</version>
59+
<version>${maven-shade-plugin.version}</version>
6060
<executions>
6161
<execution>
6262
<goals>
@@ -77,7 +77,7 @@
7777
<plugin>
7878
<groupId>org.skife.maven</groupId>
7979
<artifactId>really-executable-jar-maven-plugin</artifactId>
80-
<version>2.1.1</version>
80+
<version>${really-executable-jar-maven-plugin.version}</version>
8181
<configuration>
8282
<programFile>github</programFile>
8383
</configuration>

‎example-github/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<dependency>
4242
<groupId>org.apache.commons</groupId>
4343
<artifactId>commons-exec</artifactId>
44-
<version>1.5.0</version>
44+
<version>${commons-exec.version}</version>
4545
<scope>test</scope>
4646
</dependency>
4747
</dependencies>
@@ -52,7 +52,7 @@
5252
<plugin>
5353
<groupId>org.apache.maven.plugins</groupId>
5454
<artifactId>maven-shade-plugin</artifactId>
55-
<version>3.6.1</version>
55+
<version>${maven-shade-plugin.version}</version>
5656
<executions>
5757
<execution>
5858
<goals>
@@ -73,7 +73,7 @@
7373
<plugin>
7474
<groupId>org.skife.maven</groupId>
7575
<artifactId>really-executable-jar-maven-plugin</artifactId>
76-
<version>2.1.1</version>
76+
<version>${really-executable-jar-maven-plugin.version}</version>
7777
<configuration>
7878
<programFile>github</programFile>
7979
</configuration>

‎example-wikipedia-with-springboot/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<dependency>
4040
<groupId>org.springframework.cloud</groupId>
4141
<artifactId>spring-cloud-dependencies</artifactId>
42-
<version>2025.0.0</version>
42+
<version>${spring-cloud-dependencies.version}</version>
4343
<type>pom</type>
4444
<scope>import</scope>
4545
</dependency>
@@ -66,7 +66,7 @@
6666
<dependency>
6767
<groupId>org.apache.commons</groupId>
6868
<artifactId>commons-exec</artifactId>
69-
<version>1.5.0</version>
69+
<version>${commons-exec.version}</version>
7070
<scope>test</scope>
7171
</dependency>
7272
</dependencies>
@@ -100,7 +100,7 @@
100100
<plugin>
101101
<groupId>org.skife.maven</groupId>
102102
<artifactId>really-executable-jar-maven-plugin</artifactId>
103-
<version>2.1.1</version>
103+
<version>${really-executable-jar-maven-plugin.version}</version>
104104
<configuration>
105105
<programFile>wikipedia</programFile>
106106
</configuration>

‎example-wikipedia/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
<dependency>
4343
<groupId>org.apache.commons</groupId>
4444
<artifactId>commons-exec</artifactId>
45-
<version>1.5.0</version>
45+
<version>${commons-exec.version}</version>
4646
<scope>test</scope>
4747
</dependency>
4848
</dependencies>
@@ -53,7 +53,7 @@
5353
<plugin>
5454
<groupId>org.apache.maven.plugins</groupId>
5555
<artifactId>maven-shade-plugin</artifactId>
56-
<version>3.6.1</version>
56+
<version>${maven-shade-plugin.version}</version>
5757
<executions>
5858
<execution>
5959
<goals>
@@ -74,7 +74,7 @@
7474
<plugin>
7575
<groupId>org.skife.maven</groupId>
7676
<artifactId>really-executable-jar-maven-plugin</artifactId>
77-
<version>2.1.1</version>
77+
<version>${really-executable-jar-maven-plugin.version}</version>
7878
<configuration>
7979
<programFile>wikipedia</programFile>
8080
</configuration>

‎form-spring/pom.xml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@
3939
<dependency>
4040
<groupId>org.apache.commons</groupId>
4141
<artifactId>commons-text</artifactId>
42-
<version>1.14.0</version>
42+
<version>${commons-text.version}</version>
4343
</dependency>
4444
<dependency>
4545
<groupId>org.projectlombok</groupId>
4646
<artifactId>lombok</artifactId>
47-
<version>1.18.42</version>
47+
<version>${lombok.version}</version>
4848
<scope>provided</scope>
4949
</dependency>
5050

@@ -58,14 +58,14 @@
5858
<dependency>
5959
<groupId>org.springframework</groupId>
6060
<artifactId>spring-web</artifactId>
61-
<version>6.2.11</version>
61+
<version>${spring-web.version}</version>
6262
<scope>compile</scope>
6363
</dependency>
6464

6565
<dependency>
6666
<groupId>commons-fileupload</groupId>
6767
<artifactId>commons-fileupload</artifactId>
68-
<version>1.6.0</version>
68+
<version>${commons-fileupload.version}</version>
6969
<scope>compile</scope>
7070
</dependency>
7171

@@ -78,7 +78,7 @@
7878
<dependency>
7979
<groupId>org.springframework.cloud</groupId>
8080
<artifactId>spring-cloud-starter-openfeign</artifactId>
81-
<version>4.3.0</version>
81+
<version>${spring-cloud-starter-openfeign.version}</version>
8282
<scope>test</scope>
8383
<exclusions>
8484
<exclusion>
@@ -125,13 +125,13 @@
125125
<dependency>
126126
<groupId>org.mockito</groupId>
127127
<artifactId>mockito-core</artifactId>
128-
<version>5.20.0</version>
128+
<version>${mockito.version}</version>
129129
<scope>test</scope>
130130
</dependency>
131131
<dependency>
132132
<groupId>org.mockito</groupId>
133133
<artifactId>mockito-junit-jupiter</artifactId>
134-
<version>5.20.0</version>
134+
<version>${mockito.version}</version>
135135
<scope>test</scope>
136136
</dependency>
137137
</dependencies>

0 commit comments

Comments
 (0)