feat: more added tests regarding on replacing WeakHashMap caches with thread-safe maps

Author: renechoi

querydsl-libraries/querydsl-core/src/test/java/com/querydsl/core/alias/AliasFactoryCachingTest.java

@@ -0,0 +1,33 @@
+package com.querydsl.core.alias;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.querydsl.core.types.Expression;
+import com.querydsl.core.types.dsl.Expressions;
+import org.junit.Test;
+
+/** Functional-caching behaviour (non-concurrent) for AliasFactory. */
+public class AliasFactoryCachingTest {
+
+  private final AliasFactory factory =
+      new AliasFactory(new DefaultPathFactory(), new DefaultTypeSystem());
+
+  @Test
+  public void sameExpression_returnsSameAliasInstance() {
+    Expression<Object> expr = Expressions.path(Object.class, "obj");
+    Object first  = factory.createAliasForExpr(Object.class, expr);
+    Object second = factory.createAliasForExpr(Object.class, expr);
+
+    assertThat(first).isSameAs(second);
+  }
+
+  @Test
+  public void differentExpressions_returnDifferentAliasInstances() {
+    Object first =
+        factory.createAliasForExpr(Object.class, Expressions.path(Object.class, "obj1"));
+    Object second =
+        factory.createAliasForExpr(Object.class, Expressions.path(Object.class, "obj2"));
+
+    assertThat(first).isNotSameAs(second);
+  }
+}

querydsl-libraries/querydsl-core/src/test/java/com/querydsl/core/types/TemplateFactoryCacheTest.java

@@ -0,0 +1,27 @@
+package com.querydsl.core.types;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.Test;
+
+/** Verifies that TemplateFactory re-uses parsed Template objects. */
+public class TemplateFactoryCacheTest {
+
+  private final TemplateFactory factory = new TemplateFactory('\\');
+
+  @Test
+  public void identicalTemplateString_isReturnedFromCache() {
+    Template t1 = factory.create("{0}");
+    Template t2 = factory.create("{0}");
+
+    assertThat(t1).isSameAs(t2);
+  }
+
+  @Test
+  public void distinctTemplateStrings_areDifferentInstances() {
+    Template hello = factory.create("{0}");
+    Template world = factory.create("{1}");
+
+    assertThat(hello).isNotSameAs(world);
+  }
+}

querydsl-libraries/querydsl-core/src/test/java/com/querydsl/core/types/dsl/ListPathCachingTest.java

@@ -0,0 +1,28 @@
+package com.querydsl.core.types.dsl;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.querydsl.core.domain.QCat;
+import org.junit.Test;
+
+/** Ensures ListPath index caching works as intended. */
+public class ListPathCachingTest {
+
+  private static final QCat CAT = QCat.cat;
+
+  @Test
+  public void sameIndex_returnsSamePathInstance() {
+    QCat first  = CAT.kittens(0);
+    QCat second = CAT.kittens(0);
+
+    assertThat(first).isSameAs(second);
+  }
+
+  @Test
+  public void differentIndices_returnDistinctPathInstances() {
+    QCat zero = CAT.kittens(0);
+    QCat one  = CAT.kittens(1);
+
+    assertThat(zero).isNotSameAs(one);
+  }
+}

querydsl-tooling/querydsl-codegen-utils/src/test/java/com/querydsl/codegen/utils/MemFileSystemRegistryFunctionalityTest.java

@@ -0,0 +1,35 @@
+package com.querydsl.codegen.utils;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.net.URL;
+import javax.tools.JavaFileManager;
+import javax.tools.ToolProvider;
+import org.junit.Test;
+
+/** Functional sanity-checks for MemFileSystemRegistry. */
+public class MemFileSystemRegistryFunctionalityTest {
+
+  @Test
+  public void sameFileManager_returnsIdenticalPrefix() {
+    JavaFileManager jfm =
+        ToolProvider.getSystemJavaCompiler().getStandardFileManager(null, null, null);
+
+    String first  = MemFileSystemRegistry.DEFAULT.getUrlPrefix(jfm);
+    String second = MemFileSystemRegistry.DEFAULT.getUrlPrefix(jfm);
+
+    assertThat(first).isEqualTo(second);
+  }
+
+  @Test
+  public void prefix_canRoundTripToFileSystem() throws Exception {
+    JavaFileManager jfm =
+        ToolProvider.getSystemJavaCompiler().getStandardFileManager(null, null, null);
+
+    String prefix = MemFileSystemRegistry.DEFAULT.getUrlPrefix(jfm);
+    // Construct a dummy URL within that prefix; path component can be empty.
+    URL url = new URL(prefix);
+
+    assertThat(MemFileSystemRegistry.DEFAULT.getFileSystem(url)).isSameAs(jfm);
+  }
+}