Migrate src/test/java to Java 21 (#238)

Migrate src/test/java to Java 21

https://docs.openrewrite.org/recipes/java/migrate/upgradetojava21

Modernize test code to use java 21 latest features

$ mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.migrate.UpgradeToJava21 -Pexamples -pl -:querydsl-example-kotlin

Co-authored-by: Marvin Froeder <[email protected]>

Author: velo

querydsl-apt/src/test/java/com/querydsl/apt/domain/ExpressionTest.java

@@ -69,17 +69,15 @@ public void test() throws Throwable {
     for (Expression<?> expr : exprs) {
       for (Field field : expr.getClass().getFields()) {
         Object rv = field.get(expr);
-        if (rv instanceof Expression) {
-          if (rv instanceof StringExpression) {
-            StringExpression str = (StringExpression) rv;
+        if (rv instanceof Expression expression) {
+          if (rv instanceof StringExpression str) {
             toVisit.add(str.toLowerCase());
             toVisit.add(str.charAt(0));
             toVisit.add(str.isEmpty());
-          } else if (rv instanceof BooleanExpression) {
-            BooleanExpression b = (BooleanExpression) rv;
+          } else if (rv instanceof BooleanExpression b) {
             toVisit.add(b.not());
           }
-          toVisit.add((Expression<?>) rv);
+          toVisit.add(expression);
         }
       }
     }

querydsl-apt/src/test/java/com/querydsl/apt/domain/QueryInit6Test.java

@@ -30,14 +30,12 @@ public abstract static class Component implements Serializable {
     @Transient
     public Container getContainer() {
       Component temp = this.parent;
-      if (this.parent instanceof HibernateProxy) {
-        temp =
-            (Component)
-                ((HibernateProxy) this.parent).getHibernateLazyInitializer().getImplementation();
+      if (this.parent instanceof HibernateProxy proxy) {
+        temp = (Component) proxy.getHibernateLazyInitializer().getImplementation();
       }
 
-      if (temp instanceof Container) {
-        return (Container) temp;
+      if (temp instanceof Container container) {
+        return container;
       } else {
         if (!temp.isRoot()) {
           return temp.getParent().getContainer();

querydsl-codegen-utils/src/test/java/com/querydsl/codegen/utils/SurefireBooterTest.java

@@ -11,8 +11,7 @@ public class SurefireBooterTest {
   @Test
   public void test() throws IOException {
     ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
-    if (classLoader instanceof URLClassLoader) {
-      URLClassLoader cl = (URLClassLoader) classLoader;
+    if (classLoader instanceof URLClassLoader cl) {
       if (cl.getURLs().length == 1 && cl.getURLs()[0].getPath().contains("surefirebooter")) {
         URL url = cl.findResource("META-INF/MANIFEST.MF");
         Manifest manifest = new Manifest(url.openStream());

querydsl-codegen-utils/src/test/java/com/querydsl/codegen/utils/support/Cat.java

@@ -68,7 +68,7 @@ public Cat(String name) {
 
   public Cat(String name, String kittenName) {
     this(name);
-    kittens.get(0).setName(kittenName);
+    kittens.getFirst().setName(kittenName);
   }
 
   public Cat(String name, int id) {

querydsl-codegen/src/test/java/com/querydsl/codegen/BeanSerializerTest.java

@@ -207,8 +207,7 @@ public void defaultsGeneratedAnnotation() throws IOException {
     serializer.serialize(type, SimpleSerializerConfig.DEFAULT, new JavaWriter(writer));
     var generatedSource = String.valueOf(writer);
     assertThat(generatedSource)
-        .contains(
-            String.format("import %s;", GeneratedAnnotationResolver.resolveDefault().getName()));
+        .contains("import %s;".formatted(GeneratedAnnotationResolver.resolveDefault().getName()));
     assertThat(generatedSource)
         .containsIgnoringNewLines(
             "@Generated(\"com.querydsl.codegen.BeanSerializer\")\npublic class");

querydsl-codegen/src/test/java/com/querydsl/codegen/CustomTypeTest.java

@@ -48,7 +48,9 @@ public void customType() throws IOException {
     serializer.serialize(entityType, SimpleSerializerConfig.DEFAULT, new JavaWriter(writer));
     assertThat(writer.toString())
         .contains(
-            "public final com.querydsl.codegen.Point property = "
-                + "new com.querydsl.codegen.Point(forProperty(\"property\"));");
+            """
+            public final com.querydsl.codegen.Point property = \
+            new com.querydsl.codegen.Point(forProperty("property"));\
+            """);
   }
 }

querydsl-codegen/src/test/java/com/querydsl/codegen/EmbeddableSerializerTest.java

@@ -212,8 +212,7 @@ public void defaultGeneratedAnnotation() throws IOException {
     serializer.serialize(entityType, SimpleSerializerConfig.DEFAULT, new JavaWriter(writer));
     final var generatedSource = writer.toString();
     assertThat(generatedSource)
-        .contains(
-            String.format("import %s;", GeneratedAnnotationResolver.resolveDefault().getName()));
+        .contains("import %s;".formatted(GeneratedAnnotationResolver.resolveDefault().getName()));
     assertThat(generatedSource)
         .containsIgnoringNewLines(
             "@Generated(\"com.querydsl.codegen.DefaultEmbeddableSerializer\")\npublic class");

querydsl-codegen/src/test/java/com/querydsl/codegen/EntitySerializerTest.java

@@ -61,8 +61,10 @@ public void different_package() throws IOException {
     serializer.serialize(entityType, SimpleSerializerConfig.DEFAULT, new JavaWriter(writer));
     assertThat(writer.toString())
         .contains(
-            "public class QEntitySerializerTest_Entity "
-                + "extends EntityPathBase<EntitySerializerTest.Entity>");
+            """
+            public class QEntitySerializerTest_Entity \
+            extends EntityPathBase<EntitySerializerTest.Entity>\
+            """);
     CompileUtils.assertCompiles("QEntitySerializerTest_Entity", writer.toString());
   }
 
@@ -224,8 +226,7 @@ public void defaultGeneratedAnnotation() throws IOException {
     serializer.serialize(entityType, SimpleSerializerConfig.DEFAULT, new JavaWriter(writer));
     String generatedSourceCode = writer.toString();
     assertThat(generatedSourceCode)
-        .contains(
-            String.format("import %s;", GeneratedAnnotationResolver.resolveDefault().getName()));
+        .contains("import %s;".formatted(GeneratedAnnotationResolver.resolveDefault().getName()));
     assertThat(generatedSourceCode)
         .containsIgnoringNewLines(
             "@Generated(\"com.querydsl.codegen.DefaultEntitySerializer\")\npublic class");

querydsl-codegen/src/test/java/com/querydsl/codegen/ProjectionSerializerTest.java

@@ -74,8 +74,7 @@ public void defaultGeneratedAnnotation() throws IOException {
     serializer.serialize(type, SimpleSerializerConfig.DEFAULT, new JavaWriter(writer));
     String generatedSource = writer.toString();
     assertThat(generatedSource)
-        .contains(
-            String.format("import %s;", GeneratedAnnotationResolver.resolveDefault().getName()));
+        .contains("import %s;".formatted(GeneratedAnnotationResolver.resolveDefault().getName()));
     assertThat(generatedSource)
         .containsIgnoringNewLines(
             "@Generated(\"com.querydsl.codegen.DefaultProjectionSerializer\")\npublic class");

querydsl-collections/src/test/java/com/querydsl/collections/Cat.java

@@ -58,7 +58,7 @@ public Cat(String name) {
 
   public Cat(String name, String kittenName) {
     this(name);
-    kittens.get(0).setName(kittenName);
+    kittens.getFirst().setName(kittenName);
   }
 
   @QueryProjection