Applied open rewrite recipes (#513)

* Applied open rewrite recipes

* Upgrade do Java 11

Author: velo

.github/workflows/receive-pr.yml

@@ -42,8 +42,7 @@ jobs:
 
       # Execute recipes
       - name: Apply OpenRewrite recipes
-        run: ./mvnw -Dtoolchain.skip=true -Dlicense.skip=true -DskipTests=true -P openrewrite clean install
-
+        run: ./mvnw -Dtoolchain.skip=true  -P examples,quickbuild,openrewrite,dev clean install
       # Capture the diff
       - name: Create patch
         run: |

pom.xml

@@ -1044,7 +1044,7 @@
                 <configuration>
                   <exportDatatables>true</exportDatatables>
                   <activeRecipes>
-                    <recipe>org.openrewrite.java.migrate.UpgradeToJava8</recipe>
+                    <recipe>org.openrewrite.java.migrate.Java8toJava11</recipe>
                   </activeRecipes>
                 </configuration>
               </execution>

querydsl-examples/querydsl-example-r2dbc-sql-codegen/src/test/java/com/querydsl/example/config/TestDataService.java

@@ -149,8 +149,10 @@ public void removeTestData() {
     // Idem for sequences
     s =
         c.createStatement(
-            "SELECT SEQUENCE_NAME FROM INFORMATION_SCHEMA.SEQUENCES WHERE"
-                + " SEQUENCE_SCHEMA='PUBLIC'");
+            """
+            SELECT SEQUENCE_NAME FROM INFORMATION_SCHEMA.SEQUENCES WHERE\
+             SEQUENCE_SCHEMA='PUBLIC'\
+            """);
     List<String> sequences =
         Flux.from(s.execute())
             .flatMap(result -> result.map((row, meta) -> row.get(0, String.class)))

querydsl-examples/querydsl-example-sql-guice/src/test/java/com/querydsl/example/sql/repository/TweetRepositoryTest.java

@@ -56,7 +56,7 @@ public void save_with_mentions() {
     tweet.setPosterId(posterId);
     Long tweetId = repository.save(tweet, otherId);
 
-    assertThat(repository.findWithMentioned(otherId).get(0).getId()).isEqualTo(tweetId);
+    assertThat(repository.findWithMentioned(otherId).getFirst().getId()).isEqualTo(tweetId);
   }
 
   @Test

querydsl-libraries/querydsl-collections/src/test/java/com/querydsl/collections/AliasTest.java

@@ -83,7 +83,7 @@ public void alias3() {
 
     // 4
     from(c, cats)
-        .where($(c.getKittens().get(0).getBodyWeight()).gt(12))
+        .where($(c.getKittens().getFirst().getBodyWeight()).gt(12))
         .select($(c.getName()))
         .iterate();
 

querydsl-libraries/querydsl-collections/src/test/java/com/querydsl/collections/CollQueryStandardTest.java

@@ -73,7 +73,7 @@ protected Fetchable<?> createQuery(Predicate filter) {
 
   @Test
   public void test() {
-    Cat kitten = data.getFirst().getKittens().get(0);
+    Cat kitten = data.getFirst().getKittens().getFirst();
     standardTest.runArrayTests(cat.kittenArray, otherCat.kittenArray, kitten, new Cat());
     standardTest.runBooleanTests(cat.name.isNull(), otherCat.kittens.isEmpty());
     standardTest.runCollectionTests(cat.kittens, otherCat.kittens, kitten, new Cat());

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/alias/MethodType.java

@@ -30,6 +30,8 @@ public enum MethodType {
   /** __mappedPath invocation */
   GET_MAPPED_PATH("__mappedPath", Path.class, ManagedObject.class),
   /** getter invocation */
+  LIST_GET_FIRST("getFirst", Object.class, List.class),
+  /** getter invocation */
   GETTER("(get|is).+", Object.class, Object.class),
   /** hashCode invocation */
   HASH_CODE("hashCode", int.class, Object.class),

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/alias/PropertyAccessInvocationHandler.java

@@ -84,27 +84,27 @@ public Object intercept(
     MethodType methodType = MethodType.get(method);
 
     if (methodType == MethodType.GETTER) {
-      String ptyName = propertyNameForGetter(method);
+      var ptyName = propertyNameForGetter(method);
       Class<?> ptyClass = method.getReturnType();
-      Type genericType = method.getGenericReturnType();
+      var genericType = method.getGenericReturnType();
 
       if (propToObj.containsKey(ptyName)) {
         rv = propToObj.get(ptyName);
       } else {
-        PathMetadata pm = createPropertyPath((Path<?>) hostExpression, ptyName);
+        var pm = createPropertyPath((Path<?>) hostExpression, ptyName);
         rv = newInstance(ptyClass, genericType, proxy, ptyName, pm);
       }
       aliasFactory.setCurrent(propToExpr.get(ptyName));
 
     } else if (methodType == MethodType.SCALA_GETTER) {
-      String ptyName = method.getName();
+      var ptyName = method.getName();
       Class<?> ptyClass = method.getReturnType();
-      Type genericType = method.getGenericReturnType();
+      var genericType = method.getGenericReturnType();
 
       if (propToObj.containsKey(ptyName)) {
         rv = propToObj.get(ptyName);
       } else {
-        PathMetadata pm = createPropertyPath((Path<?>) hostExpression, ptyName);
+        var pm = createPropertyPath((Path<?>) hostExpression, ptyName);
         rv = newInstance(ptyClass, genericType, proxy, ptyName, pm);
       }
       aliasFactory.setCurrent(propToExpr.get(ptyName));
@@ -115,7 +115,18 @@ public Object intercept(
       if (propToObj.containsKey(propKey)) {
         rv = propToObj.get(propKey);
       } else {
-        PathMetadata pm = createListAccessPath((Path<?>) hostExpression, (Integer) args[0]);
+        var pm = createListAccessPath((Path<?>) hostExpression, (Integer) args[0]);
+        Class<?> elementType = ((ParameterizedExpression<?>) hostExpression).getParameter(0);
+        rv = newInstance(elementType, elementType, proxy, propKey, pm);
+      }
+      aliasFactory.setCurrent(propToExpr.get(propKey));
+    } else if (methodType == MethodType.LIST_GET_FIRST) {
+      // TODO : manage cases where the argument is based on a property invocation
+      Object propKey = Arrays.asList(MethodType.LIST_GET_FIRST);
+      if (propToObj.containsKey(propKey)) {
+        rv = propToObj.get(propKey);
+      } else {
+        var pm = PathMetadataFactory.forListFirst((Path<?>) hostExpression);
         Class<?> elementType = ((ParameterizedExpression<?>) hostExpression).getParameter(0);
         rv = newInstance(elementType, elementType, proxy, propKey, pm);
       }
@@ -126,7 +137,7 @@ public Object intercept(
       if (propToObj.containsKey(propKey)) {
         rv = propToObj.get(propKey);
       } else {
-        PathMetadata pm = createMapAccessPath((Path<?>) hostExpression, args[0]);
+        var pm = createMapAccessPath((Path<?>) hostExpression, args[0]);
         Class<?> valueType = ((ParameterizedExpression<?>) hostExpression).getParameter(1);
         rv = newInstance(valueType, valueType, proxy, propKey, pm);
       }
@@ -270,7 +281,7 @@ protected <T> T newInstance(
   }
 
   protected String propertyNameForGetter(Method method) {
-    String name = method.getName();
+    var name = method.getName();
     name = name.startsWith("is") ? name.substring(2) : name.substring(3);
     return BeanUtils.uncapitalize(name);
   }

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/types/PathMetadataFactory.java

@@ -55,6 +55,16 @@ public static PathMetadata forCollectionAny(Path<?> parent) {
     return new PathMetadata(parent, "", PathType.COLLECTION_ANY);
   }
 
+  /**
+   * Create a new PathMetadata instance for list first element
+   *
+   * @param parent parent path
+   * @return collection any path
+   */
+  public static PathMetadata forListFirst(Path<?> parent) {
+    return new PathMetadata(parent, "", PathType.LIST_FIRST);
+  }
+
   /**
    * Create a new PathMetadata instance for delegate access
    *

querydsl-libraries/querydsl-core/src/main/java/com/querydsl/core/types/PathType.java

@@ -46,7 +46,10 @@ public enum PathType implements Operator {
   VARIABLE,
 
   /** Treated path */
-  TREATED_PATH;
+  TREATED_PATH,
+
+  /** List first element (list.getFirst) */
+  LIST_FIRST;
 
   @Override
   public Class<?> getType() {