even better compiler logging

Author: josephjclark

.changeset/pretty-hounds-invent.md

@@ -0,0 +1,8 @@
+---
+'@openfn/compiler': patch
+---
+
+Improved log output:
+
+- Don't log anything for import/export statements (consistent with other visitors)
+- When a step is compiled, include the step name

.changeset/warm-bananas-cry.md

@@ -0,0 +1,5 @@
+---
+'@openfn/engine-multi': patch
+---
+
+Better logs for compiler

packages/compiler/src/compile.ts

@@ -51,8 +51,12 @@ export default function compile(
   // write the operations index to the source map
   map.operations = (transformedAst.program as any).operations ?? [];
 
-  const duration = (Date.now() - start) / 1000;
-  logger.success(`Compilation complete in ${duration.toPrecision(2)}s`);
+  const duration = ((Date.now() - start) / 1000).toPrecision(2);
+  if (options.name) {
+    logger.info(`Compiled ${name} in ${duration}s`);
+  } else {
+    logger.info(`Compilation complete in ${duration}s`);
+  }
 
   if (options.logCompiledSource) {
     logger.debug('Compiled source:');

packages/compiler/src/transforms/add-imports.ts

@@ -156,7 +156,7 @@ export function findAllDanglingIdentifiers(ast: ASTNode) {
   return result;
 }
 
-function visitor(path: NodePath, logger: Logger, options: AddImportsOptions) {
+function visitor(path: NodePath, _logger: Logger, options: AddImportsOptions) {
   if (options.adaptors) {
     const identifiers = findAllDanglingIdentifiers(path.node);
 
@@ -180,10 +180,10 @@ function visitor(path: NodePath, logger: Logger, options: AddImportsOptions) {
         if (usedExports.length) {
           // TODO maybe in trace output we can say WHY we're doing these things
           addUsedImports(path, usedExports, name);
-          logger.debug(`Added import statement for ${name}`);
+          //logger.debug(`Added import statement for ${name}`);
           if (exportAll) {
             addExportAdaptor(path, name);
-            logger.debug(`Added export * statement for ${name}`);
+            //logger.debug(`Added export * statement for ${name}`);
           }
         }
       }

packages/engine-multi/src/worker/thread/compile.ts

@@ -47,6 +47,7 @@ const compileJob = async (job: Job, logger: Logger, repoDir?: string) => {
   const { expression, adaptors, linker } = job;
   const compilerOptions: Options = {
     logger,
+    name: job.name,
   };
   if (adaptors && repoDir) {
     const adaptorConfig = [];

packages/engine-multi/src/worker/thread/run.ts

@@ -81,10 +81,15 @@ register({
       publish(COMPILE_START, {
         workflowId: plan.id,
       });
+      logger.info('Compiling all workflow steps...');
       await compile(plan, { repoDir }, logger);
+      const duration = Date.now() - start;
+      logger.success(
+        `Workflow compilation complete in ${(duration / 1000).toPrecision(2)}s`
+      );
       publish(COMPILE_COMPLETE, {
         workflowId: plan.id,
-        duration: Date.now() - start,
+        duration,
       });
       return run(plan, input, options);
     });