bump elixir deps (#4294)

* bump deps

* Migrate away from deprecated use Tesla macro pattern

Remove deprecated `use Tesla` and `plug` macros in favor of explicit
Tesla.client() calls with middleware configuration. This migration:

- Removes all `use Tesla` declarations
- Converts `plug` macros to explicit middleware lists
- Adds adapter helper functions for test compatibility
- Updates all HTTP method calls to use Tesla.* prefix

All Tesla clients now use explicit client building with middleware
and adapter configuration via Application.get_env.

Fixes deprecation warnings from Tesla 1.15+ upgrade.

* concept sobelow skip

* Remove sobelow-skips

Fix sobelow warning
Fix dialyzer error from storybook

* Skip Traversal.SendDownload warning

Don't log low threshold warnings on CI.

---------

Co-authored-by: Taylor Downs <taylor@openfn.org>
Co-authored-by: Stuart Corbishley <corbish@gmail.com>

Author: 3 people

.circleci/config.yml

@@ -118,7 +118,7 @@ workflows:
       - build:
           name: "Check for security vulnerabilities"
           execute:
-            - run: sudo -u lightning mix sobelow
+            - run: sudo -u lightning mix sobelow --threshold medium
       - build:
           name: "Check Elixir tests (codecov)"
           execute:

.github/workflows/main.yml

@@ -9,7 +9,7 @@ jobs:
   build-and-deploy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - uses: erlef/setup-elixir@v1
         with:
           otp-version: 26

.sobelow-conf

@@ -7,6 +7,6 @@
   format: "txt",
   out: "",
   threshold: "low",
-  ignore: ["Config.CSP"],
+  ignore: ["Config.CSP", "Config.HTTPS"],
   ignore_files: [""]
 ]

lib/lightning/auth_providers/oauth_http_client.ex

@@ -6,12 +6,14 @@ defmodule Lightning.AuthProviders.OauthHTTPClient do
 
   Returns structured error responses that integrate well with the audit system.
   """
-  use Tesla
-
   alias LightningWeb.RouteHelpers
 
   require Logger
 
+  defp adapter do
+    Application.get_env(:tesla, __MODULE__, [])[:adapter]
+  end
+
   @doc """
   Revokes an OAuth token.
 
@@ -77,10 +79,13 @@ defmodule Lightning.AuthProviders.OauthHTTPClient do
       redirect_uri: RouteHelpers.oidc_callback_url()
     }
 
-    Tesla.client([
-      Tesla.Middleware.FormUrlencoded
-    ])
-    |> post(client.token_endpoint, body)
+    Tesla.client(
+      [
+        Tesla.Middleware.FormUrlencoded
+      ],
+      adapter()
+    )
+    |> Tesla.post(client.token_endpoint, body)
     |> handle_response([200])
     |> maybe_introspect(client)
   end
@@ -114,10 +119,13 @@ defmodule Lightning.AuthProviders.OauthHTTPClient do
         grant_type: "refresh_token"
       }
 
-      Tesla.client([
-        Tesla.Middleware.FormUrlencoded
-      ])
-      |> post(client.token_endpoint, body)
+      Tesla.client(
+        [
+          Tesla.Middleware.FormUrlencoded
+        ],
+        adapter()
+      )
+      |> Tesla.post(client.token_endpoint, body)
       |> handle_response([200])
       |> maybe_introspect(client)
       |> case do
@@ -155,7 +163,8 @@ defmodule Lightning.AuthProviders.OauthHTTPClient do
     else
       headers = [{"Authorization", "Bearer #{access_token}"}]
 
-      get(client.userinfo_endpoint, headers: headers)
+      Tesla.client([{Tesla.Middleware.Headers, headers}], adapter())
+      |> Tesla.get(client.userinfo_endpoint)
       |> handle_response([200])
     end
   end
@@ -194,10 +203,13 @@ defmodule Lightning.AuthProviders.OauthHTTPClient do
       client_secret: client.client_secret
     }
 
-    Tesla.client([
-      Tesla.Middleware.FormUrlencoded
-    ])
-    |> post(client.revocation_endpoint, body)
+    Tesla.client(
+      [
+        Tesla.Middleware.FormUrlencoded
+      ],
+      adapter()
+    )
+    |> Tesla.post(client.revocation_endpoint, body)
     |> handle_response([200, 204])
     |> case do
       {:ok, _} ->
@@ -240,10 +252,13 @@ defmodule Lightning.AuthProviders.OauthHTTPClient do
       token_type_hint: "access_token"
     }
 
-    Tesla.client([
-      Tesla.Middleware.FormUrlencoded
-    ])
-    |> post(client.introspection_endpoint, body)
+    Tesla.client(
+      [
+        Tesla.Middleware.FormUrlencoded
+      ],
+      adapter()
+    )
+    |> Tesla.post(client.introspection_endpoint, body)
     |> handle_response([200])
   end
 

lib/lightning/usage_tracking/client.ex

@@ -4,30 +4,35 @@ defmodule Lightning.UsageTracking.Client do
 
 
   """
-  use Tesla, only: [:head, :post], docs: false
-
   alias Lightning.UsageTracking.ResponseProcessor
 
+  defp adapter do
+    Application.get_env(:tesla, __MODULE__, [])[:adapter]
+  end
+
   def submit_metrics(metrics, host) do
     response =
       host
       |> build_client()
-      |> post("/api/metrics", metrics)
+      |> Tesla.post("/api/metrics", metrics)
 
     if ResponseProcessor.successful?(response), do: :ok, else: :error
   end
 
   def reachable?(host) do
     build_head_client(host)
-    |> head("/")
+    |> Tesla.head("/")
     |> ResponseProcessor.successful?()
   end
 
   defp build_client(host) do
-    Tesla.client([{Tesla.Middleware.BaseUrl, host}, Tesla.Middleware.JSON])
+    Tesla.client(
+      [{Tesla.Middleware.BaseUrl, host}, Tesla.Middleware.JSON],
+      adapter()
+    )
   end
 
   defp build_head_client(host) do
-    Tesla.client([{Tesla.Middleware.BaseUrl, host}])
+    Tesla.client([{Tesla.Middleware.BaseUrl, host}], adapter())
   end
 end

lib/lightning/usage_tracking/github_client.ex

@@ -2,25 +2,27 @@ defmodule Lightning.UsageTracking.GithubClient do
   @moduledoc """
   A GitHub client to make unauthenticated HTTP requests to GitHub.
   """
-  use Tesla, only: [:head], docs: false
-
   alias Lightning.UsageTracking.ResponseProcessor
 
   @host "https://github.com/"
 
+  defp adapter do
+    Application.get_env(:tesla, __MODULE__, [])[:adapter]
+  end
+
   def open_fn_commit?(nil = _commit_sha), do: false
   def open_fn_commit?("" = _commit_sha), do: false
 
   def open_fn_commit?(commit_sha) do
     response =
       @host
       |> build_client()
-      |> head("OpenFn/lightning/commit/#{commit_sha}")
+      |> Tesla.head("OpenFn/lightning/commit/#{commit_sha}")
 
     ResponseProcessor.successful_200?(response)
   end
 
   def build_client(host) do
-    Tesla.client([{Tesla.Middleware.BaseUrl, host}])
+    Tesla.client([{Tesla.Middleware.BaseUrl, host}], adapter())
   end
 end

lib/lightning/version_control/github_client.ex

@@ -3,116 +3,123 @@ defmodule Lightning.VersionControl.GithubClient do
   Tesla github http client we use this to make any network requests
   to github from Lightning
   """
-  use Tesla
-
   alias Lightning.VersionControl.GithubError
   alias Lightning.VersionControl.GithubToken
 
   require Logger
 
-  plug(Tesla.Middleware.BaseUrl, "https://api.github.com")
-  plug(Tesla.Middleware.JSON)
+  defp adapter do
+    Application.get_env(:tesla, __MODULE__, [])[:adapter]
+  end
 
   def create_repo_dispatch_event(client, repo_name, body) do
-    client |> post("/repos/#{repo_name}/dispatches", body) |> handle_resp([204])
+    client
+    |> Tesla.post("/repos/#{repo_name}/dispatches", body)
+    |> handle_resp([204])
   end
 
   def create_workflow_dispatch_event(client, repo_name, workflow_id, body) do
     client
-    |> post(
+    |> Tesla.post(
       "repos/#{repo_name}/actions/workflows/#{workflow_id}/dispatches",
       body
     )
     |> handle_resp([204])
   end
 
   def get_installations(client) do
-    client |> get("/user/installations") |> handle_resp([200])
+    client |> Tesla.get("/user/installations") |> handle_resp([200])
   end
 
   def get_installation_repos(client, query \\ [page: 1, per_page: 100]) do
     client
-    |> get("/installation/repositories", query: query)
+    |> Tesla.get("/installation/repositories", query: query)
     |> handle_resp([200])
   end
 
   def get_repo(client, repo_name) do
-    client |> get("/repos/#{repo_name}") |> handle_resp([200])
+    client |> Tesla.get("/repos/#{repo_name}") |> handle_resp([200])
   end
 
   def get_repo_branches(client, repo_name) do
-    client |> get("/repos/#{repo_name}/branches") |> handle_resp([200])
+    client |> Tesla.get("/repos/#{repo_name}/branches") |> handle_resp([200])
   end
 
   def get_repo_content(client, repo, path, ref) do
     client
-    |> get("/repos/#{repo}/contents/#{path}", query: [ref: ref])
+    |> Tesla.get("/repos/#{repo}/contents/#{path}", query: [ref: ref])
     |> handle_resp([200])
   end
 
   def delete_repo_content(client, repo, path, body) do
     client
-    |> delete("/repos/#{repo}/contents/#{path}", body: body)
+    |> Tesla.delete("/repos/#{repo}/contents/#{path}", body: body)
     |> handle_resp([200])
   end
 
   def create_blob(client, repo, body) do
-    client |> post("/repos/#{repo}/git/blobs", body) |> handle_resp([201])
+    client |> Tesla.post("/repos/#{repo}/git/blobs", body) |> handle_resp([201])
   end
 
   def create_tree(client, repo, body) do
-    client |> post("/repos/#{repo}/git/trees", body) |> handle_resp([201])
+    client |> Tesla.post("/repos/#{repo}/git/trees", body) |> handle_resp([201])
   end
 
   def get_commit(client, repo, ref) do
-    client |> get("/repos/#{repo}/commits/#{ref}") |> handle_resp([200])
+    client |> Tesla.get("/repos/#{repo}/commits/#{ref}") |> handle_resp([200])
   end
 
   def create_commit(client, repo, body) do
-    client |> post("/repos/#{repo}/git/commits", body) |> handle_resp([201])
+    client
+    |> Tesla.post("/repos/#{repo}/git/commits", body)
+    |> handle_resp([201])
   end
 
   def create_ref(client, repo, body) do
-    client |> post("/repos/#{repo}/git/refs", body) |> handle_resp([201])
+    client |> Tesla.post("/repos/#{repo}/git/refs", body) |> handle_resp([201])
   end
 
   def update_ref(client, repo, ref, body) do
-    client |> post("/repos/#{repo}/git/refs/#{ref}", body) |> handle_resp([200])
+    client
+    |> Tesla.post("/repos/#{repo}/git/refs/#{ref}", body)
+    |> handle_resp([200])
   end
 
   def delete_ref(client, repo, ref) do
-    client |> delete("/repos/#{repo}/git/refs/#{ref}") |> handle_resp([204])
+    client
+    |> Tesla.delete("/repos/#{repo}/git/refs/#{ref}")
+    |> handle_resp([204])
   end
 
   def delete_app_grant(client, app_client_id, token) do
     client
-    |> delete("/applications/#{app_client_id}/grant",
+    |> Tesla.delete("/applications/#{app_client_id}/grant",
       body: %{access_token: token}
     )
     |> handle_resp([204])
   end
 
   def get_repo_public_key(client, repo) do
     client
-    |> get("/repos/#{repo}/actions/secrets/public-key")
+    |> Tesla.get("/repos/#{repo}/actions/secrets/public-key")
     |> handle_resp([200])
   end
 
   def get_repo_secret(client, repo, secret_name) do
     client
-    |> get("/repos/#{repo}/actions/secrets/#{secret_name}")
+    |> Tesla.get("/repos/#{repo}/actions/secrets/#{secret_name}")
     |> handle_resp([200])
   end
 
   def create_repo_secret(client, repo, secret_name, body) do
     client
-    |> put("/repos/#{repo}/actions/secrets/#{secret_name}", body)
+    |> Tesla.put("/repos/#{repo}/actions/secrets/#{secret_name}", body)
     |> handle_resp([201, 204])
   end
 
   def delete_repo_secret(client, repo, secret_name) do
     client
-    |> delete("/repos/#{repo}/actions/secrets/#{secret_name}")
+    |> Tesla.delete("/repos/#{repo}/actions/secrets/#{secret_name}")
     |> handle_resp([204])
   end
 
@@ -126,26 +133,30 @@ defmodule Lightning.VersionControl.GithubClient do
        ]}
     ]
 
-    {:ok, Tesla.client(middleware)}
+    {:ok, Tesla.client(middleware, adapter())}
   end
 
   def build_bearer_client(token) do
     middleware = [
+      {Tesla.Middleware.BaseUrl, "https://api.github.com"},
+      Tesla.Middleware.JSON,
       {Tesla.Middleware.Headers,
        [
          {"Authorization", "Bearer #{token}"}
        ]}
     ]
 
-    {:ok, Tesla.client(middleware)}
+    {:ok, Tesla.client(middleware, adapter())}
   end
 
   def build_basic_auth_client(username, password) do
     middleware = [
+      {Tesla.Middleware.BaseUrl, "https://api.github.com"},
+      Tesla.Middleware.JSON,
       {Tesla.Middleware.BasicAuth, [username: username, password: password]}
     ]
 
-    {:ok, Tesla.client(middleware)}
+    {:ok, Tesla.client(middleware, adapter())}
   end
 
   def build_installation_client(installation_id) do
@@ -155,7 +166,7 @@ defmodule Lightning.VersionControl.GithubClient do
 
     with {:ok, auth_token, _} <- GithubToken.build(cert, app_id),
          {:ok, client} <- build_bearer_client(auth_token) do
-      case post(
+      case Tesla.post(
              client,
              "/app/installations/#{installation_id}/access_tokens",
              ""

lib/lightning_web/controllers/project_file_controller.ex

@@ -6,6 +6,8 @@ defmodule LightningWeb.ProjectFileController do
   alias Lightning.Repo
   alias Lightning.Storage.ProjectFileDefinition
 
+  # sobelow_skip ["Traversal.SendDownload"]
+  # Path is safe: generated by storage_path_for_exports/2 using system UUIDs only
   def download(conn, %{"id" => id}) do
     project_file = Repo.get!(Lightning.Projects.File, id)