Ensure the default environment is always dev (#4270) (#4285)

* Ensure the default environment is always dev (#4270)

* remove environment field from the create sandbox form and keep default env as dev

* update CHANGELOG.md

* little settings page tweak

---------

Co-authored-by: Muhammad Ali <muhammadmullah16@gmail.com>

Author: josephjclark

CHANGELOG.md

@@ -15,6 +15,9 @@ and this project adheres to
 
 ## [Unreleased]
 
+- Remove Environment input from Sandbox form
+  [#3954](https://github.com/OpenFn/lightning/issues/3954)
+
 ### Added
 
 ### Changed

lib/lightning_web/live/project_live/concurrency_input_component.ex

@@ -18,7 +18,7 @@ defmodule LightningWeb.ProjectLive.ConcurrencyInputComponent do
       <span class="ml-3 text-sm" id="concurrency-description">
         <span class="font-medium text-gray-900">Disable parallel execution</span>
         <span class="text-gray-500">
-          (No more than one run at a time.)
+          (No more than one run at a time)
         </span>
       </span>
     </div>

lib/lightning_web/live/project_live/settings.html.heex

@@ -97,6 +97,9 @@
                     disabled={!@can_edit_project}
                     label="Project environment"
                   />
+                  <small class="mt-2 block text-xs text-gray-600">
+                    Credentials will be loaded with values from this environment.
+                  </small>
                 </div>
               </div>
               <div class="grid grid-cols gap-6">
@@ -109,7 +112,7 @@
                     class="mt-1 focus:ring-primary-500 focus:border-primary-500 block w-full shadow-xs sm:text-sm border-secondary-300 rounded-md"
                   />
                   <small class="mt-2 block text-xs text-gray-600">
-                    A short description of a project [max 240 characters]
+                    A short description of a project (max 240 characters)
                   </small>
                 </div>
               </div>

lib/lightning_web/live/sandbox_live/form_component.ex

@@ -82,7 +82,10 @@ defmodule LightningWeb.SandboxLive.FormComponent do
           }
         } = socket
       ) do
-    attrs = build_sandbox_attrs(params)
+    attrs =
+      params
+      |> build_sandbox_attrs()
+      |> Map.put(:env, "dev")
 
     with :ok <- ProjectLimiter.limit_new_sandbox(parent.id),
          {:ok, sandbox} <- Projects.provision_sandbox(parent, actor, attrs) do
@@ -232,14 +235,6 @@ defmodule LightningWeb.SandboxLive.FormComponent do
               <% end %>
             </div>
 
-            <.input
-              type="text"
-              field={f[:env]}
-              label="Environment"
-              placeholder="staging"
-              autocomplete="off"
-            />
-
             <Components.color_palette id="sandbox-color-picker" field={f[:color]} />
           </div>
 
@@ -276,7 +271,6 @@ defmodule LightningWeb.SandboxLive.FormComponent do
     %{
       "name" => sandbox.name,
       "raw_name" => sandbox.name,
-      "env" => sandbox.env,
       "color" => sandbox.color
     }
   end
@@ -320,8 +314,7 @@ defmodule LightningWeb.SandboxLive.FormComponent do
   defp build_sandbox_attrs(params) do
     %{
       name: params["name"],
-      color: params["color"],
-      env: params["env"]
+      color: params["color"]
     }
   end
 

test/lightning_web/live/sandbox_live/form_component_test.exs

@@ -199,7 +199,7 @@ defmodule LightningWeb.SandboxLive.FormComponentTest do
           assert user_arg.id == user.id
 
           name = attrs[:name] || attrs["name"]
-          env = attrs[:env] || attrs["env"]
+          env = attrs[:env] || attrs["env"] || current_sb.env
           color = attrs[:color] || attrs["color"]
 
           if name in [nil, ""] do