Skip to content

Commit af6d32c

Browse files
authored
Merge pull request #103 from lalithkota/main
Fixed ODK 2025.2.1
2 parents 38fa6ad + 9f47aa9 commit af6d32c

File tree

3 files changed

+18
-22
lines changed

3 files changed

+18
-22
lines changed

charts/odk-central-enketo/templates/_helpers.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Return the Image Registry Secret Names
33
*/}}
44
{{- define "odkEnketo.imagePullSecrets" -}}
5-
{{- include "common.images.pullSecrets" (dict "images" (list .Values.image .Values.redis.main.image .Values.redis.cache.image) "global" .Values.global) -}}
5+
{{- include "common.images.pullSecrets" (dict "images" (list .Values.image) "global" .Values.global) -}}
66
{{- end -}}
77

88
{{/*

charts/odk-central-enketo/values.yaml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ image:
1515

1616
containerPort: 8005
1717

18+
# There is no proper healthcheck api in enketo
1819
startupProbe:
1920
enabled: true
20-
httpGet:
21+
tcpSocket:
2122
port: http
22-
path: /
2323
initialDelaySeconds: 0
2424
periodSeconds: 30
2525
timeoutSeconds: 5
@@ -28,9 +28,8 @@ startupProbe:
2828

2929
livenessProbe:
3030
enabled: true
31-
httpGet:
31+
tcpSocket:
3232
port: http
33-
path: /
3433
initialDelaySeconds: 20
3534
periodSeconds: 60
3635
timeoutSeconds: 5
@@ -39,17 +38,16 @@ livenessProbe:
3938

4039
readinessProbe:
4140
enabled: true
42-
httpGet:
41+
tcpSocket:
4342
port: http
44-
path: /
4543
initialDelaySeconds: 0
4644
periodSeconds: 20
4745
timeoutSeconds: 5
4846
failureThreshold: 2
4947
successThreshold: 1
5048

51-
command: []
52-
args: []
49+
command: ['{{ include "common.tplvalues.render" (dict "value" .Values.enketoSrcDir "context" $) }}/start-enketo.sh']
50+
args: ["yarn", "workspace", "enketo-express", "start"]
5351

5452
resources: {}
5553
# limits:
@@ -98,10 +96,10 @@ envVarsFrom:
9896
key: enketo-api-key
9997

10098
startEnketoScript: |-
101-
#!/bin/sh
99+
#!/usr/bin/env bash
102100
103-
set -o pipefail
104101
set -e
102+
set -o pipefail
105103
106104
CONFIG_PATH=${ENKETO_SRC_DIR}/config/config.json
107105
echo "generating enketo configuration..."
@@ -110,7 +108,7 @@ startEnketoScript: |-
110108
111109
echo "starting enketo..."
112110
cd $ENKETO_SRC_DIR
113-
exec yarn workspace enketo-express start
111+
exec $@
114112
115113
configJsonTemplate: |-
116114
{

charts/odk-central/values.yaml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ backend:
3333

3434
podAnnotations: {}
3535
podLabels:
36-
app.kubernetes.io/component: backend
36+
app.kubernetes.io/name: '{{ include "common.names.name" . }}-backend'
3737

3838
containerPort: 8383
3939
service:
@@ -45,11 +45,11 @@ backend:
4545
tag: v2025.2.1
4646
pullPolicy: Always
4747

48+
# There is no healthcheck api in odk-central-backend
4849
startupProbe:
4950
enabled: true
50-
httpGet:
51+
tcpSocket:
5152
port: http
52-
path: /
5353
initialDelaySeconds: 0
5454
periodSeconds: 30
5555
timeoutSeconds: 5
@@ -58,9 +58,8 @@ backend:
5858

5959
livenessProbe:
6060
enabled: true
61-
httpGet:
61+
tcpSocket:
6262
port: http
63-
path: /
6463
initialDelaySeconds: 20
6564
periodSeconds: 60
6665
timeoutSeconds: 5
@@ -69,9 +68,8 @@ backend:
6968

7069
readinessProbe:
7170
enabled: true
72-
httpGet:
71+
tcpSocket:
7372
port: http
74-
path: /
7573
initialDelaySeconds: 0
7674
periodSeconds: 20
7775
timeoutSeconds: 5
@@ -302,7 +300,7 @@ frontend:
302300

303301
podAnnotations: {}
304302
podLabels:
305-
app.kubernetes.io/component: frontend
303+
app.kubernetes.io/name: '{{ include "common.names.name" . }}-frontend'
306304

307305
containerPort: 80
308306
service:
@@ -386,7 +384,7 @@ frontend:
386384

387385
clientConfigJsonTemplate: |-
388386
{
389-
"oidcEnabled": $OIDC_ENABLED
387+
"oidcEnabled": ${OIDC_ENABLED}
390388
}
391389
392390
setupOdkScript: |-
@@ -527,7 +525,7 @@ frontend:
527525
528526
location ~ ^/v\d {
529527
proxy_set_header X-Forwarded-Proto https;
530-
proxy_pass http://${BACKEND_URL}:8383;
528+
proxy_pass http://${BACKEND_URL};
531529
proxy_redirect off;
532530
533531
# buffer requests, but not responses, so streaming out works.

0 commit comments

Comments
 (0)