Merge pull request #1384 from OpenGeoscience/marker-primitive-auto

manthey · web-flow · commit c7f90e9750e6 · 2025-07-10T18:33:42.000-04:00
fix: Fix a potential issue with auto primitiveShape in markers
diff --git a/src/webgl/markerFeature.js b/src/webgl/markerFeature.js
@@ -368,7 +368,7 @@ var webgl_markerFeature = function (arg) {
     if (!m_this._primitiveShapeAuto || m_this._primitiveShape !== markerFeature.primitiveShapes.sprite) {
       return;
     }
-    if (m_this._approximateMaxRadius(zoom) > webglRenderer._maxPointSize) {
+    if (m_this._approximateMaxRadius(zoom) * 2 > webglRenderer._maxPointSize) {
       m_this._primitiveShape = markerFeature.primitiveShapes.triangle;
       m_this.renderer().contextRenderer().removeActor(m_this.actors()[0]);
       m_this._init(true);

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,7 @@ var webgl_markerFeature = function (arg) {`
`368`	`368`	`if (!m_this._primitiveShapeAuto \|\| m_this._primitiveShape !== markerFeature.primitiveShapes.sprite) {`
`369`	`369`	`return;`
`370`	`370`	`}`
`371`		`- if (m_this._approximateMaxRadius(zoom) > webglRenderer._maxPointSize) {`
	`371`	`+ if (m_this._approximateMaxRadius(zoom) * 2 > webglRenderer._maxPointSize) {`
`372`	`372`	`m_this._primitiveShape = markerFeature.primitiveShapes.triangle;`
`373`	`373`	`m_this.renderer().contextRenderer().removeActor(m_this.actors()[0]);`
`374`	`374`	`m_this._init(true);`