Harden against nil objects

This happens if a favorited contact get's archived, this would trigger
an exception.

Author: helje5

DocumentAPI/OGoContacts/SkyEnterpriseDocument.m

@@ -148,24 +148,45 @@ - (SkyDocumentType *)documentType {
 - (EODataSource *)personDataSource {
   SkyEnterprisePersonDataSource *ds;
 
+  if (self->globalID == nil) {
+    [self logWithFormat:
+      @"WARNING: no globalID for person datasource"];
+    return nil;
+  }
+
   ds = [SkyEnterprisePersonDataSource alloc]; // keep gcc happy
-  ds = [ds initWithContext:[self context] enterpriseId:[self globalID]];
+  ds = [ds initWithContext:[self context]
+         enterpriseId:[self globalID]];
   return [ds autorelease];
 }
 
 - (EODataSource *)projectDataSource {
   SkyEnterpriseProjectDataSource *ds;
 
+  if (self->globalID == nil) {
+    [self logWithFormat:
+      @"WARNING: no globalID for project datasource"];
+    return nil;
+  }
+
   ds = [SkyEnterpriseProjectDataSource alloc]; // keep gcc happy
-  ds = [ds initWithContext:[self context] enterpriseId:[self globalID]];
+  ds = [ds initWithContext:[self context]
+         enterpriseId:[self globalID]];
   return [ds autorelease];
 }
 
 - (EODataSource *)allProjectsDataSource {
   SkyEnterpriseAllProjectsDataSource *ds;
 
+  if (self->globalID == nil) {
+    [self logWithFormat:
+      @"WARNING: no globalID for allProjects datasource"];
+    return nil;
+  }
+
   ds = [SkyEnterpriseAllProjectsDataSource alloc]; // keep gcc happy
-  ds = [ds initWithContext:[self context] enterpriseId:[self globalID]];
+  ds = [ds initWithContext:[self context]
+         enterpriseId:[self globalID]];
   return [ds autorelease];
 }
 

DocumentAPI/OGoContacts/SkyPersonDocument.m

@@ -186,8 +186,15 @@ - (EODataSource *)enterpriseDataSource {
 - (EODataSource *)projectDataSource {
   SkyPersonProjectDataSource *ds;
 
-  ds = [[SkyPersonProjectDataSource alloc] initWithContext:[self context]
-                                           personId:[self globalID]];
+  if (self->globalID == nil) {
+    [self logWithFormat:
+      @"WARNING: no globalID for project datasource"];
+    return nil;
+  }
+
+  ds = [[SkyPersonProjectDataSource alloc]
+         initWithContext:[self context]
+         personId:[self globalID]];
   return [ds autorelease];
 }
 

WebUI/Contact/EnterprisesUI/SkyEnterpriseViewer.m

@@ -338,8 +338,15 @@ - (BOOL)prepareForActivationCommand:(NSString *)_command
       id ctx;
 
       if ([obj isKindOfClass:[EOGlobalID class]]) {
+        EOGlobalID *gid = obj;
         obj = [[self runCommand:@"enterprise::get-by-globalid",
-                     @"gid", obj, nil] lastObject];
+                     @"gid", gid, nil] lastObject];
+        if (obj == nil) {
+          [self errorWithFormat:
+            @"could not fetch enterprise for gid %@"
+            @" (archived?)", gid];
+          return NO;
+        }
       }
       ctx = [self commandContext];
       obj = [[SkyEnterpriseDocument alloc] initWithEO:obj context:ctx];

WebUI/Contact/PersonsUI/SkyPersonViewer.m

@@ -276,8 +276,15 @@ - (BOOL)prepareForActivationCommand:(NSString *)_command
     id ctx;
 
     if ([obj isKindOfClass:[EOKeyGlobalID class]]) {
+      EOGlobalID *gid = obj;
       obj = [[self runCommand:@"person::get-by-globalID",
-                                @"gid", obj, nil] lastObject];
+                                @"gid", gid, nil] lastObject];
+      if (obj == nil) {
+        [self errorWithFormat:
+          @"could not fetch person for gid %@"
+          @" (archived?)", gid];
+        return NO;
+      }
     }
     else {
       // should be an eo (activated by LSWViewAction/viewPerson)