Skip to content

Commit 3abc11c

Browse files
simonrosenbergopenhands-agentall-hands-bot
authored
fix(workflow): Normalize instance_ids by stripping spaces instead of failing (#2529)
Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: OpenHands Bot <contact@all-hands.dev>
1 parent 952c17e commit 3abc11c

1 file changed

Lines changed: 5 additions & 12 deletions

File tree

.github/workflows/run-eval.yml

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ on:
6262
type: string
6363
instance_ids:
6464
description: >-
65-
Comma-separated instance IDs to evaluate (no spaces).
65+
Comma-separated instance IDs to evaluate.
6666
Example: "django__django-11583,django__django-12345".
67+
Spaces around commas are automatically stripped.
6768
Leave empty to evaluate all instances up to eval_limit.
6869
required: false
6970
default: ''
@@ -191,17 +192,6 @@ jobs:
191192
exit 1
192193
fi
193194
194-
- name: Validate instance_ids (no spaces allowed)
195-
if: github.event_name == 'workflow_dispatch' && github.event.inputs.instance_ids != ''
196-
run: |
197-
INSTANCE_IDS="${{ github.event.inputs.instance_ids }}"
198-
if [[ "$INSTANCE_IDS" =~ [[:space:]] ]]; then
199-
echo "::error::instance_ids must not contain spaces. Use comma-separated values without spaces."
200-
echo "Got: '$INSTANCE_IDS'"
201-
echo "Example: 'django__django-11583,django__django-12345'"
202-
exit 1
203-
fi
204-
205195
- name: Validate SDK reference (semantic version check)
206196
if: github.event_name == 'workflow_dispatch'
207197
env:
@@ -344,6 +334,9 @@ jobs:
344334
AGENT_TYPE: ${{ github.event.inputs.agent_type || 'default' }}
345335
TRIGGERED_BY: ${{ github.actor }}
346336
run: |
337+
# Normalize instance_ids: strip all spaces
338+
INSTANCE_IDS=$(printf '%s' "$INSTANCE_IDS" | tr -d ' ')
339+
347340
echo "Dispatching evaluation workflow with SDK commit: $SDK_SHA (benchmark: $BENCHMARK, eval branch: $EVAL_BRANCH, benchmarks branch: $BENCHMARKS_BRANCH, tool preset: $TOOL_PRESET)"
348341
PAYLOAD=$(jq -n \
349342
--arg sdk "$SDK_SHA" \

0 commit comments

Comments
 (0)