refactor: remove dead load_marketplace_skill_names, log Plugin.load failures

load_marketplace_skill_names lost its only production caller when
the previous commit switched load_public_skills to use
_load_marketplace_object directly. Remove it and its 4 tests.

Replace the silent 'except Exception: pass' in the remote fetch
path with a logger.debug so Plugin.load failures are visible when
debugging.

Co-authored-by: openhands <openhands@all-hands.dev>

Author: csmith49

openhands-sdk/openhands/sdk/context/skills/skill.py

@@ -900,32 +900,6 @@ def load_project_skills(work_dir: str | Path) -> list[Skill]:
 DEFAULT_MARKETPLACE_PATH = "marketplaces/default.json"
 
 
-def load_marketplace_skill_names(
-    repo_path: Path, marketplace_path: str
-) -> set[str] | None:
-    """Load the list of skill names from a marketplace manifest file.
-
-    Uses the existing Marketplace model from openhands.sdk.plugin to parse
-    the marketplace JSON file and extract plugin names.
-
-    Args:
-        repo_path: Path to the local repository.
-        marketplace_path: Relative path to the marketplace JSON file within the repo.
-
-    Returns:
-        Set of skill names to load, or None if marketplace file not found or invalid.
-    """
-    marketplace = _load_marketplace_object(repo_path, marketplace_path)
-    if marketplace is None:
-        return None
-
-    skill_names = {plugin.name for plugin in marketplace.plugins}
-    logger.debug(
-        f"Loaded {len(skill_names)} skill names from marketplace: {marketplace_path}"
-    )
-    return skill_names
-
-
 def _load_marketplace_object(
     repo_path: Path, marketplace_path: str
 ) -> "Marketplace | None":
@@ -1045,8 +1019,12 @@ def _resolve_plugin_skills(
             skills = plugin.get_all_skills()
             if skills:
                 return skills
-        except Exception:
-            pass
+        except Exception as e:
+            logger.debug(
+                "Plugin.load failed for '%s', trying raw directory: %s",
+                plugin_entry.name,
+                e,
+            )
         return _load_skills_from_resolved_path(plugin_path)
 
     # Local source: try to load from the resolved path

tests/sdk/context/skill/test_load_public_skills.py

@@ -12,7 +12,6 @@
     Skill,
     load_public_skills,
 )
-from openhands.sdk.context.skills.skill import load_marketplace_skill_names
 from openhands.sdk.context.skills.utils import update_skills_repository
 
 
@@ -674,49 +673,6 @@ def mock_repo_with_marketplace(tmp_path):
     return repo_dir
 
 
-def test_load_marketplace_skill_names_returns_skill_names(mock_repo_with_marketplace):
-    """Test that load_marketplace_skill_names correctly extracts skill names."""
-    skill_names = load_marketplace_skill_names(
-        mock_repo_with_marketplace, "marketplaces/default.json"
-    )
-
-    assert skill_names is not None
-    assert skill_names == {"git", "docker"}
-
-
-def test_load_marketplace_skill_names_returns_none_when_file_missing(tmp_path):
-    """Test that load_marketplace_skill_names returns None when file doesn't exist."""
-    repo_dir = tmp_path / "repo"
-    repo_dir.mkdir()
-
-    result = load_marketplace_skill_names(repo_dir, "marketplaces/default.json")
-    assert result is None
-
-
-def test_load_marketplace_skill_names_returns_none_for_invalid_json(tmp_path):
-    """Test that load_marketplace_skill_names handles invalid JSON gracefully."""
-    repo_dir = tmp_path / "repo"
-    repo_dir.mkdir()
-    marketplaces_dir = repo_dir / "marketplaces"
-    marketplaces_dir.mkdir()
-    (marketplaces_dir / "default.json").write_text("{ invalid json }")
-
-    result = load_marketplace_skill_names(repo_dir, "marketplaces/default.json")
-    assert result is None
-
-
-def test_load_marketplace_skill_names_returns_none_for_missing_plugins(tmp_path):
-    """Test that load_marketplace_skill_names handles missing plugins key."""
-    repo_dir = tmp_path / "repo"
-    repo_dir.mkdir()
-    marketplaces_dir = repo_dir / "marketplaces"
-    marketplaces_dir.mkdir()
-    (marketplaces_dir / "default.json").write_text(json.dumps({"name": "test"}))
-
-    result = load_marketplace_skill_names(repo_dir, "marketplaces/default.json")
-    assert result is None
-
-
 def test_load_public_skills_filters_by_marketplace(
     mock_repo_with_marketplace, tmp_path
 ):