fix: validate providers only when litellm provider registry is available

Co-authored-by: openhands <openhands@all-hands.dev>

Author: enyst

openhands-sdk/openhands/sdk/llm/utils/unverified_models.py

@@ -111,6 +111,10 @@ def _get_litellm_provider_names() -> set[str]:
 _LITELLM_PROVIDER_NAMES = _get_litellm_provider_names()
 
 
+def _has_provider_registry() -> bool:
+    return bool(_LITELLM_PROVIDER_NAMES)
+
+
 def _extract_model_and_provider(model: str) -> tuple[str, str, str]:
     """Extract provider and model information from a model identifier.
 
@@ -147,7 +151,10 @@ def _extract_model_and_provider(model: str) -> tuple[str, str, str]:
     provider = split[0]
     model_id = separator.join(split[1:])
 
-    if provider not in _LITELLM_PROVIDER_NAMES:
+    # If we have a provider registry, only accept known LiteLLM providers.
+    # If not, fall back to the historical behavior to avoid dropping all
+    # provider groupings in older LiteLLM versions.
+    if _has_provider_registry() and provider not in _LITELLM_PROVIDER_NAMES:
         return "", model, ""
 
     return provider, model_id, separator

tests/sdk/llm/test_model_list.py

@@ -49,9 +49,9 @@ def test_unverified_models_fallback_when_no_provider_list():
         "openai/gpt-4o",  # treated as unverified (provider validation disabled)
         "anthropic/claude-sonnet-4-20250514",  # treated as unverified
         "o3",  # openhands model -> excluded
-        "custom-provider/custom-model",  # invalid provider -> bucketed under "other"
-        "us.anthropic.claude-3-5-sonnet-20241022-v2:0",  # invalid provider prefix
-        "1024-x-1024/gpt-image-1.5",  # invalid provider prefix
+        "custom-provider/custom-model",
+        "us.anthropic.claude-3-5-sonnet-20241022-v2:0",
+        "1024-x-1024/gpt-image-1.5",
     ]
 
     with (
@@ -66,10 +66,17 @@ def test_unverified_models_fallback_when_no_provider_list():
     ):
         result = get_unverified_models()
 
+    # Without provider validation, openai/anthropic entries are treated as
+    # verified and therefore are excluded from the unverified mapping.
     assert "openai" not in result
     assert "anthropic" not in result
+
+    # When LiteLLM doesn't expose a provider registry, we keep historical behavior
+    # (split on '/' or '.') rather than bucketing everything under "other".
     assert result == {
-        "other": ["openai/gpt-4o", "anthropic/claude-sonnet-4-20250514"] + models[3:]
+        "custom-provider": ["custom-model"],
+        "us": ["anthropic.claude-3-5-sonnet-20241022-v2:0"],
+        "1024-x-1024": ["gpt-image-1.5"],
     }