Skip to content

Commit 98db65c

Browse files
author
Debug Agent
committed
fix(sdk): drop unreachable depends_on=("acp_server",) on acp_command
The frontend's ``depends_on`` filter evaluates each dependency as a boolean (``values[dep] === true``). That works for real booleans (e.g. ``condenser.enabled``) but evaluates to false for the string-valued ``acp_server``, hiding ``acp_command`` outright — even in the "all" view of the ACP Server page — so the ``acp_server=custom`` workflow was unreachable from the GUI. Drop the bogus metadata and rely on prominence + view filtering. The field remains MINOR (visible in the "all" view). No behavior change for CLI / API callers.
1 parent e4c3b95 commit 98db65c

File tree

1 file changed

+5
-1
lines changed
  • openhands-sdk/openhands/sdk/settings

1 file changed

+5
-1
lines changed

openhands-sdk/openhands/sdk/settings/model.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,10 +726,14 @@ class ACPAgentSettings(BaseModel):
726726
"Must be set when :attr:`acp_server` is ``'custom'``."
727727
),
728728
json_schema_extra={
729+
# Deliberately no ``depends_on=("acp_server",)``: the frontend's
730+
# ``depends_on`` filter does a boolean check, which would evaluate
731+
# to false for the string-valued ``acp_server`` and hide the
732+
# field outright. Users see ``acp_command`` in the "all" view of
733+
# the ACP Server page if they need to supply a custom command.
729734
SETTINGS_METADATA_KEY: SettingsFieldMetadata(
730735
label="ACP command (custom override)",
731736
prominence=SettingProminence.MINOR,
732-
depends_on=("acp_server",),
733737
).model_dump(),
734738
SETTINGS_SECTION_METADATA_KEY: SettingsSectionMetadata(
735739
key="acp",

0 commit comments

Comments
 (0)