fix(sdk): keep deprecated verification accessors

Co-authored-by: openhands <openhands@all-hands.dev>

Author: openhands-agent

openhands-sdk/openhands/sdk/settings/model.py

@@ -9,6 +9,7 @@
 from pydantic import (
     BaseModel,
     Field,
+    PrivateAttr,
     SecretStr,
     field_serializer,
     field_validator,
@@ -18,6 +19,7 @@
 from openhands.sdk.context.agent_context import AgentContext
 from openhands.sdk.llm import LLM
 from openhands.sdk.tool import Tool
+from openhands.sdk.utils.deprecation import warn_deprecated
 
 from .metadata import (
     SETTINGS_METADATA_KEY,
@@ -107,6 +109,9 @@ class CondenserSettings(BaseModel):
 class VerificationSettings(BaseModel):
     """Critic and iterative-refinement settings for the agent."""
 
+    _deprecated_confirmation_mode: bool = PrivateAttr(default=False)
+    _deprecated_security_analyzer: str | None = PrivateAttr(default=None)
+
     # -- Critic --
     critic_enabled: bool = Field(
         default=False,
@@ -197,6 +202,64 @@ class VerificationSettings(BaseModel):
         },
     )
 
+    @property
+    def confirmation_mode(self) -> bool:
+        warn_deprecated(
+            "VerificationSettings.confirmation_mode",
+            deprecated_in="1.16.1",
+            removed_in="1.18.0",
+            details=(
+                "Use ConversationSettings.confirmation_mode; "
+                "verification settings no longer serialize "
+                "conversation approval controls."
+            ),
+        )
+        return self._deprecated_confirmation_mode
+
+    @confirmation_mode.setter
+    def confirmation_mode(self, value: bool) -> None:
+        warn_deprecated(
+            "VerificationSettings.confirmation_mode",
+            deprecated_in="1.16.1",
+            removed_in="1.18.0",
+            details=(
+                "Use ConversationSettings.confirmation_mode; "
+                "verification settings no longer serialize "
+                "conversation approval controls."
+            ),
+            stacklevel=3,
+        )
+        self._deprecated_confirmation_mode = value
+
+    @property
+    def security_analyzer(self) -> str | None:
+        warn_deprecated(
+            "VerificationSettings.security_analyzer",
+            deprecated_in="1.16.1",
+            removed_in="1.18.0",
+            details=(
+                "Use ConversationSettings.security_analyzer; "
+                "verification settings no longer serialize "
+                "conversation security controls."
+            ),
+        )
+        return self._deprecated_security_analyzer
+
+    @security_analyzer.setter
+    def security_analyzer(self, value: str | None) -> None:
+        warn_deprecated(
+            "VerificationSettings.security_analyzer",
+            deprecated_in="1.16.1",
+            removed_in="1.18.0",
+            details=(
+                "Use ConversationSettings.security_analyzer; "
+                "verification settings no longer serialize "
+                "conversation security controls."
+            ),
+            stacklevel=3,
+        )
+        self._deprecated_security_analyzer = value
+
 
 def _default_llm_settings() -> LLM:
     model = LLM.model_fields["model"].get_default()

tests/sdk/test_settings.py

@@ -1,3 +1,4 @@
+import pytest
 from fastmcp.mcp_config import MCPConfig
 from pydantic import SecretStr
 
@@ -144,6 +145,28 @@ def test_conversation_settings_export_schema_groups_sections() -> None:
     assert verification_fields["security_analyzer"].depends_on == ["confirmation_mode"]
 
 
+def test_verification_settings_legacy_controls_remain_deprecated_accessors() -> None:
+    settings = VerificationSettings()
+
+    with pytest.deprecated_call():
+        assert settings.confirmation_mode is False
+    with pytest.deprecated_call():
+        settings.confirmation_mode = True
+    with pytest.deprecated_call():
+        assert settings.confirmation_mode is True
+
+    with pytest.deprecated_call():
+        assert settings.security_analyzer is None
+    with pytest.deprecated_call():
+        settings.security_analyzer = "llm"
+    with pytest.deprecated_call():
+        assert settings.security_analyzer == "llm"
+
+    dumped = settings.model_dump(mode="json")
+    assert "confirmation_mode" not in dumped
+    assert "security_analyzer" not in dumped
+
+
 def test_conversation_settings_model_dump_roundtrip() -> None:
     settings = ConversationSettings(
         max_iterations=42,