Commit c67c450
committed
fix: Disable browser tools in integration tests to fix ProcessPoolExecutor hang
Browser tools (BrowserToolSet) cause integration tests to hang indefinitely
when running with ProcessPoolExecutor. The browser cleanup during atexit
handlers in worker processes doesn't complete properly, causing the executor
to wait forever for workers to exit.
This was introduced in PR #2077 which changed tests to use get_tools_for_preset()
with enable_browser=True. Previously, tests manually specified only TerminalTool
and FileEditorTool without browser tools.
Fixes #2124
Co-authored-by: openhands <openhands@all-hands.dev>1 parent 795e20d commit c67c450
File tree
3 files changed
+14
-18
lines changed- tests/integration
- tests
3 files changed
+14
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
| 103 | + | |
| 104 | + | |
108 | 105 | | |
109 | 106 | | |
110 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 25 | + | |
| 26 | + | |
30 | 27 | | |
31 | 28 | | |
32 | 29 | | |
| |||
0 commit comments