|
| 1 | +"""Tests for the GET /conversations/{id}/agent_final_response endpoint.""" |
| 2 | + |
| 3 | +from pathlib import Path |
| 4 | +from unittest.mock import AsyncMock, MagicMock |
| 5 | +from uuid import uuid4 |
| 6 | + |
| 7 | +import pytest |
| 8 | +from fastapi import FastAPI |
| 9 | +from fastapi.testclient import TestClient |
| 10 | + |
| 11 | +from openhands.agent_server.conversation_router import conversation_router |
| 12 | +from openhands.agent_server.conversation_service import ConversationService |
| 13 | +from openhands.agent_server.dependencies import get_conversation_service |
| 14 | +from openhands.agent_server.event_service import EventService |
| 15 | +from openhands.sdk import Message |
| 16 | +from openhands.sdk.event import ActionEvent, MessageEvent |
| 17 | +from openhands.sdk.llm import MessageToolCall, TextContent |
| 18 | +from openhands.sdk.tool.builtins.finish import FinishAction |
| 19 | + |
| 20 | + |
| 21 | +@pytest.fixture |
| 22 | +def client(): |
| 23 | + app = FastAPI() |
| 24 | + app.include_router(conversation_router, prefix="/api") |
| 25 | + return TestClient(app) |
| 26 | + |
| 27 | + |
| 28 | +@pytest.fixture |
| 29 | +def sample_conversation_id(): |
| 30 | + return uuid4() |
| 31 | + |
| 32 | + |
| 33 | +@pytest.fixture |
| 34 | +def mock_conversation_service(): |
| 35 | + return AsyncMock(spec=ConversationService) |
| 36 | + |
| 37 | + |
| 38 | +@pytest.fixture |
| 39 | +def mock_event_service(): |
| 40 | + return AsyncMock(spec=EventService) |
| 41 | + |
| 42 | + |
| 43 | +def test_get_response_with_finish_action( |
| 44 | + client, mock_conversation_service, mock_event_service, sample_conversation_id |
| 45 | +): |
| 46 | + """Endpoint returns FinishAction message text.""" |
| 47 | + mock_conversation_service.get_event_service.return_value = mock_event_service |
| 48 | + mock_event_service.get_agent_final_response.return_value = ( |
| 49 | + "Task completed successfully!" |
| 50 | + ) |
| 51 | + |
| 52 | + client.app.dependency_overrides[get_conversation_service] = ( |
| 53 | + lambda: mock_conversation_service |
| 54 | + ) |
| 55 | + |
| 56 | + try: |
| 57 | + response = client.get( |
| 58 | + f"/api/conversations/{sample_conversation_id}/agent_final_response" |
| 59 | + ) |
| 60 | + |
| 61 | + assert response.status_code == 200 |
| 62 | + data = response.json() |
| 63 | + assert data["response"] == "Task completed successfully!" |
| 64 | + mock_conversation_service.get_event_service.assert_called_once_with( |
| 65 | + sample_conversation_id |
| 66 | + ) |
| 67 | + mock_event_service.get_agent_final_response.assert_called_once() |
| 68 | + finally: |
| 69 | + client.app.dependency_overrides.clear() |
| 70 | + |
| 71 | + |
| 72 | +def test_get_response_empty_when_no_agent_events( |
| 73 | + client, mock_conversation_service, mock_event_service, sample_conversation_id |
| 74 | +): |
| 75 | + """Endpoint returns empty string when no agent response exists.""" |
| 76 | + mock_conversation_service.get_event_service.return_value = mock_event_service |
| 77 | + mock_event_service.get_agent_final_response.return_value = "" |
| 78 | + |
| 79 | + client.app.dependency_overrides[get_conversation_service] = ( |
| 80 | + lambda: mock_conversation_service |
| 81 | + ) |
| 82 | + |
| 83 | + try: |
| 84 | + response = client.get( |
| 85 | + f"/api/conversations/{sample_conversation_id}/agent_final_response" |
| 86 | + ) |
| 87 | + |
| 88 | + assert response.status_code == 200 |
| 89 | + data = response.json() |
| 90 | + assert data["response"] == "" |
| 91 | + finally: |
| 92 | + client.app.dependency_overrides.clear() |
| 93 | + |
| 94 | + |
| 95 | +def test_get_response_conversation_not_found( |
| 96 | + client, mock_conversation_service, sample_conversation_id |
| 97 | +): |
| 98 | + """Endpoint returns 404 when conversation does not exist.""" |
| 99 | + mock_conversation_service.get_event_service.return_value = None |
| 100 | + |
| 101 | + client.app.dependency_overrides[get_conversation_service] = ( |
| 102 | + lambda: mock_conversation_service |
| 103 | + ) |
| 104 | + |
| 105 | + try: |
| 106 | + response = client.get( |
| 107 | + f"/api/conversations/{sample_conversation_id}/agent_final_response" |
| 108 | + ) |
| 109 | + assert response.status_code == 404 |
| 110 | + finally: |
| 111 | + client.app.dependency_overrides.clear() |
| 112 | + |
| 113 | + |
| 114 | +def test_event_service_get_agent_final_response_with_finish(): |
| 115 | + """EventService delegates to get_agent_final_response from SDK.""" |
| 116 | + event_service = EventService(stored=MagicMock(), conversations_dir=Path("test_dir")) |
| 117 | + |
| 118 | + finish_action = FinishAction(message="Done!") |
| 119 | + tool_call = MessageToolCall( |
| 120 | + id="tc1", name="finish", arguments="{}", origin="completion" |
| 121 | + ) |
| 122 | + action_event = ActionEvent( |
| 123 | + source="agent", |
| 124 | + thought=[TextContent(text="Finishing")], |
| 125 | + action=finish_action, |
| 126 | + tool_name="finish", |
| 127 | + tool_call_id="tc1", |
| 128 | + tool_call=tool_call, |
| 129 | + llm_response_id="resp1", |
| 130 | + ) |
| 131 | + |
| 132 | + conversation = MagicMock() |
| 133 | + state = MagicMock() |
| 134 | + state.events = [action_event] |
| 135 | + conversation._state = state |
| 136 | + event_service._conversation = conversation |
| 137 | + |
| 138 | + result = event_service._get_agent_final_response_sync() |
| 139 | + assert result == "Done!" |
| 140 | + |
| 141 | + |
| 142 | +def test_event_service_get_agent_final_response_with_message(): |
| 143 | + """EventService returns MessageEvent text when no FinishAction.""" |
| 144 | + event_service = EventService(stored=MagicMock(), conversations_dir=Path("test_dir")) |
| 145 | + |
| 146 | + message_event = MessageEvent( |
| 147 | + source="agent", |
| 148 | + llm_message=Message( |
| 149 | + role="assistant", |
| 150 | + content=[TextContent(text="Here is my answer")], |
| 151 | + ), |
| 152 | + ) |
| 153 | + |
| 154 | + conversation = MagicMock() |
| 155 | + state = MagicMock() |
| 156 | + state.events = [message_event] |
| 157 | + conversation._state = state |
| 158 | + event_service._conversation = conversation |
| 159 | + |
| 160 | + result = event_service._get_agent_final_response_sync() |
| 161 | + assert result == "Here is my answer" |
| 162 | + |
| 163 | + |
| 164 | +def test_event_service_get_agent_final_response_empty(): |
| 165 | + """EventService returns empty string with no agent events.""" |
| 166 | + event_service = EventService(stored=MagicMock(), conversations_dir=Path("test_dir")) |
| 167 | + |
| 168 | + conversation = MagicMock() |
| 169 | + state = MagicMock() |
| 170 | + state.events = [] |
| 171 | + conversation._state = state |
| 172 | + event_service._conversation = conversation |
| 173 | + |
| 174 | + result = event_service._get_agent_final_response_sync() |
| 175 | + assert result == "" |
| 176 | + |
| 177 | + |
| 178 | +def test_event_service_get_agent_final_response_inactive(): |
| 179 | + """EventService raises ValueError when service is inactive.""" |
| 180 | + event_service = EventService(stored=MagicMock(), conversations_dir=Path("test_dir")) |
| 181 | + |
| 182 | + with pytest.raises(ValueError, match="inactive_service"): |
| 183 | + event_service._get_agent_final_response_sync() |
0 commit comments