Commit fcfb0fa
committed
chore: Address review feedback - minor improvements
- Fix empty string check in get_all_secrets() to use 'is not None'
instead of truthy check (allows empty string secrets)
- Add explicit expand_defaults=True in loader.py for clarity
- Improve logging to indicate when defaults are applied without secrets
Co-authored-by: openhands <openhands@all-hands.dev>1 parent 055e09f commit fcfb0fa
File tree
3 files changed
+6
-2
lines changed- openhands-sdk/openhands/sdk
- conversation
- impl
- plugin
3 files changed
+6
-2
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
| 391 | + | |
| 392 | + | |
391 | 393 | | |
392 | 394 | | |
393 | 395 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
| 150 | + | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
109 | 111 | | |
110 | 112 | | |
111 | 113 | | |
| |||
0 commit comments