Comments

drwmrrs · drwmrrs · commit 3604396c546d · 2025-02-10T17:37:50.000+11:00
diff --git a/src/jose.c b/src/jose.c
@@ -2276,6 +2276,7 @@ oauth2_jose_jwks_aws_alb_resolve(oauth2_log_t *log,
     }
 
     // TODO - determine if theres a better place for this?
+    // TODO - maybe needed? timing safe compare?
     if (strcmp(signer, provider->alb_arn) != 0) {
         oauth2_error(log, "signer does not match configured ARN: signer=%s, arn=%s", signer, provider->alb_arn);
         return NULL;

Original file line number	Diff line number	Diff line change
`@@ -2276,6 +2276,7 @@ oauth2_jose_jwks_aws_alb_resolve(oauth2_log_t *log,`
`2276`	`2276`	`}`
`2277`	`2277`
`2278`	`2278`	`// TODO - determine if theres a better place for this?`
	`2279`	`+ // TODO - maybe needed? timing safe compare?`
`2279`	`2280`	`if (strcmp(signer, provider->alb_arn) != 0) {`
`2280`	`2281`	`oauth2_error(log, "signer does not match configured ARN: signer=%s, arn=%s", signer, provider->alb_arn);`
`2281`	`2282`	`return NULL;`