revise cmd_parms setup

Signed-off-by: Hans Zandbelt <[email protected]>

Author: zandbelt

test/helper.h

@@ -55,5 +55,6 @@ void oidc_test_teardown(void);
 int oidc_test_suite_run(Suite *s);
 apr_pool_t *oidc_test_pool_get();
 request_rec *oidc_test_request_get();
+cmd_parms *oidc_test_cmd_get(const char *primitive);
 
 #endif // _MOD_AUTH_OPENIDC_TEST_COMMON_H_

test/test_cfg.c

@@ -44,36 +44,28 @@
 #include "cfg/provider.h"
 #include "helper.h"
 
-#include <http_config.h>
-
-static cmd_parms cmd = {};
-
 // provider
 
 START_TEST(test_cmd_provider_token_endpoint_auth_set) {
 	void *ptr = NULL;
 	const char *arg = NULL;
 	const char *rv = NULL;
-
-	cmd.server = oidc_test_request_get()->server;
-	cmd.pool = oidc_test_request_get()->pool;
-	cmd.directive = apr_pcalloc(cmd.pool, sizeof(ap_directive_t));
-	cmd.directive->directive = OIDCProviderTokenEndpointAuth;
+	cmd_parms *cmd = oidc_test_cmd_get(OIDCProviderTokenEndpointAuth);
 
 	arg = "private_key_jwt";
-	rv = oidc_cmd_provider_token_endpoint_auth_set(&cmd, ptr, arg);
+	rv = oidc_cmd_provider_token_endpoint_auth_set(cmd, ptr, arg);
 	ck_assert_msg(rv == NULL, "failed: %s", rv);
 
 	arg = "private_key_jws";
-	rv = oidc_cmd_provider_token_endpoint_auth_set(&cmd, ptr, arg);
+	rv = oidc_cmd_provider_token_endpoint_auth_set(cmd, ptr, arg);
 	ck_assert_msg(rv != NULL, "should have failed");
 
 	arg = "private_key_jwt:RS256";
-	rv = oidc_cmd_provider_token_endpoint_auth_set(&cmd, ptr, arg);
+	rv = oidc_cmd_provider_token_endpoint_auth_set(cmd, ptr, arg);
 	ck_assert_msg(rv == NULL, "failed: %s", rv);
 
 	arg = "private_key_jwt:RA256";
-	rv = oidc_cmd_provider_token_endpoint_auth_set(&cmd, ptr, arg);
+	rv = oidc_cmd_provider_token_endpoint_auth_set(cmd, ptr, arg);
 	ck_assert_msg(rv != NULL, "should have failed");
 }
 END_TEST