remove useless jwt variable check before destroying on error

zandbelt · zandbelt · commit 3e7c3519764f · 2024-12-13T20:02:16.000+01:00
Signed-off-by: Hans Zandbelt &lt;hans.zandbelt@openidc.com&gt;
diff --git a/src/metadata.c b/src/metadata.c
@@ -657,8 +657,7 @@ static apr_byte_t oidc_metadata_jwks_retrieve_and_cache(request_rec *r, oidc_cfg
 
 		if (oidc_jwt_verify(r->pool, jwt, keys, &err) == FALSE) {
 			oidc_error(r, "verifying JWT failed: %s", oidc_jose_e2s(r->pool, err));
-			if (jwt != NULL)
-				oidc_jwt_destroy(jwt);
+			oidc_jwt_destroy(jwt);
 			return FALSE;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -657,8 +657,7 @@ static apr_byte_t oidc_metadata_jwks_retrieve_and_cache(request_rec *r, oidc_cfg`
`657`	`657`
`658`	`658`	`if (oidc_jwt_verify(r->pool, jwt, keys, &err) == FALSE) {`
`659`	`659`	`oidc_error(r, "verifying JWT failed: %s", oidc_jose_e2s(r->pool, err));`
`660`		`- if (jwt != NULL)`
`661`		`- oidc_jwt_destroy(jwt);`
	`660`	`+ oidc_jwt_destroy(jwt);`
`662`	`661`	`return FALSE;`
`663`	`662`	`}`
`664`	`663`