metadata: rewrite double-free fix

Signed-off-by: Hans Zandbelt <[email protected]>

Author: zandbelt

src/metadata.c

@@ -753,6 +753,8 @@ apr_byte_t oidc_metadata_provider_retrieve(request_rec *r, oidc_cfg_t *cfg, cons
 
 	/* check to see if it is valid metadata */
 	if (oidc_metadata_provider_is_valid(r, cfg, *j_metadata, issuer) == FALSE) {
+		json_decref(*j_metadata);
+		*j_metadata = NULL;
 		return FALSE;
 	}
 

src/mod_auth_openidc.c

@@ -215,6 +215,7 @@ static apr_byte_t oidc_provider_validate_metadata_str(request_rec *r, oidc_cfg_t
 		oidc_warn(r, "cache corruption detected: invalid metadata from url: %s",
 			  oidc_cfg_provider_metadata_url_get(oidc_cfg_provider_get(c)));
 		json_decref(*j_provider);
+		*j_provider = NULL;
 		return FALSE;
 	}