code: avoid more warnings (empty functions, cast)

Signed-off-by: Hans Zandbelt <[email protected]>

Author: zandbelt

src/util.c

@@ -1657,6 +1657,9 @@ apr_hash_t *oidc_util_spaced_string_to_hashtable(apr_pool_t *pool, const char *s
  */
 apr_byte_t oidc_util_spaced_string_equals(apr_pool_t *pool, const char *a, const char *b) {
 
+	const void *k = NULL;
+	void *v = NULL;
+
 	/* parse both entries as hash tables */
 	apr_hash_t *ht_a = oidc_util_spaced_string_to_hashtable(pool, a);
 	apr_hash_t *ht_b = oidc_util_spaced_string_to_hashtable(pool, b);
@@ -1668,9 +1671,7 @@ apr_byte_t oidc_util_spaced_string_equals(apr_pool_t *pool, const char *a, const
 	/* then loop over all entries */
 	apr_hash_index_t *hi;
 	for (hi = apr_hash_first(NULL, ht_a); hi; hi = apr_hash_next(hi)) {
-		const char *k;
-		const char *v;
-		apr_hash_this(hi, (const void **)&k, NULL, (void **)&v);
+		apr_hash_this(hi, &k, NULL, &v);
 		if (apr_hash_get(ht_b, k, APR_HASH_KEY_STRING) == NULL)
 			return FALSE;
 	}

test/stub.c

@@ -18,6 +18,7 @@
 AP_DECLARE(void)
 ap_hook_check_authn(ap_HOOK_check_user_id_t *pf, const char *const *aszPre, const char *const *aszSucc, int nOrder,
 		    int type) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE(apr_status_t)
@@ -142,25 +143,30 @@ AP_DECLARE(int) ap_hook_auth_checker(request_rec *r) {
 
 AP_DECLARE(void)
 ap_hook_fixups(int (*handler)(request_rec *r), const char *const *aszPre, const char *const *aszSucc, int nOrder) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE(void)
 ap_hook_insert_filter(void (*insert_filter)(request_rec *r), const char *const *aszPre, const char *const *aszSucc,
 		      int nOrder) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE(void)
 ap_hook_post_config(int (*post_config)(apr_pool_t *pool, apr_pool_t *p1, apr_pool_t *p2, server_rec *s),
 		    const char *const *aszPre, const char *const *aszSucc, int nOrder) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE(void)
 ap_hook_child_init(void (*child_init)(apr_pool_t *p, server_rec *s), const char *const *aszPre,
 		   const char *const *aszSucc, int nOrder) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE(void)
 ap_hook_handler(int (*handler)(request_rec *r), const char *const *aszPre, const char *const *aszSucc, int nOrder) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE(int) ap_is_initial_req(request_rec *r) {
@@ -219,6 +225,7 @@ ap_log_rerror(const char *file, int line, int level, apr_status_t status, const
 }
 
 AP_DECLARE(void) ap_note_auth_failure(request_rec *r) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE(apr_status_t) ap_pass_brigade(ap_filter_t *filter, apr_bucket_brigade *bucket) {
@@ -236,14 +243,14 @@ const char *ap_run_http_scheme(const request_rec *r) {
 }
 
 AP_DECLARE(void) ap_set_content_type(request_rec *r, const char *ct) {
+	// comment explaining why the method is empty
 }
 
 AP_DECLARE_NONSTD(const char *) ap_set_flag_slot(cmd_parms *cmd, void *struct_ptr, int arg) {
 	return "";
 }
 
 AP_DECLARE_NONSTD(const char *) ap_set_string_slot(cmd_parms *cmd, void *struct_ptr, const char *arg) {
-
 	return "";
 }