metadata: fix parsing the OPs token_endpoint_auth_methods_supported

zandbelt · zandbelt · commit e5fba2370e50 · 2025-04-19T11:34:03.000+02:00
and avoid the log error:
  oidc_metadata_provider_parse: oidc_provider_token_endpoint_auth_set:
invalid value
and falling back to client_secret_basic after that; thanks François
Kooman; bump to 2.4.17rc2

Signed-off-by: Hans Zandbelt &lt;hans.zandbelt@openidc.com&gt;
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,9 @@
+04/19/2025
+- metadata: fix parsing the OPs `token_endpoint_auth_methods_supported` and avoid the log error:
+    oidc_metadata_provider_parse: oidc_provider_token_endpoint_auth_set: invalid value
+  and falling back to client_secret_basic after that; thanks François Kooman
+- bump to 2.4.17rc2
+
 04/17/2025
 - bump to 2.4.17rc1
 
diff --git a/configure.ac b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT([mod_auth_openidc],[2.4.17rc1],[hans.zandbelt@openidc.com])
+AC_INIT([mod_auth_openidc],[2.4.17rc2],[hans.zandbelt@openidc.com])
 
 AC_SUBST(NAMEVER, AC_PACKAGE_TARNAME()-AC_PACKAGE_VERSION())
 
diff --git a/src/metadata.c b/src/metadata.c
@@ -252,6 +252,7 @@ static const char *oidc_metadata_valid_string_in_array(apr_pool_t *pool, json_t
 						       oidc_valid_function_t valid_function, char **value,
 						       apr_byte_t optional, const char *preference) {
 	int i = 0;
+	if (value) *value = NULL;
 	json_t *json_arr = json_object_get(json, key);
 	apr_byte_t found = FALSE;
 	if ((json_arr != NULL) && (json_is_array(json_arr))) {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-AC_INIT([mod_auth_openidc],[2.4.17rc1],[[email protected]])`
	`1`	`+AC_INIT([mod_auth_openidc],[2.4.17rc2],[[email protected]])`
`2`	`2`
`3`	`3`	`AC_SUBST(NAMEVER, AC_PACKAGE_TARNAME()-AC_PACKAGE_VERSION())`
`4`	`4`