Skip to content

Commit 2e664e5

Browse files
🏗️🔧:fix what the port to Liquid broke
Four more, found by reading the built page rather than waiting to be told. The navbar offset sat on `main`, which has no background, so the body's parchment showed through it as a pale band between the dark navbar and the dark masthead. The masthead takes the room itself now. The logogram is an include, so it arrives with a viewBox and no width or height, and the class carrying its size had moved to the wrapper. It was falling back to the default 300x150. Its brand teal is set on the shapes themselves and clears only 4.14:1 against the ink, so the tint goes back over it. The focus ring was ink on ink. Over the masthead, which is where the links people are meant to follow live, there was nothing to see. The dark sections get a parchment ring. `wrap` is a common enough name to be taken by another page later, and the widths it reads are declared only on .home, so it is scoped. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
1 parent eb23829 commit 2e664e5

1 file changed

Lines changed: 35 additions & 3 deletions

File tree

_assets/styles/_home.scss

Lines changed: 35 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
// no such container, so it needs the room itself or the footer sits on top of
3232
// the last section.
3333
.home main {
34-
padding-top: var(--nav-h);
3534
padding-bottom: 104px;
3635
}
3736

@@ -61,16 +60,31 @@
6160
outline-offset: 2px;
6261
}
6362

64-
.wrap {
63+
// The masthead and the rail are ink, and so is the ring above, so it would be
64+
// invisible over exactly the section holding the links people are meant to
65+
// follow.
66+
.masthead :focus-visible,
67+
.sdk-rail :focus-visible {
68+
outline-color: var(--parchment);
69+
}
70+
71+
// `wrap` is a common enough name that another page could take it later and
72+
// silently inherit these, and the widths it reads are only declared on .home.
73+
.home .wrap {
6574
max-width: var(--wrap);
6675
padding-inline: var(--gutter);
6776
margin-inline: auto;
6877
}
6978

7079
/* --- Masthead ------------------------------------------------------ */
7180

81+
// The navbar is fixed, so the room for it is taken here rather than on
82+
// `main`. Padding on `main` would sit above this section and show the body's
83+
// parchment through it, putting a pale band between the dark navbar and the
84+
// dark masthead.
7285
.masthead {
73-
padding-block: clamp(2.5rem, 6vw, 4.5rem);
86+
padding-top: calc(var(--nav-h) + clamp(2.5rem, 6vw, 4.5rem));
87+
padding-bottom: clamp(2.5rem, 6vw, 4.5rem);
7488
color: var(--parchment);
7589
background-color: var(--ink);
7690
}
@@ -89,6 +103,24 @@
89103
margin-bottom: 1.25rem;
90104
}
91105

106+
// The logogram is an include, so it arrives without width or height and
107+
// would otherwise fall back to the default 300x150. Its brand teal is also
108+
// set on the shapes themselves, and only clears 4.14:1 against the ink here,
109+
// so the tint is put back over it.
110+
.masthead-mark svg {
111+
display: block;
112+
width: 100%;
113+
height: 100%;
114+
}
115+
116+
.masthead-mark circle {
117+
stroke: var(--primary-tint);
118+
}
119+
120+
.masthead-mark path {
121+
fill: var(--primary-tint);
122+
}
123+
92124
// _custom.scss makes every h1 a flex row and draws a rule after it, which is
93125
// right for a page heading and wrong for a sentence. This one is a sentence,
94126
// and as a flex container its words would lay out as siblings in a row.

0 commit comments

Comments
 (0)