Memory-safety related changes, fixes on string array looping

Author: wberube

.vscode/c_cpp_properties.json

@@ -49,16 +49,16 @@
         "compilerPath": "toolchain/toolchain.sigmastar-infinity6e/bin/arm-openipc-linux-gnueabihf-gcc",
         "cStandard": "c11"
       },{
-        "name": "armhf-uclibc",
+        "name": "armhf-musl",
         "includePath": ["${workspaceFolder}/**"],
         "defines": ["__arm__", "__ARM_PCS_VFP"],
-        "compilerPath": "toolchain/toolchain.rockchip-rv11xx/bin/arm-rockchip830-linux-uclibcgnueabihf-gcc",
+        "compilerPath": "toolchain/toolchain.sigmastar-infinity6/bin/arm-openipc-linux-musleabihf-gcc",
         "cStandard": "c11"
       },{
-        "name": "armhf-musl",
+        "name": "armhf-uclibc",
         "includePath": ["${workspaceFolder}/**"],
         "defines": ["__arm__", "__ARM_PCS_VFP"],
-        "compilerPath": "toolchain/toolchain.sigmastar-infinity6/bin/arm-openipc-linux-musleabihf-gcc",
+        "compilerPath": "toolchain/toolchain.rockchip-rv11xx/bin/arm-rockchip830-linux-uclibcgnueabihf-gcc",
         "cStandard": "c11"
       },{
         "name": "mips-musl",

README.md

@@ -33,7 +33,7 @@ In spite of these design choices, Divinus boasts numerous features that cater to
 | Hi3519V100[^10]         | ✔️           | ✔️           | ✔️          | ✔️          | ✔️                |
 | Hi3519AV100             | ✔️           | ✔️           | ✔️          | ✔️          | ✔️                |
 | Hi3559AV100             | ✔️           | ✔️           | ✔️          | ✔️          | ✔️                |
-| RV11xx[^11]             | ↻            | ↻            | ✔️          | ✔️          | ↻                 |
+| RV11xx[^11]             | ↻            | ✔️           | ✔️          | ✔️          | ↻                 |
 | T31 series              | ✔️           | ✔️           | ✔️          | ✔️          | ✔️                |
 | infinity3[^12]          | ↻            | ↻            | ↻           | ↻           | ↻                 |
 | infinity6[^13]          | ✔️           | ✔️           | ✔️          | ✔️          | ✔️                |

src/app_config.c

@@ -283,7 +283,7 @@ enum ConfigError parse_app_config(void) {
         goto RET_ERR;
     parse_param_value(&ini, "system", "time_format", timefmt);
     if (EMPTY(timefmt))
-        strcpy(timefmt, DEF_TIMEFMT);
+        strncpy(timefmt, DEF_TIMEFMT, sizeof(timefmt) - 1);
     parse_int(&ini, "system", "watchdog", 0, INT_MAX, &app_config.watchdog);
 
     err =

src/compat.c

@@ -55,17 +55,23 @@ float __expf_finite(float x) { return expf(x); }
 int __fgetc_unlocked(FILE *stream) { return fgetc(stream); }
 double __log_finite(double x) { return log(x); }
 
-#if !defined(__riscv) && !defined(__riscv__)
+#if !defined(__riscv) || !defined(__riscv__)
 void *mmap(void *start, size_t len, int prot, int flags, int fd, uint32_t off) {
     return (void*)syscall(SYS_mmap2, start, len, prot, flags, fd, off >> 12);
 }
 
+void *__mmap64(void *start, size_t len, int prot, int flags, int fd, off_t off) {
+    return (void*)syscall(SYS_mmap2, start, len, prot, flags, fd, off >> 12);
+}
 #if !(defined(__ARM_PCS_VFP) && defined(__UCLIBC__))
 void *mmap64(void *start, size_t len, int prot, int flags, int fd, off_t off) {
     return (void*)syscall(SYS_mmap2, start, len, prot, flags, fd, off >> 12);
 }
 #endif
 #else
+void *__mmap64(void *start, size_t len, int prot, int flags, int fd, off_t off) {
+    return (void*)syscall(SYS_mmap, start, len, prot, flags, fd, off);
+}
 void *mmap64(void *start, size_t len, int prot, int flags, int fd, off_t off) {
     return (void*)syscall(SYS_mmap, start, len, prot, flags, fd, off);
 }

src/hal/hisi/v1_hal.c

@@ -419,7 +419,7 @@ void v1_sensor_deinit(void)
 int v1_sensor_init(char *name, char *obj)
 {
     char path[128];
-    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s"};
+    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s", NULL};
     char **dir = dirs;
 
     while (*dir) {

src/hal/hisi/v2_hal.c

@@ -448,7 +448,7 @@ void v2_sensor_deinit(void)
 int v2_sensor_init(char *name, char *obj)
 {
     char path[128];
-    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s"};
+    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s", NULL};
     char **dir = dirs;
 
     while (*dir) {

src/hal/hisi/v3_hal.c

@@ -469,7 +469,7 @@ void v3_sensor_deinit(void)
 int v3_sensor_init(char *name, char *obj)
 {
     char path[128];
-    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s"};
+    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s", NULL};
     char **dir = dirs;
 
     while (*dir) {

src/hal/hisi/v4_hal.c

@@ -581,7 +581,7 @@ void v4_sensor_deinit(void)
 int v4_sensor_init(char *name, char *obj)
 {
     char path[128];
-    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s"};
+    char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s", NULL};
     char **dir = dirs;
 
     while (*dir) {

src/hal/plus/cvi_hal.c

@@ -491,7 +491,7 @@ int cvi_sensor_init(char *name, char *obj)
 {
     char path[128];
     char* dirs[] = {"%s", "./%s", "/usr/lib/sensors/%s", "/usr/lib/%s",
-        "/mnt/system/lib/%s", "/mnt/system/lib/libsns_full.so"};
+        "/mnt/system/lib/%s", "/mnt/system/lib/libsns_full.so", NULL};
     char **dir = dirs;
 
     while (*dir) {

src/hal/plus/rk_hal.c

@@ -419,7 +419,7 @@ int rk_sensor_find_v4l2_endpoint(void)
         fgets(line, 32, fp);
         fclose(fp);
 
-        if (!strncmp(line, "rkisp_mainpath", 14))
+        if (EQUALS(line, "rkisp_mainpath"))
         {
             index = i;
             break;