Merge PR #146 into main

Here are the SHA1 hashes for all of the added or renamed files between the current main as of the last rebase and the current HEAD of this PR.

$ git diff --name-only --diff-filter=AR d934af2 384682f | xargs sha1sum
a306167fdb88152403c8b00595b1502ffacd5b76  client/lib/commons-vfs2-2.10.0.jar
6e5d51a72d142f2d40a57dfb897188b36a95b489  client/lib/guava-32.0.1-jre.jar
7bf7ea75644ac064199e1e32c66ccd312239f2dc  client/lib/jetty-util-9.4.57.v20241219.jar
a306167fdb88152403c8b00595b1502ffacd5b76  command/lib/commons-vfs2-2.10.0.jar
6e5d51a72d142f2d40a57dfb897188b36a95b489  command/lib/guava-32.0.1-jre.jar
7bf7ea75644ac064199e1e32c66ccd312239f2dc  command/lib/jetty-util-9.4.57.v20241219.jar
b1bc0f47bcad26ad5f9bceefb63fcb920d868fca  donkey/lib/database/mysql-connector-j-8.4.0.jar
6e5d51a72d142f2d40a57dfb897188b36a95b489  donkey/lib/guava/guava-32.0.1-jre.jar
45cf516d9a23485200950549ff72b204c307fc9d  donkey/testlib/byte-buddy-1.14.13.jar
979ce25f7d3096a2e82214ba7dc972a05ce7a171  donkey/testlib/byte-buddy-agent-1.14.13.jar
31fd75d9d80e678032e5dc1bad17386f192853ea  donkey/testlib/mockito-core-5.1.1.jar
6e5d51a72d142f2d40a57dfb897188b36a95b489  manager/lib/guava-32.0.1-jre.jar
81a03f76019c67362299c40e0ba13405f5467bff  server/lib/ant/asm-9.2.jar
f4d7f0fc9054386f2893b602454d48e07d4fbead  server/lib/ant/asm-commons-9.2.jar
d96c99a30f5e1a19b0e609dbb19a44d8518ac01e  server/lib/ant/asm-tree-9.2.jar
6ee1de41e73bc9480d23970262d2b00d2a4ed97b  server/lib/ant/org.jacoco.agent-0.8.8.jar
77363f317d3ddfe4c4fd0cb622ee551baae2faa9  server/lib/ant/org.jacoco.ant-0.8.8.jar
fb1257ce77ec2fe326aad639b2253e76f481ea2e  server/lib/ant/org.jacoco.core-0.8.8.jar
366581c3bc90e2900320c528c294949bad7232c8  server/lib/ant/org.jacoco.report-0.8.8.jar
5864149b2e5a2af7b05fe9e9dc3e4b70d3060a7c  server/lib/aws/ext/netty/netty-buffer-4.1.119.Final.jar
337ca8e8c3ef23925e02d56347b414d7616d1d02  server/lib/aws/ext/netty/netty-codec-4.1.119.Final.jar
23196984df6083cc39bef22a54c6cf5b157f3824  server/lib/aws/ext/netty/netty-codec-http-4.1.119.Final.jar
648b066861723b60635bef2047229ed73d0cbd04  server/lib/aws/ext/netty/netty-codec-http2-4.1.119.Final.jar
2f7c360b03c0aceab7efc1f7c2b75274f0f35909  server/lib/aws/ext/netty/netty-common-4.1.119.Final.jar
a0059b8d779ce566b524efd6d73ba4fcff3cd5d9  server/lib/aws/ext/netty/netty-handler-4.1.119.Final.jar
e1f7c90aff71bdf0e2294a200b5f89244f88dcf7  server/lib/aws/ext/netty/netty-resolver-4.1.119.Final.jar
d05df879054297962d056b77460fc4ff20e30073  server/lib/aws/ext/netty/netty-transport-4.1.119.Final.jar
500fdc2000a47c07ad6c0ea230127f5ac3c9ad5c  server/lib/aws/ext/netty/netty-transport-native-epoll-4.1.119.Final-linux-x86_64.jar
55afdeb456bccf8eecb06431f3c1537269afe9af  server/lib/aws/ext/netty/netty-transport-native-unix-common-4.1.119.Final.jar
f159dd8bbbf381c4006c1f675ec4e648c8317f32  server/lib/classgraph-4.8.179.jar
3fae6004e0c5e1b2b46a2b28e017efcc1a40d6bf  server/lib/commons/commons-email-1.6.0.jar
5a4e26802e0a5a42938f987976b55dae4a6cc636  server/lib/commons/commons-net-3.9.0.jar
a306167fdb88152403c8b00595b1502ffacd5b76  server/lib/commons/commons-vfs2-2.10.0.jar
b1bc0f47bcad26ad5f9bceefb63fcb920d868fca  server/lib/database/mysql-connector-j-8.4.0.jar
ca47da3c71d715ce005b420af566b9786829a04d  server/lib/jetty/jetty-annotations-9.4.57.v20241219.jar
c2bf5c810049fe23945f737a3c4743da81baa62d  server/lib/jetty/jetty-continuation-9.4.57.v20241219.jar
c7a3a9c599346708894cf355e03105937f45f427  server/lib/jetty/jetty-http-9.4.57.v20241219.jar
bd0ca6e5c4314972cd91f427fa09dedfe3b84ff5  server/lib/jetty/jetty-io-9.4.57.v20241219.jar
9ec603efd530c70302949004db592b6b447b785e  server/lib/jetty/jetty-jndi-9.4.57.v20241219.jar
b7c03e553743011f4fed7d91fa8aae9fa91524de  server/lib/jetty/jetty-plus-9.4.57.v20241219.jar
c38734a0465dfc80c0eacf912f2cf791038b2096  server/lib/jetty/jetty-rewrite-9.4.57.v20241219.jar
2b545f68d45b947fdc6e279a0e8ae3630ec10e05  server/lib/jetty/jetty-security-9.4.57.v20241219.jar
ad3baf52b98b4a32f5714fe2e58ac0e502b4e4d8  server/lib/jetty/jetty-server-9.4.57.v20241219.jar
3e648eebddbf5ad0c0f7698e50c6a69c4a77fd95  server/lib/jetty/jetty-servlet-9.4.57.v20241219.jar
7bf7ea75644ac064199e1e32c66ccd312239f2dc  server/lib/jetty/jetty-util-9.4.57.v20241219.jar
7b5f144a3d0cbfcac62f2fcb9e14ffa765048f0e  server/lib/jetty/jetty-util-ajax-9.4.57.v20241219.jar
3ef93ab9a81547d0def15b8a2d1d6bed7da4bb9c  server/lib/jetty/jetty-webapp-9.4.57.v20241219.jar
bfec69b645695b670435016d3ec733656f4f6818  server/lib/jetty/jetty-xml-9.4.57.v20241219.jar
9ff6a973006622f05b7f71b76042ed081336422f  server/lib/jetty/jsp/apache-jsp-9.4.57.v20241219-sources.jar
45cf516d9a23485200950549ff72b204c307fc9d  server/testlib/byte-buddy-1.14.13.jar
979ce25f7d3096a2e82214ba7dc972a05ce7a171  server/testlib/byte-buddy-agent-1.14.13.jar
1820c0968dba3a11a1b30669bb1f01978a91dedc  server/testlib/hamcrest-2.2.jar
cdd00374f1fee76b11e2a9d127405aa3f6be5b6a  server/testlib/junit-4.13.1.jar
31fd75d9d80e678032e5dc1bad17386f192853ea  server/testlib/mockito-core-5.1.1.jar
3d1dffee9a8a1998ec782383ca2f818848f2d5f1  server/testlib/mockito-inline-5.1.1.jar

These are the results of looking up the sha1 hashes on maven central:
STATUS   REMOTE IDENTITY (Group:Artifact:Version)                     LOCAL FILE
------------------------------------------------------------------------------------------------------------------------
✅ OK     org.apache.commons:commons-vfs2:2.10.0                       client/lib/commons-vfs2-2.10.0.jar
✅ OK     com.google.guava:guava:32.0.1-jre                            client/lib/guava-32.0.1-jre.jar
✅ OK     org.eclipse.jetty:jetty-util:9.4.57.v20241219                client/lib/jetty-util-9.4.57.v20241219.jar
✅ OK     org.apache.commons:commons-vfs2:2.10.0                       command/lib/commons-vfs2-2.10.0.jar
✅ OK     com.google.guava:guava:32.0.1-jre                            command/lib/guava-32.0.1-jre.jar
✅ OK     org.eclipse.jetty:jetty-util:9.4.57.v20241219                command/lib/jetty-util-9.4.57.v20241219.jar
✅ OK     com.mysql:mysql-connector-j:8.4.0                            donkey/lib/database/mysql-connector-j-8.4.0.jar
✅ OK     com.google.guava:guava:32.0.1-jre                            donkey/lib/guava/guava-32.0.1-jre.jar
✅ OK     net.bytebuddy:byte-buddy:1.14.13                             donkey/testlib/byte-buddy-1.14.13.jar
✅ OK     net.bytebuddy:byte-buddy-agent:1.14.13                       donkey/testlib/byte-buddy-agent-1.14.13.jar
✅ OK     org.mockito:mockito-core:5.1.1                               donkey/testlib/mockito-core-5.1.1.jar
✅ OK     com.google.guava:guava:32.0.1-jre                            manager/lib/guava-32.0.1-jre.jar
✅ OK     org.ow2.asm:asm:9.2                                          server/lib/ant/asm-9.2.jar
✅ OK     org.ow2.asm:asm-commons:9.2                                  server/lib/ant/asm-commons-9.2.jar
✅ OK     org.ow2.asm:asm-tree:9.2                                     server/lib/ant/asm-tree-9.2.jar
✅ OK     org.jacoco:org.jacoco.agent:0.8.8                            server/lib/ant/org.jacoco.agent-0.8.8.jar
✅ OK     org.jacoco:org.jacoco.ant:0.8.8                              server/lib/ant/org.jacoco.ant-0.8.8.jar
✅ OK     org.jacoco:org.jacoco.core:0.8.8                             server/lib/ant/org.jacoco.core-0.8.8.jar
✅ OK     org.jacoco:org.jacoco.report:0.8.8                           server/lib/ant/org.jacoco.report-0.8.8.jar
✅ OK     io.netty:netty-buffer:4.1.119.Final                          server/lib/aws/ext/netty/netty-buffer-4.1.119.Final.jar
✅ OK     io.netty:netty-codec:4.1.119.Final                           server/lib/aws/ext/netty/netty-codec-4.1.119.Final.jar
✅ OK     io.netty:netty-codec-http:4.1.119.Final                      server/lib/aws/ext/netty/netty-codec-http-4.1.119.Final.jar
✅ OK     io.netty:netty-codec-http2:4.1.119.Final                     server/lib/aws/ext/netty/netty-codec-http2-4.1.119.Final.jar
✅ OK     io.netty:netty-common:4.1.119.Final                          server/lib/aws/ext/netty/netty-common-4.1.119.Final.jar
✅ OK     io.netty:netty-handler:4.1.119.Final                         server/lib/aws/ext/netty/netty-handler-4.1.119.Final.jar
✅ OK     io.netty:netty-resolver:4.1.119.Final                        server/lib/aws/ext/netty/netty-resolver-4.1.119.Final.jar
✅ OK     io.netty:netty-transport:4.1.119.Final                       server/lib/aws/ext/netty/netty-transport-4.1.119.Final.jar
✅ OK     io.netty:netty-transport-native-epoll:4.1.119.Final          server/lib/aws/ext/netty/netty-transport-native-epoll-4.1.119.Final-linux-x86_64.jar
✅ OK     io.netty:netty-transport-native-unix-common:4.1.119.Final    server/lib/aws/ext/netty/netty-transport-native-unix-common-4.1.119.Final.jar
✅ OK     io.github.classgraph:classgraph:4.8.179                      server/lib/classgraph-4.8.179.jar
✅ OK     org.apache.commons:commons-email:1.6.0                       server/lib/commons/commons-email-1.6.0.jar
✅ OK     commons-net:commons-net:3.9.0                                server/lib/commons/commons-net-3.9.0.jar
✅ OK     org.apache.commons:commons-vfs2:2.10.0                       server/lib/commons/commons-vfs2-2.10.0.jar
✅ OK     com.mysql:mysql-connector-j:8.4.0                            server/lib/database/mysql-connector-j-8.4.0.jar
✅ OK     org.eclipse.jetty:jetty-annotations:9.4.57.v20241219         server/lib/jetty/jetty-annotations-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-continuation:9.4.57.v20241219        server/lib/jetty/jetty-continuation-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-http:9.4.57.v20241219                server/lib/jetty/jetty-http-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-io:9.4.57.v20241219                  server/lib/jetty/jetty-io-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-jndi:9.4.57.v20241219                server/lib/jetty/jetty-jndi-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-plus:9.4.57.v20241219                server/lib/jetty/jetty-plus-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-rewrite:9.4.57.v20241219             server/lib/jetty/jetty-rewrite-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-security:9.4.57.v20241219            server/lib/jetty/jetty-security-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-server:9.4.57.v20241219              server/lib/jetty/jetty-server-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-servlet:9.4.57.v20241219             server/lib/jetty/jetty-servlet-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-util:9.4.57.v20241219                server/lib/jetty/jetty-util-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-util-ajax:9.4.57.v20241219           server/lib/jetty/jetty-util-ajax-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-webapp:9.4.57.v20241219              server/lib/jetty/jetty-webapp-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:jetty-xml:9.4.57.v20241219                 server/lib/jetty/jetty-xml-9.4.57.v20241219.jar
✅ OK     org.eclipse.jetty:apache-jsp:9.4.57.v20241219                server/lib/jetty/jsp/apache-jsp-9.4.57.v20241219-sources.jar
✅ OK     net.bytebuddy:byte-buddy:1.14.13                             server/testlib/byte-buddy-1.14.13.jar
✅ OK     net.bytebuddy:byte-buddy-agent:1.14.13                       server/testlib/byte-buddy-agent-1.14.13.jar
✅ OK     org.hamcrest:hamcrest:2.2                                    server/testlib/hamcrest-2.2.jar
✅ OK     junit:junit:4.13.1                                           server/testlib/junit-4.13.1.jar
✅ OK     org.mockito:mockito-core:5.1.1                               server/testlib/mockito-core-5.1.1.jar
✅ OK     org.mockito:mockito-inline:5.2.0                             server/testlib/mockito-inline-5.1.1.jar

Author: tonygermano

.github/workflows/build.yaml

@@ -18,7 +18,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v4
         with:
-          java-version: '8'
+          java-version: '17'
           java-package: 'jdk+fx'
           distribution: 'zulu'
 

.gitignore

@@ -107,8 +107,13 @@ Desktop.ini
 donkey/donkey-src
 donkey/donkey-test
 .sonar
+# Unit Tests:
 **/junit-reports
+**/junit-html
 **/code-coverage-reports
+/exports/
+/MapUtilTestDB/
+/testconf/
 
 # /client/
 /client/logs

.sdkmanrc

@@ -1,4 +1,4 @@
 # Enable auto-env through the sdkman_auto_env config
 # Add key=value pairs of SDKs to use below
-java=8.0.442.fx-zulu
+java=17.0.17.fx-zulu
 ant=1.10.14

client/ant-build.xml

@@ -332,11 +332,23 @@
 			<classpath refid="testclasspath" />
 		</javac>
 	</target>
-	
-	<taskdef uri="antlib:org.jacoco.ant" resource="org/jacoco/ant/antlib.xml">
-		<classpath path="${server}/lib/ant/jacocoant.jar"/>
-	</taskdef>
-	
+
+	<path id="jacoco.classpath">
+		<fileset dir="../server/lib/ant">
+			<include name="org.jacoco.ant-0.8.8.jar"/>
+			<include name="org.jacoco.core-0.8.8.jar"/>
+			<include name="org.jacoco.report-0.8.8.jar"/>
+			<include name="org.jacoco.agent-0.8.8.jar"/>
+			<include name="asm-9.2.jar"/>
+			<include name="asm-tree-9.2.jar"/>
+			<include name="asm-commons-9.2.jar"/>
+		</fileset>
+	</path>
+
+	<taskdef uri="antlib:org.jacoco.ant"
+			 resource="org/jacoco/ant/antlib.xml"
+			 classpathref="jacoco.classpath"/>
+
 	<target name="test-run" depends="test-compile">
 		<property name="junit-reports" value="junit-reports" />
 		<property name="code-coverage-reports" value="code-coverage-reports" />
@@ -347,6 +359,8 @@
 			<junit haltonfailure="false" fork="true" forkmode="once">
 				<jvmarg value="-Xms128m" />
 				<jvmarg value="-Xmx2048m" />
+				<!-- https://stackoverflow.com/questions/54205486 -->
+				<jvmarg value="-Xshare:off" />
 				<classpath>
 					<path refid="testclasspath" />
 					<dirset dir="${test_classes}"/>

client/lib/commons-vfs2-2.10.0.jar

@@ -71,11 +71,23 @@
 			<classpath refid="testclasspath" />
 		</javac>
 	</target>
-	
-	<taskdef uri="antlib:org.jacoco.ant" resource="org/jacoco/ant/antlib.xml">
-		<classpath path="${server}/lib/ant/jacocoant.jar"/>
-	</taskdef>	
-	
+
+	<path id="jacoco.classpath">
+		<fileset dir="../server/lib/ant">
+			<include name="org.jacoco.ant-0.8.8.jar"/>
+			<include name="org.jacoco.core-0.8.8.jar"/>
+			<include name="org.jacoco.report-0.8.8.jar"/>
+			<include name="org.jacoco.agent-0.8.8.jar"/>
+			<include name="asm-9.2.jar"/>
+			<include name="asm-tree-9.2.jar"/>
+			<include name="asm-commons-9.2.jar"/>
+		</fileset>
+	</path>
+
+	<taskdef uri="antlib:org.jacoco.ant"
+			 resource="org/jacoco/ant/antlib.xml"
+			 classpathref="jacoco.classpath"/>
+
 	<target name="test-run" depends="test-compile">
 		<property name="junit-reports" value="junit-reports" />
 		<property name="code-coverage-reports" value="code-coverage-reports" />
@@ -86,6 +98,8 @@
 			<junit haltonfailure="false" fork="true" forkmode="once">
 				<jvmarg value="-Xms128m" />
 				<jvmarg value="-Xmx2048m" />
+				<!-- https://stackoverflow.com/questions/54205486 -->
+				<jvmarg value="-Xshare:off" />
 				<classpath>
 					<path refid="testclasspath" />
 					<dirset dir="${test_classes}"/>
@@ -99,4 +113,4 @@
 			</junit>
 		</jacoco:coverage>
 	</target>
-</project>
+</project>