cmake: Improve find_library and link usage

According to CMake docs, "link_directories() is rarely necessary".
Therefore remove link_directories(), and use find_library()
after pkg_check_modules() to obtain full paths of libraries.

Because of policy change of CMP0063, only set visibility properties
for freenect2. Do not make them global.

Author: xlz

CMakeLists.txt

@@ -65,8 +65,6 @@ INCLUDE_DIRECTORIES(
   ${TurboJPEG_INCLUDE_DIRS}
 )
 
-LINK_DIRECTORIES(${LibUSB_LIBRARY_DIRS})
-
 SET(RESOURCES_INC_FILE "${PROJECT_BINARY_DIR}/resources.inc.h")
 
 SET(SOURCES
@@ -132,7 +130,6 @@ IF(ENABLE_OPENGL)
   IF(GLFW3_FOUND)
     INCLUDE_DIRECTORIES(${GLFW3_INCLUDE_DIRS})
 
-    LINK_DIRECTORIES(${GLFW3_LIBRARY_DIRS})
     LIST(APPEND LIBRARIES
       ${GLFW3_LIBRARIES}
       ${OPENGL_gl_LIBRARY}
@@ -204,12 +201,12 @@ CONFIGURE_FILE("${MY_DIR}/include/libfreenect2/config.h.in" "${PROJECT_BINARY_DI
 GENERATE_RESOURCES(${RESOURCES_INC_FILE} ${MY_DIR} ${RESOURCES})
 
 ADD_DEFINITIONS(-DRESOURCES_INC)
-SET(CMAKE_CXX_VISIBILITY_PRESET hidden)
-SET(CMAKE_C_VISIBILITY_PRESET hidden)
-SET(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
-INCLUDE(GenerateExportHeader)
-
 ADD_LIBRARY(freenect2 ${SOURCES})
+SET_TARGET_PROPERTIES(freenect2 PROPERTIES
+  CXX_VISIBILITY_PRESET hidden
+  VISIBILITY_INLINES_HIDDEN 1
+)
+INCLUDE(GenerateExportHeader)
 GENERATE_EXPORT_HEADER(freenect2
   BASE_NAME libfreenect2
   EXPORT_FILE_NAME libfreenect2/export.h
@@ -219,7 +216,8 @@ IF(MSVC AND NOT BUILD_SHARED_LIBS)
   # MSVC creates freenect2.lib for both dynamic and static by default
   set_target_properties(freenect2 PROPERTIES SUFFIX "static.lib")
 ENDIF()
-MESSAGE(STATUS "Linking with these libraries: ${LIBRARIES}")
+STRING(REPLACE ";" "\n " LIBRARIES_STRING "${LIBRARIES}")
+MESSAGE(STATUS "Linking with these libraries: \n ${LIBRARIES_STRING}")
 TARGET_LINK_LIBRARIES(freenect2 ${LIBRARIES})
 
 CONFIGURE_FILE(freenect2.cmake.in "${PROJECT_BINARY_DIR}/freenect2Config.cmake" @ONLY)

cmake_modules/FindGLFW3.cmake

@@ -14,6 +14,12 @@ IF(PKG_CONFIG_FOUND)
   SET(ENV{PKG_CONFIG_PATH} "${DEPENDS_DIR}/glfw/lib/pkgconfig:$ENV{PKG_CONFIG_PATH}")
   PKG_CHECK_MODULES(GLFW3 glfw3)
 
+  FIND_LIBRARY(GLFW3_LIBRARY
+    NAMES ${GLFW3_LIBRARIES}
+    HINTS ${GLFW3_LIBRARY_DIRS}
+  )
+  SET(GLFW3_LIBRARIES ${GLFW3_LIBRARY})
+
   RETURN()
 ENDIF()
 

cmake_modules/FindLibUSB.cmake

@@ -16,6 +16,13 @@ IF(PKG_CONFIG_FOUND)
   ELSE()
     PKG_CHECK_MODULES(LibUSB libusb-1.0)
   ENDIF()
+
+  FIND_LIBRARY(LibUSB_LIBRARY
+    NAMES ${LibUSB_LIBRARIES}
+    HINTS ${LibUSB_LIBRARY_DIRS}
+  )
+  SET(LibUSB_LIBRARIES ${LibUSB_LIBRARY})
+
   RETURN()
 ENDIF()
 

examples/CMakeLists.txt

@@ -37,10 +37,6 @@ INCLUDE_DIRECTORIES(
   ${freenect2_INCLUDE_DIR}
 )
 
-LINK_DIRECTORIES(
-  ${freenect2_LIBRARY_DIRS}
-)
-
 SET(Protonect_src
   Protonect.cpp
 )
@@ -58,7 +54,6 @@ IF(ENABLE_OPENGL)
       ${flextGL_INCLUDE_DIRS}
     )
 
-    LINK_DIRECTORIES(${GLFW3_LIBRARY_DIRS})
     LIST(APPEND Protonect_src
       viewer.cpp
       ${flextGL_SOURCES}