Do not require reason on needs attention status update

Author: kszymankiewicz-sd

src/cce-inventory-item-status/status-update-modal.controller.js

@@ -46,6 +46,7 @@
         vm.$onInit = onInit;
         vm.isUnserviceable = isUnserviceable;
         vm.isFunctioning = isFunctioning;
+        vm.isNeedsAttention = isNeedsAttention;
         vm.getStatusLabel = getStatusLabel;
         vm.getReasonLabel = getReasonLabel;
         vm.cancel = cancel;
@@ -166,6 +167,21 @@
             return (status === FUNCTIONAL_STATUS.UNSERVICEABLE);
         }
 
+        /**
+         * @ngdoc method
+         * @methodOf cce-inventory-item-status.controller:StatusUpdateModalController
+         * @name isNeedsAttention
+         *
+         * @description
+         * Checks whether the given status is needs attention.
+         *
+         * @param   {String}    status  the status to be checked
+         * @return  {Boolean}   true if the status is needs attention; false otherwise
+         */
+        function isNeedsAttention(status) {
+            return (status === FUNCTIONAL_STATUS.NEEDS_ATTENTION);
+        }
+
         /**
          * @ngdoc method
          * @methodOf cce-inventory-item-status.controller:StatusUpdateModalController
@@ -180,7 +196,8 @@
             var item = angular.copy(vm.inventoryItem);
 
             item.functionalStatus = vm.newStatus;
-            item.reasonNotWorkingOrNotInUse = isFunctioning(vm.newStatus) ? undefined : vm.reason;
+            item.reasonNotWorkingOrNotInUse = isFunctioning(vm.newStatus) || isNeedsAttention(vm.status)
+                ? undefined : vm.reason;
             item.decommissionDate =
                         isUnserviceable(vm.newStatus) ? vm.decommissionDate : undefined;
 

src/cce-inventory-item-status/status-update-modal.controller.spec.js

@@ -152,6 +152,24 @@ describe('StatusUpdateModalController', function() {
 
     });
 
+    describe('isNeedsAttention', function() {
+
+        beforeEach(function() {
+            vm.$onInit();
+        });
+
+        it('should return true for NEEDS_ATTENTION status', function() {
+            expect(vm.isNeedsAttention(FUNCTIONAL_STATUS.NEEDS_ATTENTION)).toBe(true);
+        });
+
+        it('should return false for status that is other than NEEDS_ATTENTION', function() {
+            expect(vm.isNeedsAttention(FUNCTIONAL_STATUS.FUNCTIONING)).toBe(false);
+            expect(vm.isNeedsAttention(FUNCTIONAL_STATUS.UNSERVICEABLE)).toBe(false);
+            expect(vm.isNeedsAttention(FUNCTIONAL_STATUS.AWAITING_REPAIR)).toBe(false);
+        });
+
+    });
+
     describe('isUnserviceable', function() {
 
         beforeEach(function() {

src/cce-inventory-item-status/status-update-modal.html

@@ -58,7 +58,7 @@ <h3 class="title">{{'cceInventoryItemStatus.updateFunctionalStatus' | message}}<
                             required>
                         </select>
 
-                        <fieldset ng-if="vm.newStatus && !vm.isFunctioning(vm.newStatus)">
+                        <fieldset ng-if="vm.newStatus && !vm.isFunctioning(vm.newStatus) && !vm.isNeedsAttention(vm.newStatus)">
                             <label for="reason">
                                 {{'cceInventoryItemStatus.reasonNotWorkingOrNotInUse' | message}}
                             </label>