Skip to content

Commit 978f4f9

Browse files
committed
changes based on review comments
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
1 parent a990fcf commit 978f4f9

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -779,14 +779,12 @@ private boolean isValidURL(String url) {
779779

780780
public void parseVariablesForDefaultValues(Document doc) throws XPathExpressionException {
781781
List<Properties> propsList = parseVariables(doc, true, false, false);
782-
props.putAll(propsList.get(0));
783782
defaultProps.putAll(propsList.get(1));
784783
}
785784

786785
private void parseVariablesForValues(Document doc) throws XPathExpressionException {
787786
List<Properties> propsList = parseVariables(doc, false, true, false);
788787
props.putAll(propsList.get(0));
789-
defaultProps.putAll(propsList.get(1));
790788
}
791789

792790
public void parseVariablesForBothValues(Document doc) throws XPathExpressionException {

src/main/java/io/openliberty/tools/common/plugins/util/VariableUtility.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public static List<Properties> parseVariables(Document doc, boolean defaultValue
192192
}
193193
}
194194
}
195-
List<Properties>result=new ArrayList<>();
195+
List<Properties> result = new ArrayList<>();
196196
result.add(props);
197197
result.add(defaultProps);
198198
return result;

0 commit comments

Comments
 (0)