Skip to content

Commit 3b4ed22

Browse files
SajeerSajeer
authored andcommitted
Removed leftover codes, adjusted commends, and reverted unwanted codes
1 parent f59c1b0 commit 3b4ed22

File tree

5 files changed

+8
-14
lines changed

5 files changed

+8
-14
lines changed

.github/workflows/gradle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
matrix:
1919
# test against latest update of each major Java version, as well as specific updates of LTS versions:
2020
RUNTIME: [ol, wlp]
21-
RUNTIME_VERSION: [25.0.0.10]
21+
RUNTIME_VERSION: [25.0.0.12]
2222
java: [21, 17, 25]
2323
exclude:
2424
- java: 8
@@ -102,7 +102,7 @@ jobs:
102102
matrix:
103103
# test against latest update of each major Java version, as well as specific updates of LTS versions:
104104
RUNTIME: [ol, wlp]
105-
RUNTIME_VERSION: [25.0.0.10]
105+
RUNTIME_VERSION: [25.0.0.12]
106106
java: [21, 17, 25]
107107
exclude:
108108
- java: 8

build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,15 @@ compileTestGroovy {
8787
targetCompatibility = JavaVersion.VERSION_1_8
8888
}
8989

90-
// In-order to support both Java 17 and Java 21, we configure the toolchain
90+
// In-order to support both Java 17, Java 21 and Java 25, we configure the toolchain
9191
// Reference: https://docs.gradle.org/current/userguide/toolchains.html
9292
java {
9393
toolchain {
9494
// Default to Java 17 for backward compatibility
9595
languageVersion = JavaLanguageVersion.of(17)
9696

97-
// Allow Java 21 as a compatible alternative
98-
// This enables the project to work with either Java 17 or Java 21
97+
// Allow Java 21 or Java 25 as a compatible alternative
98+
// This enables the project to work with either Java 17, Java 21 or Java 25
9999
if (System.getProperty('java.version').startsWith('21')) {
100100
languageVersion = JavaLanguageVersion.of(21)
101101
}

src/main/groovy/io/openliberty/tools/gradle/tasks/AbstractServerTask.groovy

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1329,13 +1329,7 @@ abstract class AbstractServerTask extends AbstractLibertyTask {
13291329
protected void addToolchainEnvToServerTask(ServerTask serverTask) {
13301330
Map<String, String> envVars = getToolchainEnvVar();
13311331
if (!envVars.isEmpty()) {
1332-
if (serverTask.getEnvironmentVariables() != null && !serverTask.getEnvironmentVariables().isEmpty()) {
1333-
Map<String, String> mergedEnv = new HashMap<>(serverTask.getEnvironmentVariables());
1334-
mergedEnv.putAll(envVars);
1335-
serverTask.setEnvironmentVariables(mergedEnv);
1336-
} else {
1337-
serverTask.setEnvironmentVariables(envVars);
1338-
}
1332+
serverTask.setEnvironmentVariables(envVars);
13391333
}
13401334
}
13411335

src/main/groovy/io/openliberty/tools/gradle/tasks/StopTask.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class StopTask extends AbstractServerTask {
3333
void stop() {
3434
File serverDir = getServerDir(project)
3535

36-
ServerUtils.cleanupForceStoppedMarker(getServerDir(project), logger)
36+
ServerUtils.cleanupForceStoppedMarker(serverDir, logger)
3737

3838
if (isLibertyInstalledAndValid(project)) {
3939
if (serverDir.exists()) {

src/test/groovy/io/openliberty/tools/gradle/TestLooseApplicationWithToolchain.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class TestLooseApplicationWithToolchain extends AbstractIntegrationTest{
4040
@Test
4141
public void test_loose_config_file_exists() {
4242
try {
43-
result = runTasksResult(buildDir, 'deploy', 'deploy', '--info', '--stacktrace')
43+
result = runTasksResult(buildDir, 'deploy', '--info', '--stacktrace')
4444
} catch (Exception e) {
4545
throw new AssertionError ("Fail on task deploy.", e)
4646
}

0 commit comments

Comments
 (0)