Caching the resolved JDK home path on once successfully resolved (#1058)

* Added toolchain JDK home caching

* Added Toolchain honored message check as well to the DevMode toolchain test

---------

Co-authored-by: Sajeer <sajeer@Sajeers-MacBook-Pro.local>

Author: sajeerzeji

src/main/groovy/io/openliberty/tools/gradle/tasks/AbstractLibertyTask.groovy

@@ -45,6 +45,9 @@ abstract class AbstractLibertyTask extends DefaultTask {
     @Optional
     public final Property<JavaLauncher> javaLauncher = project.objects.property(JavaLauncher)
 
+    // Cached toolchain javaHome
+    private String resolvedToolchainJavaHome = null
+
     public JavaLauncher getJavaLauncher() {
         if(!javaLauncher.isPresent()) {
             configureDefaults();
@@ -272,11 +275,14 @@ abstract class AbstractLibertyTask extends DefaultTask {
      */
     @Internal
     protected String getToolchainJavaHome() {
+        if (resolvedToolchainJavaHome != null) {
+            return resolvedToolchainJavaHome
+        }
         def launcher = getConfiguredLauncher()
         if (launcher != null) {
-            return launcher.metadata.installationPath.asFile.absolutePath
+            resolvedToolchainJavaHome = launcher.metadata.installationPath.asFile.absolutePath
         }
-        return null
+        return resolvedToolchainJavaHome
     }
     @Internal
     protected boolean isToolchainConfigured() {

src/test/groovy/io/openliberty/tools/gradle/DevModeToolchainTest.groovy

@@ -85,6 +85,10 @@ class DevModeToolchainTest extends BaseDevTest {
         System.out.println(stdout)
         String stderr = getContents(errFile, "Dev mode std error")
         System.out.println(stderr)
+        assertTrue("Toolchain warning should not appear when dev mode stops",
+                !verifyLogMessage(0, "Could not determine JDK home from toolchain", errFile))
+        assertTrue("Toolchain honored message should appear in dev mode output",
+                verifyLogMessage(0, String.format(TOOLCHAIN_CONFIGURED, "libertyDev"), logFile))
         cleanUpAfterClass(true)
     }
 }