Skip to content

Commit bf85890

Browse files
authored
Merge pull request #412 from OpenLiberty/staging
Merge staging to prod - Update to use maven wrapper
2 parents 7aacead + 7bc954e commit bf85890

File tree

15 files changed

+1218
-26
lines changed

15 files changed

+1218
-26
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ jobs:
2828
VALIDATE_ALL_CODEBASE: false
2929
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3030
LINTER_RULES_PATH: ./tools/pr-checker/linters/
31+
FILTER_REGEX_EXCLUDE: mvnw*
3132
DEFAULT_BRANCH: prod
3233
- name: Summary
3334
if: "! github.event.pull_request.head.repo.fork"
@@ -52,7 +53,7 @@ jobs:
5253
java-version: 11
5354
- run: unset _JAVA_OPTIONS
5455
- name: Run tests
55-
run: sudo ../scripts/testApp.sh
56+
run: sudo -E ../scripts/testApp.sh
5657
- name: Post tests
5758
if: always()
5859
run: |

README.adoc

Lines changed: 124 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,67 @@ include::{common-includes}/gitclone.adoc[]
6262

6363
The `finish` directory contains the finished JWT security implementation for the services in the application. Try the finished application before you build your own.
6464

65-
To try out the application, run the following commands to navigate to the `finish/frontend` directory and deploy the `frontend` service to Open Liberty:
65+
To try out the application, run the following commands to navigate to the `finish` directory and deploy the `frontend` service to Open Liberty:
6666

67+
include::{common-includes}/os-tabs.adoc[]
68+
69+
[.tab_content.windows_section]
70+
--
71+
[role='command']
72+
```
73+
cd finish
74+
mvnw.cmd -pl frontend liberty:run
75+
```
76+
--
77+
78+
[.tab_content.mac_section]
79+
--
80+
[role='command']
81+
```
82+
cd finish
83+
./mvnw -pl frontend liberty:run
84+
```
85+
--
86+
87+
[.tab_content.linux_section]
88+
--
6789
[role='command']
6890
```
69-
cd finish/frontend
70-
mvn liberty:run
91+
cd finish
92+
./mvnw -pl frontend liberty:run
7193
```
94+
--
7295

73-
Open another command-line session and run the following commands to navigate to the `finish/system` directory and deploy the `system` service to Open Liberty:
96+
Open another command-line session and run the following commands to navigate to the `finish` directory and deploy the `system` service to Open Liberty:
7497

98+
include::{common-includes}/os-tabs.adoc[]
99+
100+
[.tab_content.windows_section]
101+
--
75102
[role='command']
76103
```
77-
cd finish/system
78-
mvn liberty:run
104+
cd finish
105+
mvnw.cmd -pl system liberty:run
79106
```
107+
--
108+
109+
[.tab_content.mac_section]
110+
--
111+
[role='command']
112+
```
113+
cd finish
114+
./mvnw -pl system liberty:run
115+
```
116+
--
117+
118+
[.tab_content.linux_section]
119+
--
120+
[role='command']
121+
```
122+
cd finish
123+
./mvnw -pl system liberty:run
124+
```
125+
--
80126

81127
After you see the following message in both command-line sessions, both of your services are ready:
82128

@@ -132,11 +178,34 @@ endif::[]
132178

133179
When you are done with the application, stop both the `frontend` and `system` services by pressing `CTRL+C` in the command-line sessions where you ran them. Alternatively, you can run the following goals from the `finish` directory in another command-line session:
134180

181+
include::{common-includes}/os-tabs.adoc[]
182+
183+
[.tab_content.windows_section]
184+
--
185+
[role='command']
186+
```
187+
mvnw.cmd -pl system liberty:stop
188+
mvnw.cmd -pl frontend liberty:stop
189+
```
190+
--
191+
192+
[.tab_content.mac_section]
193+
--
135194
[role='command']
136195
```
137-
mvn -pl system liberty:stop
138-
mvn -pl frontend liberty:stop
196+
./mvnw -pl system liberty:stop
197+
./mvnw -pl frontend liberty:stop
139198
```
199+
--
200+
201+
[.tab_content.linux_section]
202+
--
203+
[role='command']
204+
```
205+
./mvnw -pl system liberty:stop
206+
./mvnw -pl frontend liberty:stop
207+
```
208+
--
140209

141210
// =================================================================================================
142211
// Creating the secure system service
@@ -157,20 +226,61 @@ cd /home/project/guide-microprofile-jwt/start
157226
```
158227
endif::[]
159228

160-
When you run Open Liberty in https://openliberty.io/docs/latest/development-mode.html[dev mode^], dev mode listens for file changes and automatically recompiles and deploys your updates whenever you save a new change. Run the following commands to navigate to the `frontend` directory and start the `frontend` service in dev mode:
229+
When you run Open Liberty in https://openliberty.io/docs/latest/development-mode.html[dev mode^], dev mode listens for file changes and automatically recompiles and deploys your updates whenever you save a new change. Run the following command to start the `frontend` service in dev mode:
230+
231+
include::{common-includes}/os-tabs.adoc[]
232+
233+
[.tab_content.windows_section]
234+
--
235+
[role='command']
236+
```
237+
mvnw.cmd -pl frontend liberty:dev
238+
```
239+
--
240+
241+
[.tab_content.mac_section]
242+
--
243+
[role='command']
244+
```
245+
./mvnw -pl frontend liberty:dev
246+
```
247+
--
248+
249+
[.tab_content.linux_section]
250+
--
251+
[role='command']
252+
```
253+
./mvnw -pl frontend liberty:dev
254+
```
255+
--
256+
257+
Open another command-line session and run the following command to start the `system` service in dev mode:
258+
259+
include::{common-includes}/os-tabs.adoc[]
260+
261+
[.tab_content.windows_section]
262+
--
263+
[role='command']
264+
```
265+
mvnw.cmd -pl system liberty:dev
266+
```
267+
--
161268

269+
[.tab_content.mac_section]
270+
--
162271
[role='command']
163272
```
164-
cd frontend
165-
mvn liberty:dev
273+
./mvnw -pl system liberty:dev
166274
```
275+
--
167276

168-
Open another command-line session and run the following commands to navigate to the `system` directory and start the `system` service in dev mode:
277+
[.tab_content.linux_section]
278+
--
169279
[role='command']
170280
```
171-
cd system
172-
mvn liberty:dev
281+
./mvnw -pl system liberty:dev
173282
```
283+
--
174284

175285
After you see the following message, your Liberty instance is ready in dev mode:
176286

61.6 KB
Binary file not shown.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip
2+
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.2/maven-wrapper-3.3.2.jar

finish/frontend/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<dependency>
3434
<groupId>com.ibm.websphere.appserver.api</groupId>
3535
<artifactId>com.ibm.websphere.appserver.api.jwt</artifactId>
36-
<version>1.1.100</version>
36+
<version>1.1.101</version>
3737
<scope>provided</scope>
3838
</dependency>
3939
</dependencies>

0 commit comments

Comments
 (0)