Skip to content

Laura's review #39

@lauracowen

Description

@lauracowen

I've not run the steps myself; I've only read the guide but it looks great. Thank you.

I've made a few comments/suggestions below but they're mostly trivial as I think it's in good shape:

  • "MicroProfile Telemetry adopts OpenTelemetry to enable" - maybe "MicroProfile Telemetry uses OpenTelemetry to enable"? Trivial - I just found "adopts" a slightly formal and out-of-place wording. But it might just be me.
  • "Setting the otel.sdk.disabled property to false property" - I think that second "property" shouldn't be there?
  • "Telemetry such as Liberty startup logs and JVM metrics is generated when the servers start. " - maybe switch round to "When the servers start, telemetry such as Liberty startup logs and JVM metrics is generated. " or "Telemetry, such as Liberty startup logs and JVM metrics, is generated when the servers start. " or something like that. It took me a couple of reads to parse it as it is.
  • "with kind client calling" - should "kind" be "Kind"? And then monospace font for either or both words?
  • "View application-level metrics." - should be a colon (:) not a full-stop/period (.) I think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions