Skip to content

Commit 340cbd1

Browse files
authored
Merge pull request #276 from OpenLiberty/staging
Merge staging to prod - Update to use maven wrapper
2 parents 6667e24 + a678411 commit 340cbd1

File tree

15 files changed

+1622
-271
lines changed

15 files changed

+1622
-271
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ jobs:
3232
VALIDATE_HTML: false
3333
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3434
LINTER_RULES_PATH: ./tools/pr-checker/linters/
35+
FILTER_REGEX_EXCLUDE: mvnw*
3536
DEFAULT_BRANCH: prod
3637
- name: Summary
3738
if: "! github.event.pull_request.head.repo.fork"
@@ -56,7 +57,7 @@ jobs:
5657
java-version: 11
5758
- run: unset _JAVA_OPTIONS
5859
- name: Run tests
59-
run: sudo ../scripts/testApp.sh
60+
run: sudo -E ../scripts/testApp.sh
6061
- name: Post tests
6162
if: always()
6263
run: |

README.adoc

Lines changed: 83 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -65,26 +65,51 @@ The `finish` directory in the root of this guide contains the finished applicati
6565
ifndef::cloud-hosted[]
6666
To try out the application, navigate to the `finish` directory and run the following Maven goal to build the application and deploy it to Open Liberty:
6767

68+
include::{common-includes}/os-tabs.adoc[]
69+
70+
[.tab_content.windows_section]
71+
--
72+
[role='command']
73+
```
74+
cd finish
75+
mvnw.cmd process-resources
76+
mvnw.cmd liberty:run
77+
```
78+
--
79+
80+
[.tab_content.mac_section]
81+
--
82+
[role='command']
83+
```
84+
cd finish
85+
./mvnw process-resources
86+
./mvnw liberty:run
87+
```
88+
--
89+
90+
[.tab_content.linux_section]
91+
--
6892
[role='command']
6993
```
7094
cd finish
71-
mvn process-resources
72-
mvn liberty:run
95+
./mvnw process-resources
96+
./mvnw liberty:run
7397
```
98+
--
7499
endif::[]
75100

76101
ifdef::cloud-hosted[]
77102
In this IBM cloud environment, you need to update the URL to access the ***artists.json***. Run the following commands to go to the ***finish*** directory and update the files where the URL has been specified:
78103
```bash
79104
cd finish
80-
mvn process-resources
105+
./mvnw process-resources
81106
sed -i 's=http://localhost:9080/artists='"https://${USERNAME}-9080.$(echo $TOOL_DOMAIN | sed 's/\.labs\./.proxy./g')/artists"'=' /home/project/guide-rest-client-reactjs/finish/src/main/webapp/_next/static/chunks/app/page-*.js
82107
sed -i 's=http://localhost:9080/artists='"https://${USERNAME}-9080.$(echo $TOOL_DOMAIN | sed 's/\.labs\./.proxy./g')/artists"'=' /home/project/guide-rest-client-reactjs/finish/src/main/frontend/src/app/ArtistTable.jsx
83108
```
84109

85110
To try out the application, run the following Maven goal to build the application and deploy it to Open Liberty:
86111
```bash
87-
mvn liberty:run
112+
./mvnw liberty:run
88113
```
89114
endif::[]
90115

@@ -110,7 +135,7 @@ endif::[]
110135
image::react-table.png[React Paginated Table,align="center"]
111136

112137
[role='command']
113-
include::{common-includes}/twyb-end.adoc[]
138+
include::{common-includes}/twyb-end-mvnw.adoc[]
114139

115140
// =================================================================================================
116141
// Starting the service
@@ -129,7 +154,7 @@ cd /home/project/guide-rest-client-reactjs/start
129154
endif::[]
130155

131156
[role='command']
132-
include::{common-includes}/devmode-lmp33-start.adoc[]
157+
include::{common-includes}/devmode-mvnw-start.adoc[]
133158

134159
ifndef::cloud-hosted[]
135160
After you start the service, you can find your artist JSON at the http://localhost:9080/artists[http://localhost:9080/artists^] URL.
@@ -287,16 +312,38 @@ In a new command-line session, build the front end by running the following comm
287312

288313
// Static guide instruction
289314
ifndef::cloud-hosted[]
315+
316+
include::{common-includes}/os-tabs.adoc[]
317+
318+
[.tab_content.windows_section]
319+
--
290320
[role='command']
291-
----
292-
mvn process-resources
293-
----
321+
```
322+
mvnw.cmd process-resources
323+
```
324+
--
325+
326+
[.tab_content.mac_section]
327+
--
328+
[role='command']
329+
```
330+
./mvnw process-resources
331+
```
332+
--
333+
334+
[.tab_content.linux_section]
335+
--
336+
[role='command']
337+
```
338+
./mvnw process-resources
339+
```
340+
--
294341
endif::[]
295342
// Cloud hosted guide instruction
296343
ifdef::cloud-hosted[]
297344
```bash
298345
cd /home/project/guide-rest-client-reactjs/start
299-
mvn process-resources
346+
./mvnw process-resources
300347
```
301348
endif::[]
302349

@@ -342,16 +389,38 @@ include::finish/pom.xml[]
342389
To run the default test, you can add the [hotspot=node-tests file=1]`testing` configuration to the `frontend-maven-plugin`. Rerun the Maven `process-resources` goal to rebuild the front end and run the tests.
343390

344391
ifndef::cloud-hosted[]
392+
393+
include::{common-includes}/os-tabs.adoc[]
394+
395+
[.tab_content.windows_section]
396+
--
345397
[role='command']
346-
----
347-
mvn process-resources
348-
----
398+
```
399+
mvnw.cmd process-resources
400+
```
401+
--
402+
403+
[.tab_content.mac_section]
404+
--
405+
[role='command']
406+
```
407+
./mvnw process-resources
408+
```
409+
--
410+
411+
[.tab_content.linux_section]
412+
--
413+
[role='command']
414+
```
415+
./mvnw process-resources
416+
```
417+
--
349418
endif::[]
350419
// Cloud hosted guide instruction
351420
ifdef::cloud-hosted[]
352421
```bash
353422
cd /home/project/guide-rest-client-reactjs/start
354-
mvn process-resources
423+
./mvnw process-resources
355424
```
356425
endif::[]
357426

61.6 KB
Binary file not shown.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip
2+
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.2/maven-wrapper-3.3.2.jar

0 commit comments

Comments
 (0)