Validate project start before launch

Signed-off-by: Adam Wisniewski <awisniew@us.ibm.com>

Author: awisniew90

bundles/io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/DevModeOperations.java

@@ -14,6 +14,7 @@
 
 import java.io.BufferedReader;
 import java.io.File;
+import java.io.IOException;
 import java.io.InputStreamReader;
 import java.net.URL;
 import java.nio.file.Path;
@@ -166,8 +167,10 @@ public static DevModeOperations getInstance() {
      * @param javaHomePath The configuration java installation home to be set in the process running dev mode.
      * @param launch The launch associated with this run.
      * @param mode The configuration mode.
+     * 
+     * @throws IOException
      */
-    public void start(IProject iProject, String parms, String javaHomePath, ILaunch launch, String mode) {
+    public void start(IProject iProject, String parms, String javaHomePath, ILaunch launch, String mode) throws IOException {
 
         if (Trace.isEnabled()) {
             Trace.getTracer().traceEntry(Trace.TRACE_TOOLS, new Object[] { iProject, parms, javaHomePath, mode });
@@ -182,20 +185,8 @@ public void start(IProject iProject, String parms, String javaHomePath, ILaunch
             return;
         }
 
-        // Check if the start action has already been issued.
         String projectName = iProject.getName();
 
-        // Check if we already have a start process running for this project
-        if (processController.isProcessStarted(projectName)) {
-
-            if (Trace.isEnabled()) {
-                Trace.getTracer().trace(Trace.TRACE_TOOLS, "The start request was already issued on project " + projectName
-                        + ". No-op. ProcessController: " + processController);
-            }
-            ErrorHandler.processErrorMessage(NLS.bind(Messages.start_already_issued, projectName), true);
-            return;
-        }
-
         Project project = null;
 
         try {
@@ -303,20 +294,8 @@ public void startInContainer(IProject iProject, String parms, String javaHomePat
             return;
         }
 
-        // Check if the start action has already been issued.
         String projectName = iProject.getName();
 
-        // Check if we already have a start process running for this project
-        if (processController.isProcessStarted(projectName)) {
-
-            if (Trace.isEnabled()) {
-                Trace.getTracer().trace(Trace.TRACE_TOOLS, "The start in container request was already issued on project " + projectName
-                        + ". No-op. ProcessController: " + processController);
-            }
-            ErrorHandler.processErrorMessage(NLS.bind(Messages.start_container_already_issued, projectName), true);
-            return;
-        }
-
         Project project = null;
 
         try {

bundles/io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/ui/launch/StartTab.java

@@ -218,6 +218,16 @@ public boolean isValid(ILaunchConfiguration config) {
                     return false;
                 }
             }
+
+            // Check if project is already started
+            if (devModeOps.isProjectStarted(configProjectName)) {
+                if (Trace.isEnabled()) {
+                    Trace.getTracer().trace(Trace.TRACE_TOOLS, "The start request was already issued on project " + configProjectName);
+                }
+
+                super.setErrorMessage(NLS.bind(Messages.start_already_issued, configProjectName));
+                return false;
+            }
         } catch (CoreException ce) {
             String msg = "Error getting project name";
             if (Trace.isEnabled()) {

bundles/io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/ui/launch/shortcuts/StartAction.java

@@ -104,6 +104,17 @@ public static void run(IProject iProject, String mode) throws Exception {
         DevModeOperations devModeOps = DevModeOperations.getInstance();
         devModeOps.verifyProjectSupport(iProject);
 
+        // Check if project is already started
+        String projectName = iProject.getName();
+        if (devModeOps.isProjectStarted(projectName)) {
+
+            if (Trace.isEnabled()) {
+                Trace.getTracer().trace(Trace.TRACE_TOOLS, "The start request was already issued on project " + projectName);
+            }
+            ErrorHandler.processErrorMessage(NLS.bind(Messages.start_already_issued, projectName), true);
+            return;
+        }
+
         // Determine what configuration to use.
         LaunchConfigurationHelper launchConfigHelper = LaunchConfigurationHelper.getInstance();
         ILaunchConfiguration configuration = launchConfigHelper.getLaunchConfiguration(iProject, mode, RuntimeEnv.LOCAL);

bundles/io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/ui/launch/shortcuts/StartInContainerAction.java

@@ -107,6 +107,17 @@ public static void run(IProject iProject, String mode) throws Exception {
         DevModeOperations devModeOps = DevModeOperations.getInstance();
         devModeOps.verifyProjectSupport(iProject);
 
+        // Check if project is already started
+        String projectName = iProject.getName();
+        if (devModeOps.isProjectStarted(projectName)) {
+
+            if (Trace.isEnabled()) {
+                Trace.getTracer().trace(Trace.TRACE_TOOLS, "The start in container request was already issued on project " + projectName);
+            }
+            ErrorHandler.processErrorMessage(NLS.bind(Messages.start_container_already_issued, projectName), true);
+            return;
+        }
+
         // Determine what configuration to use.
         LaunchConfigurationHelper launchConfigHelper = LaunchConfigurationHelper.getInstance();
         ILaunchConfiguration configuration = launchConfigHelper.getLaunchConfiguration(iProject, mode, RuntimeEnv.CONTAINER);