Skip to content

Commit 74cca48

Browse files
Merge pull request #4020 from OpenLiberty/staging
Update prod
2 parents 6e790cd + 4f08491 commit 74cca48

File tree

9 files changed

+52
-18
lines changed

9 files changed

+52
-18
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
## Link to issue being addressed:
2+
13
## What was changed and why?
24

35
## Tested using browser:

.github/workflows/rebase-check.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
name: Rebase Check
2+
3+
on:
4+
pull_request:
5+
types: [opened]
6+
branches:
7+
- staging
8+
- draft
9+
10+
jobs:
11+
rebase-check:
12+
runs-on: ubuntu-latest
13+
steps:
14+
- name: Checkout PR branch
15+
uses: actions/checkout@v4
16+
with:
17+
fetch-depth: 0
18+
19+
- name: Post '..' comparison link to verify changes are identical to normal comparison
20+
uses: actions/github-script@v7
21+
with:
22+
script: |
23+
const compareUrl = `https://github.com/OpenLiberty/openliberty.io/compare/${{ github.base_ref }}..${{ github.head_ref }}`;
24+
await github.rest.issues.createComment({
25+
owner: context.repo.owner,
26+
repo: 'openliberty.io',
27+
issue_number: context.payload.pull_request.number,
28+
body: `**Compare your changes here:** \n ${compareUrl} \n Ensure the changes are identical to the desired changes. If not, please resolve merge conflicts (if any) and rebase '${{ github.head_ref }}' onto '${{ github.base_ref }}'`
29+
});

src/main/content/_assets/css/end-of-guide.scss

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@
5656
color:#5d6a8e;
5757
letter-spacing:0;
5858
line-height:24px;
59+
&:hover {
60+
color: #313653;
61+
}
5962
}
6063

6164
.licensedClass {
@@ -214,3 +217,7 @@
214217
footer {
215218
padding-top: 0;
216219
}
220+
221+
.license{
222+
margin-top: 41px;
223+
}

src/main/content/_assets/css/guide-common.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
}
119119

120120
#guide_content a,
121-
#end_of_guide a {
121+
#end_of_guide a:not(#guide_attribution) {
122122
font-weight: 500;
123123
color: #cc4d19;
124124
transition: color 0.2s;
@@ -127,7 +127,7 @@
127127
}
128128

129129
#guide_content a:hover,
130-
#end_of_guide a:hover {
130+
#end_of_guide a:not(#guide_attribution):hover {
131131
color: #f4914d;
132132
}
133133

src/main/content/_assets/js/guide-common.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,6 @@ function createEndOfGuideContent() {
299299
.siblings()
300300
.find("p")
301301
.clone();
302-
whatYouLearned.first().prepend("Nice work! "); // Start every what you learned statement with 'Nice work!'
303302
whatYouLearned.attr("tabindex", "-1");
304303
leftSide.prepend(whatYouLearned);
305304
$("#great-work-you-re-done, #great-work-youre-done").parent().remove(); // Remove section from the main guide column.
@@ -308,16 +307,6 @@ function createEndOfGuideContent() {
308307
)
309308
.parent()
310309
.remove(); // Remove from TOC.
311-
// Concatenate the guide title and guide attribution license and append it to the end of guide.
312-
var guideAttributionText = $("#guide-attribution")
313-
.siblings()
314-
.find("p")
315-
.html();
316-
if (guideAttributionText) {
317-
$("#guide_attribution").html(guideAttributionText);
318-
$("#guide-attribution").parent().remove();
319-
$("#toc_container a[href='#guide-attribution']").parent().remove(); // Remove from TOC.
320-
}
321310

322311
var relatedLinks = $("#related-links").siblings().find("p").clone();
323312
rightSide.append(relatedLinks);

src/main/content/_i18n/en.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ overview:
277277
open_issue: Open Issue
278278
edit_topic: Edit Topic
279279
endofguide:
280-
nice_work: Nice work!
281280
where_to_next: Where to next?
282281
what_do_you_think_of_this_guide: What did you think of this guide?
283282
thanks_for_feedback: Thank you for your feedback!
@@ -296,5 +295,8 @@ endofguide:
296295
download_sample_app: Download the sample application for this guide bundled with Open Liberty on github
297296
keep_exploring: Keep exploring
298297
with_these_guides: with these guides.
298+
great_work: Great work!
299+
you_are_done: You're done!
300+
guide_license: Guide license
299301
seo:
300302
blogs: Latest news and information about Open Liberty, a lightweight open framework for building cloud-native Java applications and microservices. Blogs include latest release and beta updates, technical articles on Jakarta EE, MicroProfile, Kubernetes and container-related Java technologies, and community content.

src/main/content/_i18n/ja.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,6 @@ overview:
276276
open_issue: Open Issue
277277
edit_topic: Edit Topic
278278
endofguide:
279-
nice_work: Nice work!
280279
where_to_next: Where to next?
281280
what_do_you_think_of_this_guide: What did you think of this guide?
282281
thanks_for_feedback: Thank you for your feedback!
@@ -295,5 +294,8 @@ endofguide:
295294
download_sample_app: Download the sample application for this guide bundled with Open Liberty on github
296295
keep_exploring: Keep exploring
297296
with_these_guides: with these guides.
297+
great_work: Great work!
298+
you_are_done: You're done!
299+
guide_license: Guide license
298300
seo:
299301
blogs: クラウド・ネイティブの Java アプリケーションとマイクロサービスを構築するための軽量のオープン・フレームワークである Open Liberty に関する最新ニュースと情報。 ブログには、最新のリリースとベータ版の更新、Jakarta EE、MicroProfile、Kubernetes、コンテナー関連の Java テクノロジーに関する技術記事、コミュニティー・コンテンツが含まれます。

src/main/content/_i18n/zh-Hans.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,6 @@ overview:
276276
open_issue: Open Issue
277277
edit_topic: Edit Topic
278278
endofguide:
279-
nice_work: Nice work!
280279
where_to_next: Where to next?
281280
what_do_you_think_of_this_guide: What did you think of this guide?
282281
thanks_for_feedback: Thank you for your feedback!
@@ -295,5 +294,8 @@ endofguide:
295294
download_sample_app: Download the sample application for this guide bundled with Open Liberty on github
296295
keep_exploring: Keep exploring
297296
with_these_guides: with these guides.
297+
great_work: Great work!
298+
you_are_done: You're done!
299+
guide_license: Guide license
298300
seo:
299301
blogs: 有关 Open Liberty 的最新新闻和信息,这是用于构建云本机 Java 应用程序和微服务的轻量级开放式框架。 博客包括最新发布和 beta 更新,有关 Jakarta EE , MicroProfile, Kubernetes 和容器相关 Java 技术的技术文章以及社区内容。

src/main/content/_includes/end-of-guide.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,8 @@
3434
{% endif %}
3535

3636
<div id="end_of_guide">
37-
<h2 tabindex="-1">{% t endofguide.nice_work %} {% t endofguide.where_to_next %}</h2>
37+
<h2 tabindex="-1">{% t endofguide.great_work %} {% t endofguide.you_are_done %}</h2>
3838
<div id="end_of_guide_left_section">
39-
<p id="guide_attribution"></p>
4039

4140
<h3 id="feedback_rating_question">{% t endofguide.what_do_you_think_of_this_guide %}</h3>
4241
<div id="feedback_ratings">
@@ -80,6 +79,8 @@ <h3 id="need_help">{% t endofguide.need_help %}</h3>
8079

8180
<h3>{% t endofguide.like_olio %}</h3>
8281
<a class="github-button" href="https://github.com/OpenLiberty/open-liberty" data-icon="octicon-star" aria-label="Star OpenLiberty/open-liberty on GitHub">{% t endofguide.star %}</a>
82+
83+
<p class="license"><a id="guide_attribution" target="_blank" rel="noopener noreferrer" href="https://github.com/OpenLiberty/guide-{{page.url | replace: '/guides/', ''}}/blob/prod/LICENSE">{% t endofguide.guide_license %}</a> </p>
8384
</div>
8485
<div id="end_of_guide_right_section">
8586
<h3 id="where_to_next">{% t endofguide.where_to_next %}</h3>

0 commit comments

Comments
 (0)