Add some GET tests for TEST_DATA

Author: peternewman

tools/rdm/TestDefinitions.py

@@ -29,6 +29,7 @@
                               RDM_MAX_DOMAIN_NAME_LENGTH,
                               RDM_MAX_HOSTNAME_LENGTH,
                               RDM_MAX_SERIAL_NUMBER_LENGTH,
+                              RDM_MAX_STRING_LENGTH,
                               RDM_MAX_TEST_DATA_PATTERN_LENGTH,
                               RDM_MIN_HOSTNAME_LENGTH,
                               RDM_ZERO_FOOTPRINT_DMX_ADDRESS)
@@ -8151,6 +8152,37 @@ class AllSubDevicesGetTestData(TestMixins.AllSubDevicesGetMixin,
   DATA = [1]
 
 
+class GetTestDataPatternLengthZero(TestMixins.GetTestDataMixin,
+                                   OptionalParameterTestFixture):
+  """GET TEST_DATA with a pattern length of 0."""
+  PATTERN_LENGTH = 0
+
+
+class GetTestDataPatternLengthOne(TestMixins.GetTestDataMixin,
+                                  OptionalParameterTestFixture):
+  """GET TEST_DATA with a pattern length of 1."""
+  PATTERN_LENGTH = 1
+
+
+class GetTestDataPatternLengthMaxStringLength(TestMixins.GetTestDataMixin,
+                                              OptionalParameterTestFixture):
+  """GET TEST_DATA with a pattern length of the max string length."""
+  PATTERN_LENGTH = RDM_MAX_STRING_LENGTH
+
+
+class GetTestDataPatternLengthMaxPDL(TestMixins.GetTestDataMixin,
+                                     OptionalParameterTestFixture):
+  """GET TEST_DATA with a pattern length of the max PDL."""
+  # TODO(Peter): Make this a constant
+  PATTERN_LENGTH = 231
+
+
+class GetTestDataPatternLengthMaxPatternLength(TestMixins.GetTestDataMixin,
+                                     OptionalParameterTestFixture):
+  """GET TEST_DATA with a pattern length of the max pattern length."""
+  PATTERN_LENGTH = RDM_MAX_TEST_DATA_PATTERN_LENGTH
+
+
 class GetTestDataWithNoData(TestMixins.GetWithNoDataMixin,
                             OptionalParameterTestFixture):
   """GET TEST_DATA with no argument given."""

tools/rdm/TestMixins.py

@@ -241,6 +241,33 @@ def VerifyResult(self, response, fields):
            url_field))
 
 
+class GetTestDataMixin(ResponderTestFixture):
+  """GET TEST_DATA PID with a given pattern length.
+
+    If ALLOWED_NACKS is non-empty, this adds a custom NackGetResult to the list
+    of allowed results for each entry.
+  """
+  PID = 'TEST_DATA'
+  CATEGORY = TestCategory.NETWORK_MANAGEMENT
+  PATTERN_LENGTH = 1
+  ALLOWED_NACKS = []
+  EXPECTED_FIELDS = ['pattern_data']
+
+  def Test(self):
+    expected_value = []
+    for i in range(0, self.PATTERN_LENGTH):
+      expected_value.append({'data': (i % (255 + 1))})
+    results = [
+      self.AckGetResult(
+          field_names=self.EXPECTED_FIELDS,
+          field_values={self.EXPECTED_FIELDS[0]: expected_value})
+    ]
+    for nack in self.ALLOWED_NACKS:
+      results.append(self.NackGetResult(nack))
+    self.AddIfGetSupported(results)
+    self.SendGet(PidStore.ROOT_DEVICE, self.pid, [self.PATTERN_LENGTH])
+
+
 class GetRequiredMixin(ResponderTestFixture):
   """GET Mixin for a required PID. Verify EXPECTED_FIELDS is in the response.