From df58cc41f866d5241105caca60347160da9b5b12 Mon Sep 17 00:00:00 2001 From: Luke Nelson Date: Fri, 29 Aug 2025 22:12:12 +0000 Subject: [PATCH 1/5] Apply feedback from #5100 --- .../stairville/revueled-120-cob-rgbww.json | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/fixtures/stairville/revueled-120-cob-rgbww.json b/fixtures/stairville/revueled-120-cob-rgbww.json index 20594f270d..4b5dbff013 100644 --- a/fixtures/stairville/revueled-120-cob-rgbww.json +++ b/fixtures/stairville/revueled-120-cob-rgbww.json @@ -68,13 +68,20 @@ }, "Strobe": { "defaultValue": 0, - "capability": { - "type": "ShutterStrobe", - "shutterEffect": "Strobe", - "speedStart": "0%", - "speedEnd": "100%", - "helpWanted": "At which DMX value is strobe disabled? When is the lamp constantly on/off?" - } + "capabilities": [ + { + "dmxRange": [0, 9], + "type": "ShutterStrobe", + "shutterEffect": "Open" + }, + { + "dmxRange": [10, 255], + "type": "ShutterStrobe", + "shutterEffect": "Strobe", + "speedStart": "0%", + "speedEnd": "100%" + } + ] }, "Auto Programs": { "defaultValue": 0, From db04b99d165268e5668477947224e328309b29c6 Mon Sep 17 00:00:00 2001 From: Luke Nelson Date: Fri, 29 Aug 2025 22:15:50 +0000 Subject: [PATCH 2/5] Apply feedback from #5100 --- fixtures/stairville/revueled-120-cob-rgbww.json | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fixtures/stairville/revueled-120-cob-rgbww.json b/fixtures/stairville/revueled-120-cob-rgbww.json index 4b5dbff013..5c646a689c 100644 --- a/fixtures/stairville/revueled-120-cob-rgbww.json +++ b/fixtures/stairville/revueled-120-cob-rgbww.json @@ -85,11 +85,18 @@ }, "Auto Programs": { "defaultValue": 0, - "capability": { + "capabilities": [ + { + "dmxRange": [0, 9], + "type": "NoFunction" + }, + { + "dmxRange": [10, 255], "type": "Effect", "effectName": "Built-in automatic show programs", - "helpWanted": "At which DMX values can a show program be selected and when is no show active?" + "helpWanted": "What programs are available and at which DMX values?" } + ] } }, "modes": [ From 11f2beadf83e9f0ce68060662694ef4cd00f7ac9 Mon Sep 17 00:00:00 2001 From: Luke Nelson Date: Fri, 29 Aug 2025 22:16:02 +0000 Subject: [PATCH 3/5] Update metadata --- fixtures/stairville/revueled-120-cob-rgbww.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fixtures/stairville/revueled-120-cob-rgbww.json b/fixtures/stairville/revueled-120-cob-rgbww.json index 5c646a689c..5d5daf9447 100644 --- a/fixtures/stairville/revueled-120-cob-rgbww.json +++ b/fixtures/stairville/revueled-120-cob-rgbww.json @@ -4,9 +4,9 @@ "shortName": "SVRevue120RGBWW", "categories": ["Color Changer"], "meta": { - "authors": ["RAZAKANIRINA"], + "authors": ["RAZAKANIRINA", "pade", "luc122c"], "createDate": "2019-04-15", - "lastModifyDate": "2024-11-23" + "lastModifyDate": "2025-08-29" }, "links": { "manual": [ @@ -95,7 +95,7 @@ "type": "Effect", "effectName": "Built-in automatic show programs", "helpWanted": "What programs are available and at which DMX values?" - } + } ] } }, From 9bbde25c77d3c6a5f303ebfa520884931424864f Mon Sep 17 00:00:00 2001 From: Luke Nelson Date: Fri, 29 Aug 2025 22:21:59 +0000 Subject: [PATCH 4/5] Fix lint issues --- fixtures/stairville/revueled-120-cob-rgbww.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fixtures/stairville/revueled-120-cob-rgbww.json b/fixtures/stairville/revueled-120-cob-rgbww.json index 5d5daf9447..c129462d38 100644 --- a/fixtures/stairville/revueled-120-cob-rgbww.json +++ b/fixtures/stairville/revueled-120-cob-rgbww.json @@ -74,8 +74,8 @@ "type": "ShutterStrobe", "shutterEffect": "Open" }, - { - "dmxRange": [10, 255], + { + "dmxRange": [10, 255], "type": "ShutterStrobe", "shutterEffect": "Strobe", "speedStart": "0%", @@ -91,10 +91,10 @@ "type": "NoFunction" }, { - "dmxRange": [10, 255], - "type": "Effect", - "effectName": "Built-in automatic show programs", - "helpWanted": "What programs are available and at which DMX values?" + "dmxRange": [10, 255], + "type": "Effect", + "effectName": "Built-in automatic show programs", + "helpWanted": "What programs are available and at which DMX values?" } ] } From 0a36ce8e8bc008b6c9d9965214b527687bcd0b21 Mon Sep 17 00:00:00 2001 From: Luke Nelson Date: Mon, 1 Sep 2025 08:20:36 +0100 Subject: [PATCH 5/5] Update fixtures/stairville/revueled-120-cob-rgbww.json Co-authored-by: Flo Edelmann --- fixtures/stairville/revueled-120-cob-rgbww.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fixtures/stairville/revueled-120-cob-rgbww.json b/fixtures/stairville/revueled-120-cob-rgbww.json index c129462d38..b6c238a8cd 100644 --- a/fixtures/stairville/revueled-120-cob-rgbww.json +++ b/fixtures/stairville/revueled-120-cob-rgbww.json @@ -4,7 +4,7 @@ "shortName": "SVRevue120RGBWW", "categories": ["Color Changer"], "meta": { - "authors": ["RAZAKANIRINA", "pade", "luc122c"], + "authors": ["RAZAKANIRINA", "pade", "Luke Nelson"], "createDate": "2019-04-15", "lastModifyDate": "2025-08-29" },