fix(s3): logic bug (close #547 #548)

j2rong4cn · j2rong4cn · commit 8e19a0fb0774 · 2025-07-03T10:36:34.000+08:00
diff --git a/drivers/s3/driver.go b/drivers/s3/driver.go
@@ -97,9 +97,9 @@ func (d *S3) Link(ctx context.Context, file model.Obj, args model.LinkArgs) (*mo
 		input.ResponseContentDisposition = &disposition
 	}
 
-	req, reqErr := d.linkClient.GetObjectRequest(input)
-	if reqErr != nil {
-		return nil, fmt.Errorf("failed to create GetObject request: %w", reqErr)
+	req, _ := d.linkClient.GetObjectRequest(input)
+	if req == nil {
+		return nil, fmt.Errorf("failed to create GetObject request")
 	}
 	var link model.Link
 	var err error

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,9 @@ func (d S3) Link(ctx context.Context, file model.Obj, args model.LinkArgs) (mo`
`97`	`97`	`input.ResponseContentDisposition = &disposition`
`98`	`98`	`}`
`99`	`99`
`100`		`- req, reqErr := d.linkClient.GetObjectRequest(input)`
`101`		`- if reqErr != nil {`
`102`		`- return nil, fmt.Errorf("failed to create GetObject request: %w", reqErr)`
	`100`	`+ req, _ := d.linkClient.GetObjectRequest(input)`
	`101`	`+ if req == nil {`
	`102`	`+ return nil, fmt.Errorf("failed to create GetObject request")`
`103`	`103`	`}`
`104`	`104`	`var link model.Link`
`105`	`105`	`var err error`